feat(entities): bridge EntityClient onto NemoClient typed transport by maxdubrinsky · Pull Request #731 · NVIDIA-NeMo/nemo-platform

maxdubrinsky · 2026-07-16T18:20:11Z

Summary

Bridges the Entities service onto the NemoClient typed HTTP client (part of AIRCORE-827), following the Files/Secrets/Jobs template. This is the first slice: the generic entities router (6 endpoints). The rich generic EntityClient keeps its public API and now rides AsyncEntitiesClient instead of the Stainless AsyncEntitiesResource, so its ~225 import sites are untouched.

Part of AIRCORE-875.

What's in here

Commit 1 — scaffold the typed client

nemo_platform_plugin/entities.py → entities/ package: the rich EntityClient / EntityBase move verbatim to entities/base.py behind a thin __init__.py re-export shim, preserving from nemo_platform_plugin.entities import ... (46 direct sites + 179 via the nmp_common wrapper).
entities/types.py — Entity, EntityCreateInput, EntityUpdate, DeleteResponse wire DTOs plus list / by-name query params. No nmp_common deps; NAME_PATTERN inlined for the python-re engine.
entities/endpoints.py — the 6 entities-router endpoints as decorated stubs.
entities/client.py — EntitiesClient / AsyncEntitiesClient.
tests/entities/test_endpoints.py — PreparedRequest shape tests.

Commit 2 — re-point the transport

entities/base.py — EntityClient now holds an AsyncEntitiesClient; the six methods unwrap the response (.data() for single, .page() for list, whose metadata maps straight into PaginationInfo). Caught errors are nemo_platform_plugin.client.errors.* (.detail / .body). The service-principal header check reads the client's headers; close() closes the shared httpx transport.
as_service() re-expressed via NemoClient.with_options(headers=...).
4 construction sites build via client_from_platform(sdk, AsyncEntitiesClient): nmp_common service DI, nmp_testing create_test_client (x3), platform-seed.
tests/entities/test_client.py — transport-touching mocks rewired to the typed client and the new Entity DTO; expected_db_version now travels in the request body.

Endpoints

method	HTTP	path
create_entity	POST	/apis/entities/v2/workspaces/{workspace}/entities/{entity_type}
list_entities	GET	.../entities/{entity_type}
get_entity_by_name	GET	.../entities/{entity_type}/{name}
update_entity_by_name	PUT	.../entities/{entity_type}/{name}
delete_entity_by_name	DELETE	.../entities/{entity_type}/{name}
get_entity_by_id	GET	/apis/entities/v2/entities/{entity_id}

Verification

Unit: 12 plugin endpoint tests + 91 nmp_common entities tests pass.
End-to-end: 41 hello-world integration tests pass (real EntityClient create/get/list/update/delete through client_from_platform → AsyncEntitiesClient → in-memory entities routes).
Server unaffected: services/core/entities 474 tests pass.
Broader: nmp_common full package 1035 tests pass.
ty 0 net-new (base.py 6 diagnostics → 1 pre-existing); ruff clean; no circular import.

Deferred (follow-ups on AIRCORE-875)

Projects (5) + Workspaces (9) routers — the other two of the three routers; consumed via sdk.projects.* / sdk.workspaces.*, they need their own low-level endpoints plus consumer migration.
Server single-source-of-truth (MIGRATION.md 3e): point the entities service schemas.py at entities/types.py.
Broader sdk.entities.* consumer sweep, then drop the Stainless entities resource entirely.

Draft, opening for early review. Branch is based on 1525a6cc6; main has since moved to a large intake experiments refactor this branch does not touch, so a rebase should be clean.

Summary by CodeRabbit

New Features
- Added a typed Entities client supporting create, list, retrieve, update, and delete operations.
- Added structured entity responses, request validation, pagination, filtering, sorting, and optimistic-locking support.
- Improved service-principal and internal request handling for entity access.
Documentation
- Updated controller, middleware, platform-service, and entity guidance with the current client setup examples.
Bug Fixes
- Improved HTTP error handling and case-insensitive principal resolution.
- Fixed cleanup behavior during deployment and job creation failures.

github-actions · 2026-07-16T18:31:34Z

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	28287/36121	78.3%	62.7%
Integration Tests	16874/34839	48.4%	21.0%

coderabbitai · 2026-07-20T15:59:48Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR introduces typed Entities DTOs, endpoints, and clients; rewires EntityClient and platform consumers from AsyncEntitiesResource to AsyncEntitiesClient; updates service and test infrastructure; and adjusts deployment rollback, validation, documentation, and integration tests.

Changes

Typed Entities API

Layer / File(s)	Summary
Entities contracts and client implementation `packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/*`	Adds typed DTOs, endpoint declarations, sync/async clients, package re-exports, and rewires CRUD, pagination, grouping, optimistic locking, and response handling.
Entities API validation `packages/nemo_platform_plugin/tests/entities/*`, `packages/nemo_platform_plugin/tests/test_entity_client.py`	Tests request construction, typed responses, query parameters, grouped counts, and HTTP error precedence.

Shared client wiring

Layer / File(s)	Summary
Service and test client adaptation `packages/nmp_common/src/...`, `packages/nmp_testing/src/...`, `packages/nmp_common/tests/...`	Uses `client_from_platform(..., AsyncEntitiesClient)` for service, on-behalf-of, seeding, and test clients; updates response mocks and `as_service()` coverage.

Consumer migration

Layer / File(s)	Summary
Documentation and middleware wiring `packages/nemo_platform_plugin/.agents/`, `packages/nemo_platform_plugin/docs/`, `plugins/example-plugin/*`	Updates documented and example startup patterns to use typed entities clients and reuses the middleware client during config lookup.
Platform service consumers `plugins/nemo-agents/`, `plugins/nemo-auditor/`, `plugins/nemo-evaluator/`, `plugins/nemo-insights/`, `services/core/models/`, `services/platform-seed/`	Adapts controllers, audit, persistence, insights, model, and seed paths to the typed client; adds audit input validation and related test coverage.

Deployment runtime

Layer / File(s)	Summary
Deployment client and rollback wiring `plugins/nemo-deployments/src/*`	Switches deployment controllers and backends to typed entity clients, reorders Docker GPU initialization, and makes Kubernetes rollback/configmap conditions explicit.

Deployment validation

Layer / File(s)	Summary
Deployment fixtures and tests `plugins/nemo-deployments/tests/*`	Updates adapter mocks, typed startup assertions, polling checks, static-analysis annotations, Kubernetes assertions, and backend test stubs.

Possibly related PRs

NVIDIA-NeMo/nemo-platform#937: Refactors internals used by the shared client_from_platform adapter.
NVIDIA-NeMo/nemo-platform#951: Adds related API and conflict handling for expected_db_version deletion guards.

Suggested labels: refactor, test, docs

Suggested reviewers: marcusds, mikeknep

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 41.06% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the main change: moving EntityClient onto the typed NemoClient transport.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch aircore-875-migrate-entities-to-nemoclient/md

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py`:
- Around line 150-167: The GPU allocation flow in the deployment method must
release reservations on every failure path. Wrap all allocation-dependent work,
including port lookup, image pulling, container-argument construction, and the
containers.run call, in try/finally; invoke release_gpu_allocation in finally
unless containers.run completed successfully, while preserving existing
GPUAllocationError handling and success behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f3a0c3e2-5820-4c98-b7c9-61911f4c0d3b

📥 Commits

Reviewing files that changed from the base of the PR and between 321736d and 77c9a9a.

📒 Files selected for processing (44)

packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-controller/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-entities/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-inference-middleware/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-platform-services/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/CONTROLLER.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/__init__.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/client.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/endpoints.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/types.py
packages/nemo_platform_plugin/tests/entities/test_endpoints.py
packages/nmp_common/src/nmp/common/entities/client.py
packages/nmp_common/src/nmp/common/service/base.py
packages/nmp_common/tests/entities/test_client.py
packages/nmp_testing/src/nmp/testing/client.py
plugins/example-plugin/src/nemo_example_plugin/middleware.py
plugins/example-plugin/tests/test_inference_middleware.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/controller.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/deployments_backend.py
plugins/nemo-agents/tests/unit/test_runner_controller.py
plugins/nemo-agents/tests/unit/test_runner_deployments.py
plugins/nemo-auditor/src/nemo_auditor/jobs/audit.py
plugins/nemo-auditor/tests/test_audit_job.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/backend.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/deployments.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/jobs.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/labels.py
plugins/nemo-deployments/src/nemo_deployments_plugin/controller.py
plugins/nemo-deployments/tests/integration/backends/docker/test_docker_backend.py
plugins/nemo-deployments/tests/integration/backends/k8s/test_k8s_backend.py
plugins/nemo-deployments/tests/integration/test_reconcile_docker.py
plugins/nemo-deployments/tests/integration/test_reconcile_k8s.py
plugins/nemo-deployments/tests/unit/backends/docker/conftest.py
plugins/nemo-deployments/tests/unit/backends/k8s/conftest.py
plugins/nemo-deployments/tests/unit/reconciler/test_controller.py
plugins/nemo-deployments/tests/unit/test_registry.py
plugins/nemo-evaluator/src/nemo_evaluator/jobs/result_persistence.py
plugins/nemo-evaluator/tests/test_result_persistence.py
plugins/nemo-insights/src/nemo_insights_plugin/controller.py
services/core/models/src/nmp/core/models/controllers/backends/deployments_plugin/backend.py
services/core/models/tests/integration/test_model_deployment_config_service_integration.py
services/core/models/tests/integration/test_model_deployment_service_integration.py
services/platform-seed/src/nmp/platform_seed/tasks/seed/run.py

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/INFERENCE_MIDDLEWARE.md`:
- Around line 154-159: Update get_middleware_config to replace the undefined sdk
reference with the SDK available on self when constructing the
NemoEntitiesClient, or explicitly add sdk as a parameter and use that parameter
consistently. Ensure the documentation example executes without a NameError.

In `@packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py`:
- Around line 680-681: Update the entity update-field construction around the
project assignment so it distinguishes an omitted project from an explicitly
cleared project. When EntityUpdate.project is None because the field was
cleared, include project with a null value in update_fields; retain omission
only when project was not provided.
- Around line 758-766: The delete_by_id flow around _client.get_entity_by_id and
delete_entity_by_name is not atomic and ignores the caller’s expected entity
type. Replace the lookup-plus-name-delete sequence with an ID-targeted delete
operation that enforces the supplied entity type, or ensure the delete request
validates the fetched entity ID/version and expected type before deletion.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0e2910d4-6cc8-48c5-9f28-b6d661b63d70

📥 Commits

Reviewing files that changed from the base of the PR and between 1b855a0 and bd2626d.

📒 Files selected for processing (17)

packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/INFERENCE_MIDDLEWARE.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/types.py
packages/nemo_platform_plugin/tests/test_entity_client.py
packages/nmp_common/src/nmp/common/service/base.py
packages/nmp_common/tests/nmp_common/test_dependency_provider.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/controller.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/deployments_backend.py
plugins/nemo-agents/tests/unit/test_runner_controller.py
plugins/nemo-agents/tests/unit/test_runner_deployments.py
plugins/nemo-auditor/src/nemo_auditor/jobs/audit.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/backend.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/deployments.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/jobs.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/labels.py
plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py

🚧 Files skipped from review as they are similar to previous changes (11)

plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/jobs.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/deployments.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/controller.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/labels.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/deployments_backend.py
plugins/nemo-agents/tests/unit/test_runner_deployments.py
packages/nmp_common/src/nmp/common/service/base.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/types.py
plugins/nemo-auditor/src/nemo_auditor/jobs/audit.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/backend.py
plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py`:
- Around line 188-189: Update the post-allocation flow in the Docker backend
around gpu_pool and gpu_ids so every operation before successful
primary-container creation, including port discovery, local-image lookup, and
run-argument construction, is enclosed in a cleanup boundary. Track whether the
primary container was created successfully and release the deployment key
through the existing GPU-pool cleanup path whenever any earlier step raises;
preserve the reservation only after successful creation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f64ad43d-fdf3-40d1-bcf6-c9553db1bd8c

📥 Commits

Reviewing files that changed from the base of the PR and between 2b6d59e and 6c6d5e1.

📒 Files selected for processing (44)

packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-controller/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-entities/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-inference-middleware/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-platform-services/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/CONTROLLER.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/INFERENCE_MIDDLEWARE.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/__init__.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/client.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/endpoints.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/types.py
packages/nemo_platform_plugin/tests/entities/test_endpoints.py
packages/nemo_platform_plugin/tests/test_entity_client.py
packages/nmp_common/src/nmp/common/entities/client.py
packages/nmp_common/src/nmp/common/service/base.py
packages/nmp_common/tests/entities/test_client.py
packages/nmp_common/tests/nmp_common/test_dependency_provider.py
packages/nmp_testing/src/nmp/testing/client.py
plugins/example-plugin/src/nemo_example_plugin/middleware.py
plugins/example-plugin/tests/test_inference_middleware.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/controller.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/deployments_backend.py
plugins/nemo-agents/tests/unit/test_runner_controller.py
plugins/nemo-agents/tests/unit/test_runner_deployments.py
plugins/nemo-auditor/src/nemo_auditor/jobs/audit.py
plugins/nemo-auditor/tests/test_audit_job.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/backend.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/deployments.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/jobs.py
plugins/nemo-deployments/src/nemo_deployments_plugin/controller.py
plugins/nemo-deployments/tests/integration/backends/docker/test_docker_backend.py
plugins/nemo-deployments/tests/integration/backends/k8s/test_k8s_backend.py
plugins/nemo-deployments/tests/integration/test_reconcile_docker.py
plugins/nemo-deployments/tests/integration/test_reconcile_k8s.py
plugins/nemo-deployments/tests/unit/backends/docker/conftest.py
plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py
plugins/nemo-deployments/tests/unit/backends/docker/test_image_pull_auth.py
plugins/nemo-deployments/tests/unit/backends/k8s/conftest.py
plugins/nemo-deployments/tests/unit/reconciler/test_controller.py
plugins/nemo-deployments/tests/unit/test_registry.py
plugins/nemo-evaluator/src/nemo_evaluator/jobs/result_persistence.py
plugins/nemo-evaluator/tests/test_result_persistence.py
plugins/nemo-insights/src/nemo_insights_plugin/controller.py

🚧 Files skipped from review as they are similar to previous changes (34)

plugins/example-plugin/src/nemo_example_plugin/middleware.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-controller/SKILL.md
plugins/nemo-evaluator/tests/test_result_persistence.py
packages/nmp_common/src/nmp/common/entities/client.py
packages/nmp_common/tests/nmp_common/test_dependency_provider.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/endpoints.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/init.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/jobs.py
plugins/nemo-deployments/tests/unit/backends/k8s/conftest.py
packages/nmp_testing/src/nmp/testing/client.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-entities/SKILL.md
plugins/nemo-deployments/tests/unit/test_registry.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/deployments_backend.py
packages/nmp_common/src/nmp/common/service/base.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/CONTROLLER.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/types.py
plugins/nemo-deployments/src/nemo_deployments_plugin/backends/k8s/deployments.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-platform-services/SKILL.md
packages/nemo_platform_plugin/tests/entities/test_endpoints.py
plugins/nemo-agents/tests/unit/test_runner_deployments.py
plugins/nemo-deployments/tests/integration/test_reconcile_docker.py
plugins/nemo-agents/src/nemo_agents_plugin/runner/controller.py
plugins/example-plugin/tests/test_inference_middleware.py
plugins/nemo-auditor/tests/test_audit_job.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/.agents/skills/plugin-inference-middleware/SKILL.md
packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/client.py
packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/INFERENCE_MIDDLEWARE.md
plugins/nemo-insights/src/nemo_insights_plugin/controller.py
plugins/nemo-deployments/tests/integration/backends/k8s/test_k8s_backend.py
plugins/nemo-deployments/tests/integration/test_reconcile_k8s.py
plugins/nemo-evaluator/src/nemo_evaluator/jobs/result_persistence.py
plugins/nemo-deployments/tests/integration/backends/docker/test_docker_backend.py
plugins/nemo-deployments/tests/unit/reconciler/test_controller.py
plugins/nemo-auditor/src/nemo_auditor/jobs/audit.py

Convert nemo_platform_plugin/entities.py into a package. The rich generic EntityClient moves verbatim to entities/base.py behind an __init__.py re-export shim, so the existing `from nemo_platform_plugin.entities import ...` surface (46 direct sites, 179 via the nmp_common wrapper) keeps working. Add the low-level NemoClient typed layer alongside it: - types.py: Entity / EntityCreateInput / EntityUpdate / DeleteResponse wire DTOs plus list and by-name query params (no nmp_common deps; NAME_PATTERN inlined for the python-re engine) - endpoints.py: the 6 entities-router endpoints as decorated stubs - client.py: EntitiesClient / AsyncEntitiesClient via the method() descriptor - tests/entities/test_endpoints.py: PreparedRequest shape tests No behavior change: EntityClient still rides the Stainless AsyncEntitiesResource transport. This lands the typed layer and package restructure; the transport re-point follows. Part of AIRCORE-875. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

Swap the transport under the rich generic EntityClient from the Stainless AsyncEntitiesResource to the NemoClient-based AsyncEntitiesClient, keeping EntityClient's public API identical so its ~225 import sites are unchanged. - base.py: EntityClient now holds an AsyncEntitiesClient. The six methods call it and unwrap the response (.data() for single, .page() for list, whose metadata maps straight into PaginationInfo). Caught errors are now nemo_platform_plugin.client.errors.* (.detail/.body). The service-principal header check reads the client's headers, and close() closes the shared httpx transport. - as_service() re-expressed via NemoClient.with_options(headers=...). - 4 construction sites (service DI, nmp_testing create_test_client x3, platform-seed) build via client_from_platform(sdk, AsyncEntitiesClient). - test_client.py: rewire the transport-touching mocks to the typed client and the new Entity DTO; expected_db_version now travels in the request body. Drops the Stainless entities resource from the EntityClient path. Verified: entities suites green (103 + 91), hello-world integration green (41), ty 0 net-new (base.py 6 diagnostics -> 1 pre-existing), no circular import. Part of AIRCORE-875. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

…error type Two consumer breakages surfaced by the EntityClient re-point in CI: - EntityCreateInput / EntityUpdate carried a client-side name pattern, so a service creating an entity with an invalid name (e.g. secrets) raised a pydantic ValidationError internally instead of receiving the entities server's 422. Drop the pattern from the request DTOs so the server validates and returns 422, restoring pre-migration behavior (the secrets "422 not 500" test asserts exactly this). - EntityClient.list leaks the transport error on a 404, whose type changed from nemo_platform.NotFoundError to the client's NotFoundError. Repoint the two model-deployment integration test imports to nemo_platform_plugin.client.errors, matching the already-migrated secrets tests. Verified locally: the 8 previously-failing tests pass (6 models + 2 secrets); entities 103, models 43, secrets 37, hello-world 41 all green; ty neutral on the touched files; no production code catches a Stainless transport error around an entity_client.list call. Part of AIRCORE-875. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

count_by reads group_counts straight off the response envelope rather than going through page(), and paginated responses defer raise_for_status to page()/items()/pages(). Nothing raised on a non-2xx, so a 404, 400 or 401 came back as "Grouped counts not found in response", and a 5xx with a non-JSON body escaped as a raw JSONDecodeError instead of a client error. The pre-migration SDK path raised on status, so this was a regression introduced while porting count_by onto the typed client. Check the status explicitly before reading the body, and cover 404 and 400 with a regression test. Also refresh two doc examples the migration missed that still constructed a client the old way. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

get_middleware_config built its entity client from an `sdk` name the method never defines or receives, so the snippet raised NameError as written. The example was already broken before the typed-client migration, where it called NemoEntitiesClient() with no arguments at all. Mirror the working example-plugin instead: construct the client once in setup() via get_async_platform_sdk, then reuse it per request. Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

github-actions Bot added the feat label Jul 16, 2026

maxdubrinsky marked this pull request as ready for review July 20, 2026 15:52

maxdubrinsky requested review from a team as code owners July 20, 2026 15:52

coderabbitai Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py

This was referenced Jul 20, 2026

fix(openapi): schema name collision hardening #786

Merged

fix(auth): run generic entity E2E tests as a service principal #845

Open

feat(models): support LoRA deployments on the docker backend #870

Merged

coderabbitai Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread packages/nemo_platform_plugin/src/nemo_platform_plugin/docs/INFERENCE_MIDDLEWARE.md Outdated

Comment thread packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py

Comment thread packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py

coderabbitai Bot mentioned this pull request Jul 28, 2026

chore(sdk): refactor sdk service lifecycle #937

Open

maxdubrinsky requested review from marcusds and mikeknep July 28, 2026 20:14

maxdubrinsky force-pushed the aircore-875-migrate-entities-to-nemoclient/md branch from 2b6d59e to 6c6d5e1 Compare July 29, 2026 19:37

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py

maxdubrinsky added 6 commits July 30, 2026 11:04

fix(entities): migrate remaining consumers to typed client

ebfc164

Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

marcusds reviewed Jul 30, 2026

View reviewed changes

Comment thread packages/nemo_platform_plugin/src/nemo_platform_plugin/entities/base.py

marcusds approved these changes Jul 30, 2026

View reviewed changes

maxdubrinsky force-pushed the aircore-875-migrate-entities-to-nemoclient/md branch from 6c6d5e1 to 2abb4d4 Compare July 30, 2026 17:16

maxdubrinsky added this pull request to the merge queue Jul 30, 2026

Merged via the queue into main with commit b5ad453 Jul 30, 2026
62 checks passed

maxdubrinsky deleted the aircore-875-migrate-entities-to-nemoclient/md branch July 30, 2026 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(entities): bridge EntityClient onto NemoClient typed transport - #731

feat(entities): bridge EntityClient onto NemoClient typed transport#731
maxdubrinsky merged 6 commits into
mainfrom
aircore-875-migrate-entities-to-nemoclient/md

maxdubrinsky commented Jul 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

maxdubrinsky commented Jul 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What's in here

Endpoints

Verification

Deferred (follow-ups on AIRCORE-875)

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maxdubrinsky commented Jul 16, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Jul 16, 2026 •

edited

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading