Skip to content

ci: stop publishing SDK wheels nightly - #871

Closed
svvarom wants to merge 2 commits into
mainfrom
disable-nightly-sdk-releases/svvarom
Closed

ci: stop publishing SDK wheels nightly#871
svvarom wants to merge 2 commits into
mainfrom
disable-nightly-sdk-releases/svvarom

Conversation

@svvarom

@svvarom svvarom commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Nightly releases currently use release-scope: all, which publishes SDK wheels alongside containers and Helm. This changes nightly all to select only containers and Helm, and rejects explicit nightly wheel selections before anything is dispatched. Stable releases are unchanged.

Human attention needed

  • Decision: nightlies publish containers and Helm only; SDK wheels remain stable-only.
  • Proof: full pre-commit, actionlint, and release-planner checks passed.
  • Biggest risk: the first scheduled run is the live end-to-end confirmation.

Summary by CodeRabbit

  • Documentation

    • Clarified release workflow inputs and help text for release type/scope and wheel selection.
    • Updated release guidance to reflect that nightly releases publish only containers and Helm; wheels are stable-only.
    • Added notes that wheel selections for nightly releases fail during planning.
  • Bug Fixes

    • Fixed the all preset to select wheels only for stable releases (nightly yields no wheels).
    • Added validation to error out when nightly releases include selected wheel artifacts.

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@svvarom
svvarom marked this pull request as ready for review July 23, 2026 19:38
@svvarom
svvarom requested review from a team as code owners July 23, 2026 19:38
@svvarom
svvarom requested a review from crookedstorm July 23, 2026 19:38
@svvarom svvarom self-assigned this Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93ec2758-2470-4394-8071-923018fbdc3d

📥 Commits

Reviewing files that changed from the base of the PR and between a579a52 and 714d326.

📒 Files selected for processing (1)
  • RELEASING.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • RELEASING.md

📝 Walkthrough

Walkthrough

Nightly release planning now publishes containers and Helm only. The all preset excludes wheels for nightlies, explicit nightly wheel selections fail during planning, and RELEASING.md documents the updated stable and nightly behavior.

Changes

Release artifact policy

Layer / File(s) Summary
Workflow selection and validation
.github/workflows/release.yaml
Workflow inputs clarify nightly scope, the all preset excludes wheels from nightlies, and planning rejects nightly releases with selected wheels.
Release process documentation
RELEASING.md
Release guidance documents nightly container and Helm publication, stable-only wheels, updated planning and dispatch behavior, and nightly wheel selection failures.

Possibly related PRs

Suggested reviewers: crookedstorm

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: nightly releases no longer publish SDK wheels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch disable-nightly-sdk-releases/svvarom

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
RELEASING.md (1)

54-59: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy lift

Keep this page in one Diátaxis quadrant.

These changed input and publication tables are reference material embedded in a procedural HOW-TO. Move them to a REFERENCE page, link it here, and add a Next Steps section at the document end.

As per coding guidelines, each documentation page should fit ONE Diataxis quadrant; use cross-links instead, and include a Next Steps section at the end.

Also applies to: 112-118

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@RELEASING.md` around lines 54 - 59, Move the changed release input and
publication tables out of the procedural HOW-TO into a dedicated REFERENCE page,
then link to that page from RELEASING.md. Add a Next Steps section at the end of
RELEASING.md with the appropriate follow-up links, keeping the HOW-TO focused on
procedural instructions and applying the same change to the additional
publication table.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@RELEASING.md`:
- Around line 81-90: Update the release procedure’s dispatch step to state that
selected container, stable wheel, and registration work is dispatched only for
non-dry-run releases, while preserving the existing dispatch details.

---

Nitpick comments:
In `@RELEASING.md`:
- Around line 54-59: Move the changed release input and publication tables out
of the procedural HOW-TO into a dedicated REFERENCE page, then link to that page
from RELEASING.md. Add a Next Steps section at the end of RELEASING.md with the
appropriate follow-up links, keeping the HOW-TO focused on procedural
instructions and applying the same change to the additional publication table.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2ba5609a-fb12-42f1-9772-33efa7fad6cf

📥 Commits

Reviewing files that changed from the base of the PR and between 840f160 and a579a52.

📒 Files selected for processing (2)
  • .github/workflows/release.yaml
  • RELEASING.md

Comment thread RELEASING.md Outdated
@github-actions github-actions Bot added the ci label Jul 23, 2026

@crookedstorm crookedstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests N/A N/A N/A
Integration Tests 15921/33544 47.5% 19.9%

@svvarom

svvarom commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@svvarom svvarom closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants