ci: stop publishing SDK wheels nightly - #871
Conversation
Signed-off-by: Swarom Muley <smuley@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughNightly release planning now publishes containers and Helm only. The ChangesRelease artifact policy
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
RELEASING.md (1)
54-59: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftKeep this page in one Diátaxis quadrant.
These changed input and publication tables are reference material embedded in a procedural HOW-TO. Move them to a REFERENCE page, link it here, and add a
Next Stepssection at the document end.As per coding guidelines, each documentation page should fit ONE Diataxis quadrant; use cross-links instead, and include a Next Steps section at the end.
Also applies to: 112-118
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@RELEASING.md` around lines 54 - 59, Move the changed release input and publication tables out of the procedural HOW-TO into a dedicated REFERENCE page, then link to that page from RELEASING.md. Add a Next Steps section at the end of RELEASING.md with the appropriate follow-up links, keeping the HOW-TO focused on procedural instructions and applying the same change to the additional publication table.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@RELEASING.md`:
- Around line 81-90: Update the release procedure’s dispatch step to state that
selected container, stable wheel, and registration work is dispatched only for
non-dry-run releases, while preserving the existing dispatch details.
---
Nitpick comments:
In `@RELEASING.md`:
- Around line 54-59: Move the changed release input and publication tables out
of the procedural HOW-TO into a dedicated REFERENCE page, then link to that page
from RELEASING.md. Add a Next Steps section at the end of RELEASING.md with the
appropriate follow-up links, keeping the HOW-TO focused on procedural
instructions and applying the same change to the additional publication table.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2ba5609a-fb12-42f1-9772-33efa7fad6cf
📒 Files selected for processing (2)
.github/workflows/release.yamlRELEASING.md
Signed-off-by: Swarom Muley <smuley@nvidia.com>
|
|
Closing in favor of: https://github.com/NVIDIA-NeMo/nemo-platform/pull/877/changes |
Nightly releases currently use
release-scope: all, which publishes SDK wheels alongside containers and Helm. This changes nightlyallto select only containers and Helm, and rejects explicit nightly wheel selections before anything is dispatched. Stable releases are unchanged.Human attention needed
Summary by CodeRabbit
Documentation
Bug Fixes
allpreset to select wheels only for stable releases (nightly yields no wheels).