Skip to content

fix(helm): qualify default image references - #883

Merged
svvarom merged 2 commits into
mainfrom
qualify-helm-image-defaults/smuley
Jul 24, 2026
Merged

fix(helm): qualify default image references#883
svvarom merged 2 commits into
mainfrom
qualify-helm-image-defaults/smuley

Conversation

@svvarom

@svvarom svvarom commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

CRI‑O will reject short image names for K8s v1.34, so we need to use fully qualified image refs.

It’s better to embed the image source directly in the Helm chart templates instead of relying on implicit defaults.

Source: https://www.replicated.com/blog/breaking-change-kubernetes-1-34-tightens-image-name-resolution-rules----what-it-means-for-you

Summary by CodeRabbit

  • Chores
    • Updated default container image references to use fully qualified Docker Hub paths.
    • Updated the Helm chart documentation to reflect the revised volume permissions image reference.

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@github-actions github-actions Bot added the fix label Jul 24, 2026
@svvarom
svvarom marked this pull request as ready for review July 24, 2026 01:26
@svvarom
svvarom requested review from a team as code owners July 24, 2026 01:26
@svvarom svvarom self-assigned this Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 27157/34869 77.9% 62.1%
Integration Tests 15968/33581 47.5% 20.0%

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 49ef6707-9178-4917-879e-833a1d9c8dd2

📥 Commits

Reviewing files that changed from the base of the PR and between 97d5e6c and 0ed8f6f.

📒 Files selected for processing (2)
  • k8s/helm/README.md
  • k8s/helm/values.yaml

📝 Walkthrough

Walkthrough

Helm defaults now use fully qualified Docker Hub image references for BusyBox and Envoy, and the README documents the updated BusyBox default.

Changes

Helm image references

Layer / File(s) Summary
Update Helm image defaults and documentation
k8s/helm/values.yaml, k8s/helm/README.md
volumePermissionsImage now uses docker.io/library/busybox; envoyProxy.image.repository now uses docker.io/envoyproxy/envoy; the README reflects the BusyBox update.

Suggested reviewers: ironcommit, crookedstorm

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the Helm change to fully qualify default image references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch qualify-helm-image-defaults/smuley

Comment @coderabbitai help to get the list of available commands.

@svvarom
svvarom enabled auto-merge July 24, 2026 15:13
@svvarom
svvarom added this pull request to the merge queue Jul 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 24, 2026
@crookedstorm
crookedstorm added this pull request to the merge queue Jul 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 24, 2026
@crookedstorm
crookedstorm added this pull request to the merge queue Jul 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 24, 2026
@svvarom
svvarom added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 643be04 Jul 24, 2026
58 checks passed
@svvarom
svvarom deleted the qualify-helm-image-defaults/smuley branch July 24, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants