Skip to content

fix: resolve openapi schema drift - #939

Merged
ironcommit merged 1 commit into
mainfrom
schema-drift/rsadler
Jul 28, 2026
Merged

fix: resolve openapi schema drift#939
ironcommit merged 1 commit into
mainfrom
schema-drift/rsadler

Conversation

@ironcommit

@ironcommit ironcommit commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added support for configuring an authentication-proxy sidecar and its service identity in deployment settings.
    • Updated customization job APIs to use Unsloth endpoints for job creation, monitoring, cancellation, logs, and results.
    • Expanded Automodel job configuration and output details.
  • API Updates

    • Strengthened required fields across job status, logs, results, and pagination responses.
    • Removed deprecated RL-specific job contracts from the API specification.

Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The customizer OpenAPI contract migrates job APIs and schemas from RL to Unsloth, expands Automodel and platform job schemas, and removes RL-only definitions. The deployments contract adds auth-proxy sidecar configuration fields.

Changes

Customizer API contracts

Layer / File(s) Summary
Unsloth job endpoint migration
plugins/nemo-customizer/openapi/openapi.yaml
Job creation, listing, retrieval, cancellation, deletion, logs, results, downloads, and status operations move from /rl/jobs to /unsloth/jobs and use Unsloth references.
Automodel and platform job schemas
plugins/nemo-customizer/openapi/openapi.yaml
Automodel schemas are expanded, platform job response schemas gain stricter required fields, and RL-specific schemas are removed.

Deployment configuration

Layer / File(s) Summary
Auth-proxy sidecar configuration
plugins/nemo-deployments/openapi/openapi.yaml
DeploymentConfig adds authProxySidecar with a false default and authProxySidecarIdentity for the service-principal identity.

Possibly related PRs

Suggested reviewers: anubhutivyas, mckornfield, soluwalana

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: fixing OpenAPI schema drift across the affected specs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch schema-drift/rsadler

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/nemo-deployments/openapi/openapi.yaml`:
- Around line 919-924: Update the authProxySidecarIdentity schema definition to
permit null values alongside strings, using the nullable representation
supported by this OpenAPI document’s version. Preserve its existing description
and requiredness.
- Around line 911-924: Update CreateDeploymentConfigRequest to include
authProxySidecar and authProxySidecarIdentity with the same types, descriptions,
and defaults as the existing deployment configuration fields. Add conditional
validation requiring authProxySidecarIdentity when authProxySidecar is true,
then regenerate the OpenAPI specification.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 98c87d6b-f96f-4020-8ffa-df9752aa41f8

📥 Commits

Reviewing files that changed from the base of the PR and between 0505b36 and d60e181.

📒 Files selected for processing (2)
  • plugins/nemo-customizer/openapi/openapi.yaml
  • plugins/nemo-deployments/openapi/openapi.yaml

Comment thread plugins/nemo-deployments/openapi/openapi.yaml
Comment thread plugins/nemo-deployments/openapi/openapi.yaml
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 27341/35089 77.9% 62.2%
Integration Tests 16046/33801 47.5% 19.9%

@mckornfield mckornfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that there isn't a ci check that fails... think we need to revisit the lints lol

@ironcommit
ironcommit added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit ecf5177 Jul 28, 2026
60 checks passed
@ironcommit
ironcommit deleted the schema-drift/rsadler branch July 28, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants