fix: resolve openapi schema drift - #939
Conversation
Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com>
📝 WalkthroughWalkthroughThe customizer OpenAPI contract migrates job APIs and schemas from RL to Unsloth, expands Automodel and platform job schemas, and removes RL-only definitions. The deployments contract adds auth-proxy sidecar configuration fields. ChangesCustomizer API contracts
Deployment configuration
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/nemo-deployments/openapi/openapi.yaml`:
- Around line 919-924: Update the authProxySidecarIdentity schema definition to
permit null values alongside strings, using the nullable representation
supported by this OpenAPI document’s version. Preserve its existing description
and requiredness.
- Around line 911-924: Update CreateDeploymentConfigRequest to include
authProxySidecar and authProxySidecarIdentity with the same types, descriptions,
and defaults as the existing deployment configuration fields. Add conditional
validation requiring authProxySidecarIdentity when authProxySidecar is true,
then regenerate the OpenAPI specification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 98c87d6b-f96f-4020-8ffa-df9752aa41f8
📒 Files selected for processing (2)
plugins/nemo-customizer/openapi/openapi.yamlplugins/nemo-deployments/openapi/openapi.yaml
|
mckornfield
left a comment
There was a problem hiding this comment.
Weird that there isn't a ci check that fails... think we need to revisit the lints lol
Summary by CodeRabbit
New Features
API Updates