feat: enable optimization plugins & UI - #975
Conversation
Signed-off-by: Nico Tonozzi <ntonozzi@nvidia.com>
📝 WalkthroughWalkthroughUpdated first-party plugin documentation and installation wiring, enabled Studio Intake and Optimizer defaults, regenerated dependency exports, and refreshed third-party license metadata. ChangesPlugin enablement
Studio feature defaults
Dependency and license metadata
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
…plugins/nicot Signed-off-by: Nico Tonozzi <ntonozzi@nvidia.com>
Signed-off-by: Nico Tonozzi <ntonozzi@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@third_party/osv-licenses.json`:
- Around line 1110-1123: Update the GitPython dependency pin identified near the
affected 3.1.50 entry to version 3.1.55 or later, ensuring the lockfile and
related dependency metadata remain consistent. If the pin cannot be upgraded,
add an explicit accepted-risk exception covering all listed GitPython advisories
instead.
In `@third_party/requirements-main.txt`:
- Around line 1633-1634: Remove nooa from the default dependency list in
requirements-main.txt; place it in the appropriate optional dependency group, or
replace the git reference with an indexed package only if it must remain
default. Preserve the platform markers and the nemo-experimentalist-plugin
association.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 29f856e8-c921-463a-ad9e-88c925e4c57e
📒 Files selected for processing (3)
third_party/licenses.jsonlthird_party/osv-licenses.jsonthird_party/requirements-main.txt
…plugins/nicot Signed-off-by: Nico Tonozzi <ntonozzi@nvidia.com>
…plugins/nicot Signed-off-by: Nico Tonozzi <ntonozzi@nvidia.com> # Conflicts: # pyproject.toml # third_party/osv-licenses.json # third_party/requirements-main.txt
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
third_party/osv-licenses.json (1)
2630-2639: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick winCorrect the two MIT classifications. Update
third_party/osv-licenses.jsonfor bothh2andhyperframefromnon-standardtoMIT, then adjustlicense_summary(MIT+2,non-standard-2).
third_party/osv-licenses.json#L2630-L2639:h2→MITthird_party/osv-licenses.json#L2760-L2769:hyperframe→MIT🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@third_party/osv-licenses.json` around lines 2630 - 2639, Update third_party/osv-licenses.json at lines 2630-2639 for h2 and lines 2760-2769 for hyperframe, changing each license classification from non-standard to MIT. Adjust license_summary by increasing MIT by 2 and decreasing non-standard by 2.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@third_party/osv-licenses.json`:
- Around line 2630-2639: Update third_party/osv-licenses.json at lines 2630-2639
for h2 and lines 2760-2769 for hyperframe, changing each license classification
from non-standard to MIT. Adjust license_summary by increasing MIT by 2 and
decreasing non-standard by 2.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 53328971-09ea-4537-82b3-58fdbc44602f
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
docs/agents/plugins.mdxplugins/README.mdpyproject.tomlthird_party/licenses.jsonlthird_party/osv-licenses.jsonthird_party/requirements-main.txt
🚧 Files skipped from review as they are similar to previous changes (4)
- docs/agents/plugins.mdx
- pyproject.toml
- third_party/licenses.jsonl
- third_party/requirements-main.txt
Summary
enabled-pluginsgroupValidation
uv sync --frozenuv lock --checkuv run --frozen nemo insights --helpuv run --frozen nemo experimentalist --helppnpm --filter nemo-studio-ui typecheckpnpm --filter nemo-studio-ui feature-flagspnpm --filter nemo-studio-ui buildSummary by CodeRabbit
Summary by CodeRabbit
New Features
Documentation
Configuration