feat: Validate no custom columns in DD configs - #990
Merged
Conversation
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughCustom-column validation is added to raw request, parsed configuration, preview, job, local-context, remote-context, and SDK validation paths. Integration tests cover preview, create, and remote SDK validation errors. ChangesCustom Column Validation
Sequence Diagram(s)sequenceDiagram
participant Client
participant PreviewSpec
participant DataDesignerJobConfig
participant RemoteDataDesignerContext
participant ValidationHelpers
Client->>PreviewSpec: Validate preview configuration
PreviewSpec->>ValidationHelpers: Check raw columns
Client->>DataDesignerJobConfig: Validate job configuration
DataDesignerJobConfig->>ValidationHelpers: Check raw columns
Client->>RemoteDataDesignerContext: Validate parsed configuration
RemoteDataDesignerContext->>ValidationHelpers: Check parsed columns
ValidationHelpers-->>Client: Return custom-column validation error
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream Data Designer library allows users define custom column types via a decorated Python function. These don't work in the platform plugin because we don't have the user-created implementation server-side, nor can we serialize the function and send it over the wire. Today if a user builds a config client-side with a custom column and submits that config to the service, they get a raw error message when Pydantic tries and fails to deserialize the config. This PR ensures we provide a clearer error message that custom columns are not supported here.
Summary by CodeRabbit
Bug Fixes
Tests