Skip to content

fix: tighten 3.11 and 3.12 pinning for Python, fix links - #996

Merged
mckornfield merged 1 commit into
mainfrom
bug-fixes-nvbugs/mck
Jul 30, 2026
Merged

fix: tighten 3.11 and 3.12 pinning for Python, fix links#996
mckornfield merged 1 commit into
mainfrom
bug-fixes-nvbugs/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation

    • Updated the NeMo Platform README links to hosted Setup/Get Started, CLI reference, and API reference docs.
    • Refreshed the plugin README to reflect supported Python versions (3.12–3.13).
  • Compatibility

    • Narrowed supported Python version ranges for the platform and plugin packages to Python 3.12–3.13.
  • Build & CI

    • Updated CI wheel build/test coverage to run only on Python 3.12 and 3.13.

@mckornfield
mckornfield requested review from a team as code owners July 30, 2026 18:30
@github-actions github-actions Bot added the fix label Jul 30, 2026
@mckornfield
mckornfield force-pushed the bug-fixes-nvbugs/mck branch from 231c82c to b676d81 Compare July 30, 2026 18:35
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d3245bc3-0dfc-4bc0-86d3-be183bb314bb

📥 Commits

Reviewing files that changed from the base of the PR and between f55a56f and 207dda1.

📒 Files selected for processing (8)
  • .github/wheel-constraints/nemo-platform-plugin.txt
  • .github/wheel-constraints/nemo-platform-services.txt
  • .github/workflows/ci.yaml
  • README.md
  • packages/nemo_platform/README.md
  • packages/nemo_platform/pyproject.toml
  • packages/nemo_platform_plugin/pyproject.toml
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • README.md
  • packages/nemo_platform/README.md
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md

📝 Walkthrough

Walkthrough

Package metadata and CI now target Python 3.12–3.13, evaluator dependencies and wheel constraints were updated, and README links point to hosted NeMo Platform documentation.

Changes

Platform packaging and CI

Layer / File(s) Summary
Package support and dependencies
packages/nemo_platform/pyproject.toml, packages/nemo_platform_plugin/pyproject.toml, packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
Python support metadata targets 3.12–3.13, evaluator dependencies are updated, and matching documentation examples are revised.
Wheel constraints and CI coverage
.github/wheel-constraints/*, .github/workflows/ci.yaml
The litellm cap and Python 3.14 ABI compatibility setup are removed; wheel builds and tests run on Python 3.12 and 3.13.

Documentation links

Layer / File(s) Summary
Hosted documentation links
README.md, packages/nemo_platform/README.md
Setup, CLI, and API references now link to hosted docs.nvidia.com documentation pages.

Possibly related PRs

Suggested labels: docs

Suggested reviewers: ironcommit, svvarom

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: narrower Python version support plus documentation link updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug-fixes-nvbugs/mck

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md`:
- Line 43: Update the README example’s requires-python declaration to use the
bounded range >=3.12,<3.14, aligning it with the package’s supported Python
versions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0e26b472-0f85-4f7d-844d-1dbf859cd730

📥 Commits

Reviewing files that changed from the base of the PR and between 0729f2c and 231c82c.

📒 Files selected for processing (8)
  • .github/wheel-constraints/nemo-platform-plugin.txt
  • .github/wheel-constraints/nemo-platform-services.txt
  • .github/workflows/ci.yaml
  • README.md
  • packages/nemo_platform/README.md
  • packages/nemo_platform/pyproject.toml
  • packages/nemo_platform_plugin/pyproject.toml
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md

Comment thread packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
@mckornfield
mckornfield force-pushed the bug-fixes-nvbugs/mck branch from b676d81 to f55a56f Compare July 30, 2026 18:35

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/nemo_platform_plugin/pyproject.toml`:
- Line 6: Update the Python version requirement example in QUICKSTART.md to use
the package’s supported range, >=3.12,<3.14, matching the requires-python
declaration in pyproject.toml.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 002d813e-c984-4e40-9e3d-cc1bb3d21f06

📥 Commits

Reviewing files that changed from the base of the PR and between 231c82c and f55a56f.

📒 Files selected for processing (5)
  • README.md
  • packages/nemo_platform/README.md
  • packages/nemo_platform/pyproject.toml
  • packages/nemo_platform_plugin/pyproject.toml
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
  • README.md
  • packages/nemo_platform/README.md

Comment thread packages/nemo_platform_plugin/pyproject.toml
@mckornfield
mckornfield requested review from anastasia-nesterenko and removed request for a team July 30, 2026 18:42
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 28335/36171 78.3% 62.7%
Integration Tests 16920/34889 48.5% 21.0%

Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield force-pushed the bug-fixes-nvbugs/mck branch from f55a56f to 207dda1 Compare July 30, 2026 18:53
@mckornfield
mckornfield added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 8132b8b Jul 30, 2026
54 checks passed
@mckornfield
mckornfield deleted the bug-fixes-nvbugs/mck branch July 30, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants