fix: tighten 3.11 and 3.12 pinning for Python, fix links - #996
Conversation
231c82c to
b676d81
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughPackage metadata and CI now target Python 3.12–3.13, evaluator dependencies and wheel constraints were updated, and README links point to hosted NeMo Platform documentation. ChangesPlatform packaging and CI
Documentation links
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md`:
- Line 43: Update the README example’s requires-python declaration to use the
bounded range >=3.12,<3.14, aligning it with the package’s supported Python
versions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0e26b472-0f85-4f7d-844d-1dbf859cd730
📒 Files selected for processing (8)
.github/wheel-constraints/nemo-platform-plugin.txt.github/wheel-constraints/nemo-platform-services.txt.github/workflows/ci.yamlREADME.mdpackages/nemo_platform/README.mdpackages/nemo_platform/pyproject.tomlpackages/nemo_platform_plugin/pyproject.tomlpackages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
b676d81 to
f55a56f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/nemo_platform_plugin/pyproject.toml`:
- Line 6: Update the Python version requirement example in QUICKSTART.md to use
the package’s supported range, >=3.12,<3.14, matching the requires-python
declaration in pyproject.toml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 002d813e-c984-4e40-9e3d-cc1bb3d21f06
📒 Files selected for processing (5)
README.mdpackages/nemo_platform/README.mdpackages/nemo_platform/pyproject.tomlpackages/nemo_platform_plugin/pyproject.tomlpackages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
🚧 Files skipped from review as they are similar to previous changes (3)
- packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
- README.md
- packages/nemo_platform/README.md
|
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
f55a56f to
207dda1
Compare
Summary by CodeRabbit
Documentation
Compatibility
Build & CI