[CI] Bump test containers to latest - #1299
Merged
Merged
Conversation
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated CI workflow YAMLs (Docker image bumps for TensorRT-LLM and PyTorch), refined an inline comment and a warning string in an ONNX quantization extension, and enhanced a bump-uv-lock GitHub Action step to capture Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as GitHub Actions Runner
participant UV as `uv` CLI
participant FS as Filesystem (/tmp/uv_lock_output.txt)
participant GH as GitHub API (create PR)
Runner->>UV: run `uv lock --upgrade` (with pipefail)
UV->>FS: stream combined stdout/stderr (via `2>&1 | tee`)
Runner->>FS: read `/tmp/uv_lock_output.txt` into UV_OUTPUT
Runner->>GH: create PR with body including `<details>` containing UV_OUTPUT
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/example_tests.yml:
- Line 63: Replace the unavailable container tag
"nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc12" with the public registry tag
"nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc11" in the workflow file; update
both occurrences of the docker_image setting (the string
"nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc12") so the workflow uses 1.3.0rc11
instead of rc12.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 87ffebce-f25d-44dc-96da-2735a7481423
📒 Files selected for processing (3)
.github/workflows/example_tests.yml.github/workflows/gpu_tests.ymlmodelopt/onnx/quantization/extensions.py
Contributor
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/bump_uv_lock.yml (1)
57-74: Use--body-fileinstead of inline--bodyfor multiline output.The
gh pr create --body-fileoption is explicitly supported and avoids shell quoting and escaping complexity when embedding multiline command output with variable substitution. Write the PR body to a temporary file first, then pass it via--body-file.Suggested refactor
- UV_OUTPUT=$(cat /tmp/uv_lock_output.txt) - gh pr create \ - --title "[chore]: weekly bump of uv.lock on ${BASE} ($(date +%Y-%m-%d))" \ - --body "$(cat <<EOF - ## Summary - Automated weekly update of uv.lock file for nSpect Scanning: - - \`uv.lock\` — upgraded all transitive dependencies to latest compatible versions - - <details> - <summary>uv lock --upgrade output</summary> - - \`\`\` - ${UV_OUTPUT} - \`\`\` - - </details> - EOF - )" \ - --base "$BASE" + PR_BODY_FILE=/tmp/pr_body.md + cat > "$PR_BODY_FILE" <<'EOF' + ## Summary + Automated weekly update of uv.lock file for nSpect Scanning: + - `uv.lock` — upgraded all transitive dependencies to latest compatible versions + + <details> + <summary>uv lock --upgrade output</summary> + + ``` + EOF + cat /tmp/uv_lock_output.txt >> "$PR_BODY_FILE" + cat >> "$PR_BODY_FILE" <<'EOF' + ``` + + </details> + EOF + + gh pr create \ + --title "[chore]: weekly bump of uv.lock on ${BASE} ($(date +%Y-%m-%d))" \ + --body-file "$PR_BODY_FILE" \ + --base "$BASE"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/bump_uv_lock.yml around lines 57 - 74, Replace the inline multiline --body invocation for gh pr create with a temporary PR body file: create a unique PR_BODY_FILE (e.g., mktemp), write the static header (the "## Summary" block and details opening), append the contents of /tmp/uv_lock_output.txt (UV_OUTPUT) into that file, then finish the markdown footer (closing code block and details), and call gh pr create with --body-file "$PR_BODY_FILE" (keeping the existing --title and --base); ensure you remove the inline --body here-doc and clean up the temp file after creating the PR.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/bump_uv_lock.yml:
- Around line 33-34: The step named "Run uv lock upgrade" currently pipes uv
lock --upgrade into tee which can mask failures; modify the step so the shell
enables pipefail before running uv lock --upgrade (for example by invoking the
command under a shell that has set -o pipefail) or otherwise capture and
propagate uv lock --upgrade's exit status to ensure the job fails when uv lock
fails; update the command that invokes uv lock --upgrade 2>&1 | tee
/tmp/uv_lock_output.txt accordingly so the upstream command's exit code is
preserved.
---
Nitpick comments:
In @.github/workflows/bump_uv_lock.yml:
- Around line 57-74: Replace the inline multiline --body invocation for gh pr
create with a temporary PR body file: create a unique PR_BODY_FILE (e.g.,
mktemp), write the static header (the "## Summary" block and details opening),
append the contents of /tmp/uv_lock_output.txt (UV_OUTPUT) into that file, then
finish the markdown footer (closing code block and details), and call gh pr
create with --body-file "$PR_BODY_FILE" (keeping the existing --title and
--base); ensure you remove the inline --body here-doc and clean up the temp file
after creating the PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ac347b03-8938-4ca4-8599-b12ede7a1d15
📒 Files selected for processing (1)
.github/workflows/bump_uv_lock.yml
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
kevalmorabia97
force-pushed
the
kmorabia/bump-ci
branch
from
April 20, 2026 11:28
23512a7 to
2896e13
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 75.38% 75.65% +0.26%
==========================================
Files 462 462
Lines 49944 49944
==========================================
+ Hits 37651 37783 +132
+ Misses 12293 12161 -132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevalmorabia97
enabled auto-merge (squash)
April 20, 2026 17:52
shengliangxu
approved these changes
Apr 21, 2026
ajrasane
approved these changes
Apr 22, 2026
grzegorz-k-karch
pushed a commit
that referenced
this pull request
Apr 28, 2026
- Use latest containers for testing in CICD <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Bumped TensorRT-LLM Docker images to 1.3.0rc12 in example and GPU test workflows. * Updated PyTorch container image from 26.01 to 26.03 for GPU tests. * Captured uv lock upgrade output to a temp file, inlined it into PR bodies, and adjusted workflow heredoc/templating and step behavior. * **Documentation** * Clarified an inline comment and simplified a warning message for an ONNX quantization extension. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Documentation