Skip to content

Fix regex capture for Megatron KD PP layer renaming #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AAnoosheh merged 2 commits into from
Apr 27, 2026
Merged

Fix regex capture for Megatron KD PP layer renaming #1355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb73662
Make regex capture better
AAnoosheh Apr 27, 2026
c0312ef
Smarter string replacement
AAnoosheh Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modelopt/torch/distill/plugins/megatron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def setup_distillation_config(

def _adjust_layer_index_for_pp(submodule_name, model_cfg):
"""Adjust any sequence-based layer indices found in a submodule name for Pipeline Parallelism."""
match = re.search(r"(?<=\.)\d+(?=\.)", submodule_name)
match = re.search(r"(?<=\.)\d+(?=\.|$)", submodule_name)
if not match:
return submodule_name

Expand All @@ -172,7 +172,7 @@ def _adjust_layer_index_for_pp(submodule_name, model_cfg):
if new_layer_idx < 0:
raise ValueError(f"Layer {submodule_name} does not fall on final PP rank.")

new_submodule_name = submodule_name.replace(match.group(0), str(new_layer_idx))
new_submodule_name = submodule_name.replace(f".{match.group(0)}", f".{new_layer_idx}")
if parallel_state.get_tensor_and_context_parallel_rank() == 0:
logger.info(
f'Distillation: Renamed layer "{submodule_name}" on final PP rank to "{new_submodule_name}"'
Expand Down
Loading