launcher: gemma-4-E4B-it MTP — switch vLLM image to vllm-openai:gemma - #1736
launcher: gemma-4-E4B-it MTP — switch vLLM image to vllm-openai:gemma#1736ChenhanYu wants to merge 1 commit into
Conversation
The generic vllm-openai:v0.22.1 image fails Gemma 4 MTP engine startup with an assertion error. The Gemma-specific image (vllm-openai:gemma) ships the patches Gemma 4 MTP needs; same image was used successfully on the sister cell (OMNIML-5024 cell_t0_d3, branch pensieve-intern/OMNIML-5023/t0_d3). Surfaced 2026-06-15 on OMNIML-5025 cell_t0_d7 (intern-agent job 341631795): agent submitted with v0.22.1, task 0 failed at vLLM engine init, agent diff'd against sister branch and patched locally. This commit applies the same patch to main so the next cell to dispatch doesn't re-derive the workaround. Signed-off-by: Chenhan Yu <chenhany@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Slurm launcher configuration for the Gemma 4 E4B-it speculative decoding MTP benchmark is updated to use ChangesGemma 4 MTP vLLM container image update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
+ Coverage 77.10% 77.13% +0.03%
==========================================
Files 511 511
Lines 56260 56260
==========================================
+ Hits 43380 43397 +17
+ Misses 12880 12863 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Superseded by #1738 — the agent on OMNIML-5025 opened a PR with the same container fix plus the per-cell file the cell stage produces. Closing this in favor of the broader one. |
|
Authored on pensieve-intern agent dispatch for OMNIML-5025 (cell_t0_d7, sweep gemma-4-E4B-it_mtp_vllm_t0_d7). Two changes: 1. New per-cell file tools/launcher/common/specdec_bench/_cells/ gemma-4-E4B-it_mtp_vllm_t0_d7.yaml — sweep params for the t0_d7 cell of the gemma-4-E4B-it MTP/vLLM benchmark grid. 2. Switch the parent tools/launcher/examples/google/gemma-4-E4B-it/specdec_bench_mtp_vllm.yaml from container vllm/vllm-openai:v0.22.1 → vllm/vllm-openai:gemma. The generic v0.22.1 image fails Gemma 4 MTP engine startup with an assertion; the Gemma-specific image ships the patches MTP needs. Same image is what the sister cell (OMNIML-5024 cell_t0_d3) ran successfully on. Real run with this combination: experiment cicd_1781548540, AL_qualitative_overall=3.2945, AL_throughput_32k_overall=3.3803. Surfaced 2026-06-15 (intern-agent job 341631795). Supersedes #1736. Signed-off-by: Chenhan Yu <chenhany@nvidia.com> Co-Authored-By: pensieve-intern agent <noreply@nvidia.com> Signed-off-by: Chenhan Yu <chenhany@nvidia.com>
Switch container in tools/launcher/examples/google/gemma-4-E4B-it/ specdec_bench_mtp_vllm.yaml from vllm/vllm-openai:v0.22.1 → vllm/vllm-openai:gemma. The generic v0.22.1 image fails Gemma 4 MTP engine startup; the Gemma-specific image is what the sister cell (OMNIML-5024 cell_t0_d3) ran successfully on. Per PR #1564, this benchmark family does NOT use per-cell _cells/<sweep>.yaml files — cell-specific params are passed as pipeline.task_N.args+=[...] overrides at submit time, not committed to the repo. The parent yaml + the args-override CLI is the complete contract. Real run with this container: experiment cicd_1781548540, AL_qualitative_overall=3.2945, AL_throughput_32k_overall=3.3803. Surfaced 2026-06-15 (intern-agent job 341631795). Supersedes #1736. Signed-off-by: Chenhan Yu <chenhany@nvidia.com> Co-Authored-By: pensieve-intern agent <noreply@nvidia.com> Signed-off-by: Chenhan Yu <chenhany@nvidia.com>
What
Switch the gemma-4-E4B-it specdec_bench_mtp_vllm parent YAML from
vllm/vllm-openai:v0.22.1tovllm/vllm-openai:gemma(both task_0 and task_1).Why
v0.22.1fails Gemma 4 MTP engine startup with an assertion error. The Gemma-specific image (vllm-openai:gemma) ships the patches Gemma 4 MTP needs; same image was used successfully on the sister cell (OMNIML-5024 cell_t0_d3, branchpensieve-intern/OMNIML-5023/t0_d3).How surfaced
Diagnosed 2026-06-15 on OMNIML-5025 cell_t0_d7 (intern-agent job 341631795):
v0.22.1This PR applies the same patch to
mainso the next cell to dispatch doesn't re-derive the workaround.Doc-comment also updated
Replaces the misleading "
v0.22.1(and later)" claim with the actual image name + a footnote citing the failure surface.Summary by CodeRabbit