Skip to content

chore: stop tracking .claude/scheduled_tasks.lock - #1758

Merged
sychen52 merged 1 commit into
mainfrom
yeyu/rm-scheduled-tasks-lock
Jun 16, 2026
Merged

chore: stop tracking .claude/scheduled_tasks.lock#1758
sychen52 merged 1 commit into
mainfrom
yeyu/rm-scheduled-tasks-lock

Conversation

@yeyu-nvidia

@yeyu-nvidia yeyu-nvidia commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What

Remove .claude/scheduled_tasks.lock from version control and add a .gitignore rule so it is never committed again.

Why

This file is an ephemeral Claude Code scheduler lock — its contents are runtime process state (sessionId, pid, procStart, acquiredAt), not source. It was accidentally committed in #1623 and is currently tracked on main.

Reported by @sychen52 in review of #1623.

Changes

  • git rm --cached .claude/scheduled_tasks.lock
  • Add .claude/scheduled_tasks.lock to .gitignore

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated repository configuration to exclude internal runtime lock files from version control.

This is an ephemeral Claude Code scheduler lock file (sessionId/pid/
timestamps), accidentally committed in #1623. Remove it from tracking
and add a .gitignore rule so it is never committed again.

Reported by @sychen52 in review of #1623.

Signed-off-by: Ye Yu <yeyu@nvidia.com>
@yeyu-nvidia
yeyu-nvidia requested a review from a team as a code owner June 16, 2026 22:39
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8b1ad192-b285-48bc-afbb-ae560837f273

📥 Commits

Reviewing files that changed from the base of the PR and between 7f23d0f and 78402e0.

⛔ Files ignored due to path filters (1)
  • .claude/scheduled_tasks.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

.gitignore is updated to exclude .claude/scheduled_tasks.lock, annotated with a comment identifying it as ephemeral Claude Code runtime lock state.

Changes

Gitignore Rule for Claude Code Lock File

Layer / File(s) Summary
Ignore Claude Code lock file
.gitignore
Adds an ignore rule for .claude/scheduled_tasks.lock with a comment marking it as ephemeral runtime state.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding .claude/scheduled_tasks.lock to .gitignore to stop tracking it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed PR contains only .gitignore changes (removing .claude/scheduled_tasks.lock from tracking). No Python code or dependency changes present; security check for modelopt/examples code is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yeyu/rm-scheduled-tasks-lock

Comment @coderabbitai help to get the list of available commands and usage tips.

@yeyu-nvidia
yeyu-nvidia requested a review from sychen52 June 16, 2026 22:40
@yeyu-nvidia

Copy link
Copy Markdown
Contributor Author

@sychen52 this addresses your review comment on #1623 — could you approve when you get a chance? Small cleanup: just untracks the scheduler lock file and adds a .gitignore rule. Thanks!

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.44%. Comparing base (7f23d0f) to head (78402e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
- Coverage   58.45%   58.44%   -0.02%     
==========================================
  Files         510      510              
  Lines       56288    56288              
==========================================
- Hits        32901    32895       -6     
- Misses      23387    23393       +6     
Flag Coverage Δ
unit 54.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sychen52
sychen52 merged commit ba4340a into main Jun 16, 2026
36 checks passed
@sychen52
sychen52 deleted the yeyu/rm-scheduled-tasks-lock branch June 16, 2026 23:24
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-16 23:24 UTC

@kevalmorabia97 kevalmorabia97 added cherry-pick-0.45.0 cherry-pick-done Added by bot once PR is cherry-picked to the release branch labels Jun 23, 2026
kevalmorabia97 pushed a commit that referenced this pull request Jun 23, 2026
## What
Remove `.claude/scheduled_tasks.lock` from version control and add a
`.gitignore` rule so it is never committed again.

## Why
This file is an **ephemeral Claude Code scheduler lock** — its contents
are runtime process state (`sessionId`, `pid`, `procStart`,
`acquiredAt`), not source. It was accidentally committed in #1623 and is
currently tracked on `main`.

Reported by @sychen52 in [review of
#1623](#1623 (review)).

## Changes
- `git rm --cached .claude/scheduled_tasks.lock`
- Add `.claude/scheduled_tasks.lock` to `.gitignore`

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated repository configuration to exclude internal runtime lock
files from version control.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Ye Yu <yeyu@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-done Added by bot once PR is cherry-picked to the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants