i2c: tegra: check msg length in SMBUS block read (6.11 internal) #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SMBUS block read, do not continue to read if the message length passed from the device is '0' or greater than the maximum allowed bytes. Signed-off-by: Akhil R <akhilrajeev@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20250424053320.19211-1-akhilrajeev@nvidia.com Signed-off-by: Andi Shyti <andi.shyti@kernel.org> (cherry picked from commit 17ffd5154a03fcec9ce1ff4ff5e604235a91f985 linux-next) Signed-off-by: Carol L Soto <csoto@nvidia.com>
Collaborator
|
|
nvmochs
approved these changes
Apr 30, 2025
Collaborator
nvmochs
left a comment
nvmochs
left a comment
There was a problem hiding this comment.
Acked-by: Matthew R. Ochs <mochs@nvidia.com>
Collaborator
|
Merged, closing PR. |
jamieNguyenNVIDIA
pushed a commit
to jamieNguyenNVIDIA/NV-Kernels
that referenced
this pull request
Jan 13, 2026
- Update driver to be in-built kernel module. This will ensure driver is
installed in kernel and would not require any user intervention.
- Register the LFA driver as a platform driver corresponding to
'armhf000' device. The driver will be invoked when the device is
detected on a platform.
- Add functionality to register LFA interrupt in the driver probe().
This LFA IRQ number will be retrived from the LFA device node.
- On IRQ, driver will query FW component details and trigger activation
of capable and pending FW component. The driver will loop to update FW
component details after every successful FW component activation.
- Mutex synchronization is implemented to avoid concurrent LFA updates
through interrupt and sysfs interfaces.
Device node snippet from LFA spec[1]:
fwu0 {
compatible = "arm,armhf000";
memory-region = <&fwu_payload>;
interrupt-parent = <&ic>;
interrupts = <0 100 1>; // SPI, Interrupt NVIDIA#100, Edge Rising
};
[1] https://developer.arm.com/documentation/den0147/latest/
Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com>
(backported from https://lore.kernel.org/linux-arm-kernel/20251208221319.1524888-1-vvidwans@nvidia.com/)
Signed-off-by: Jamie Nguyen <jamien@nvidia.com>
jamieNguyenNVIDIA
pushed a commit
to jamieNguyenNVIDIA/NV-Kernels
that referenced
this pull request
Jan 13, 2026
- Update driver to be in-built kernel module. This will ensure driver is
installed in kernel and would not require any user intervention.
- Register the LFA driver as a platform driver corresponding to
'armhf000' device. The driver will be invoked when the device is
detected on a platform.
- Add functionality to register LFA interrupt in the driver probe().
This LFA IRQ number will be retrived from the LFA device node.
- On IRQ, driver will query FW component details and trigger activation
of capable and pending FW component. The driver will loop to update FW
component details after every successful FW component activation.
- Mutex synchronization is implemented to avoid concurrent LFA updates
through interrupt and sysfs interfaces.
Device node snippet from LFA spec[1]:
fwu0 {
compatible = "arm,armhf000";
memory-region = <&fwu_payload>;
interrupt-parent = <&ic>;
interrupts = <0 100 1>; // SPI, Interrupt NVIDIA#100, Edge Rising
};
[1] https://developer.arm.com/documentation/den0147/latest/
Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com>
(backported from https://lore.kernel.org/linux-arm-kernel/20251208221319.1524888-1-vvidwans@nvidia.com/)
[jamien: remove unnecessary __init from lfa_probe to avoid warning]
Signed-off-by: Jamie Nguyen <jamien@nvidia.com>
jamieNguyenNVIDIA
pushed a commit
to jamieNguyenNVIDIA/NV-Kernels
that referenced
this pull request
Jan 13, 2026
- Update driver to be in-built kernel module. This will ensure driver is
installed in kernel and would not require any user intervention.
- Register the LFA driver as a platform driver corresponding to
'armhf000' device. The driver will be invoked when the device is
detected on a platform.
- Add functionality to register LFA interrupt in the driver probe().
This LFA IRQ number will be retrived from the LFA device node.
- On IRQ, driver will query FW component details and trigger activation
of capable and pending FW component. The driver will loop to update FW
component details after every successful FW component activation.
- Mutex synchronization is implemented to avoid concurrent LFA updates
through interrupt and sysfs interfaces.
Device node snippet from LFA spec[1]:
fwu0 {
compatible = "arm,armhf000";
memory-region = <&fwu_payload>;
interrupt-parent = <&ic>;
interrupts = <0 100 1>; // SPI, Interrupt NVIDIA#100, Edge Rising
};
[1] https://developer.arm.com/documentation/den0147/latest/
Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com>
(backported from https://lore.kernel.org/linux-arm-kernel/20251208221319.1524888-1-vvidwans@nvidia.com/)
[jamien: remove unnecessary __init from lfa_probe to avoid warning]
Signed-off-by: Jamie Nguyen <jamien@nvidia.com>
nvidia-bfigg
pushed a commit
that referenced
this pull request
Jan 14, 2026
BugLink: https://bugs.launchpad.net/bugs/2138342 - Update driver to be in-built kernel module. This will ensure driver is installed in kernel and would not require any user intervention. - Register the LFA driver as a platform driver corresponding to 'armhf000' device. The driver will be invoked when the device is detected on a platform. - Add functionality to register LFA interrupt in the driver probe(). This LFA IRQ number will be retrived from the LFA device node. - On IRQ, driver will query FW component details and trigger activation of capable and pending FW component. The driver will loop to update FW component details after every successful FW component activation. - Mutex synchronization is implemented to avoid concurrent LFA updates through interrupt and sysfs interfaces. Device node snippet from LFA spec[1]: fwu0 { compatible = "arm,armhf000"; memory-region = <&fwu_payload>; interrupt-parent = <&ic>; interrupts = <0 100 1>; // SPI, Interrupt #100, Edge Rising }; [1] https://developer.arm.com/documentation/den0147/latest/ Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com> (backported from https://lore.kernel.org/linux-arm-kernel/20251208221319.1524888-1-vvidwans@nvidia.com/) [jamien: remove unnecessary __init from lfa_probe to avoid warning] Signed-off-by: Jamie Nguyen <jamien@nvidia.com> Acked-by: Matthew R. Ochs <mochs@nvidia.com> Acked-by: Carol L Soto <csoto@nvidia.com>
jamieNguyenNVIDIA
pushed a commit
that referenced
this pull request
Jan 14, 2026
- Update driver to be in-built kernel module. This will ensure driver is
installed in kernel and would not require any user intervention.
- Register the LFA driver as a platform driver corresponding to
'armhf000' device. The driver will be invoked when the device is
detected on a platform.
- Add functionality to register LFA interrupt in the driver probe().
This LFA IRQ number will be retrived from the LFA device node.
- On IRQ, driver will query FW component details and trigger activation
of capable and pending FW component. The driver will loop to update FW
component details after every successful FW component activation.
- Mutex synchronization is implemented to avoid concurrent LFA updates
through interrupt and sysfs interfaces.
Device node snippet from LFA spec[1]:
fwu0 {
compatible = "arm,armhf000";
memory-region = <&fwu_payload>;
interrupt-parent = <&ic>;
interrupts = <0 100 1>; // SPI, Interrupt #100, Edge Rising
};
[1] https://developer.arm.com/documentation/den0147/latest/
Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com>
(backported from https://lore.kernel.org/linux-arm-kernel/20251208221319.1524888-1-vvidwans@nvidia.com/)
[jamien: remove unnecessary __init from lfa_probe to avoid warning]
Signed-off-by: Jamie Nguyen <jamien@nvidia.com>
Acked-by: Matthew R. Ochs <mochs@nvidia.com>
Acked-by: Carol L Soto <csoto@nvidia.com>
Signed-off-by: Jamie Nguyen <jamien@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SMBUS block read, do not continue to read if the message length passed from the device is '0' or greater than the maximum allowed bytes.
Acked-by: Thierry Reding treding@nvidia.com
Link: https://lore.kernel.org/r/20250424053320.19211-1-akhilrajeev@nvidia.com
(cherry picked from commit 17ffd5154a03fcec9ce1ff4ff5e604235a91f985 linux-next)
Launchpad:https://bugs.launchpad.net/ubuntu/+source/linux-nvidia/+bug/2109750
Nvbug: https://nvbugspro.nvidia.com/bug/5115227