Merged
Conversation
Contributor
Greptile SummaryThis PR fixes a CI integration test failure caused by the introduction of
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant CI as CI Test Runner
participant Driver as NVFTestDriver
participant AdminAPI as FLAdminAPI
participant Site as site-1
CI->>Driver: run_event_sequence(shell_commands.yml)
Driver->>AdminAPI: ls_target("site-1") [as admin@a.org]
AdminAPI->>Site: ls request
Site-->>AdminAPI: audit.log daemon_pid.fl local log.json log.txt log_error.txt pid.fl readme.txt signature.json startup transfer
AdminAPI-->>Driver: SUCCESS response
Driver->>Driver: assert response == expected data (includes signature.json)
Driver->>AdminAPI: ls_target("site-1") [as admin@b.org]
AdminAPI-->>Driver: ERROR_AUTHORIZATION
Driver->>Driver: assert PermissionError message
Driver->>AdminAPI: ls_target("site-1") [super admin]
AdminAPI->>Site: ls request
Site-->>AdminAPI: audit.log ... signature.json startup transfer
AdminAPI-->>Driver: SUCCESS response
Driver->>Driver: assert response == expected data (includes signature.json)
Last reviewed commit: 249d734 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the authorization integration test configuration to align expected ls output with the startup-kit signing changes introduced in #4301 (signature file now generated at kit root).
Changes:
- Update expected
shell_commands ls site-1output to includesignature.jsonin the directory listing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pcnudde
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes in #4301 we will generate a signature.json that CI should expect.
Description
Fix ci
Types of changes
./runtest.sh.