ci(publishing): fix publishing commands by willkill07 · Pull Request #11 · NVIDIA/NeMo-Relay

willkill07 · 2026-04-29T01:10:38Z

Overview

Add README.md to all crates
Bump python publishing action
Explicitly use relative directory for NPM
I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.

Where should the reviewer start?

ci.yaml for the bulk changes
Cursory glance of README.md for each crate

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Closes [Bug]: CI Publishing commands fail #10

Summary by CodeRabbit

Documentation
- Added README documentation for FFI, Node.js, and WebAssembly binding crates, describing their purpose and directing users to relevant resources.
Chores
- Updated CI/CD publishing workflows to refine package distribution across platforms and registries.

Signed-off-by: Will Killian <wkillian@nvidia.com>

coderabbitai · 2026-04-29T01:10:49Z

Walkthrough

Fixes CI publishing commands for Rust, PyPI, and npm by constraining Rust workspace publication scope, updating PyPI action reference, and correcting npm package path. Adds README documentation for FFI, Node.js, and WebAssembly binding crates.

Changes

Cohort / File(s)	Summary
CI Publishing Fixes `.github/workflows/ci.yaml`	Restricts Rust publication to `nemo-flow`, `nemo-flow-adaptive`, and `nemo-flow-ffi` crates; updates `pypa/gh-action-pypi-publish` to `v1.14.0`; adjusts npm publish path to `./combined/package`.
Crate Documentation `crates/ffi/README.md`, `crates/node/README.md`, `crates/wasm/README.md`	New README files documenting the C ABI layer (FFI), Rust native extension for Node.js (Node), and WebAssembly binding (WASM) crates, including setup instructions and links to project documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title follows Conventional Commits format with type(scope) prefix and concise imperative summary, under 72 characters.
Description check	✅ Passed	Description includes overview of changes, reviewer starting points, and related issues, matching template structure mostly completely.
Linked Issues check	✅ Passed	Changes directly address issue `#10` failures: ci.yaml fixes publishing commands for Crates.io, PyPI, and NPM; READMEs document crate purposes.
Out of Scope Changes check	✅ Passed	All changes are scoped to publishing fixes and crate documentation directly supporting the publishing issue resolution.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 134-141: Centralize the repeated cargo publish package list by
extracting "cargo publish -p nemo-flow -p nemo-flow-adaptive -p nemo-flow-ffi
--no-verify" into a single reusable value (e.g., a workflow/env variable like
PACKAGES or a single run step) and reference that value from both the trusted
and token publishing steps (the step currently labelled "Publish to crates.io
with registry token" and its counterpart). Update the steps to call the shared
variable (e.g., use ${{ env.PACKAGES }} or a single publish job) and keep the
CARGO_REGISTRY_TOKEN usage unchanged for the token path so the command list
cannot drift between the two branches.

In `@crates/node/README.md`:
- Around line 11-13: Replace the plain text occurrence of napi-rs with inline
code formatting; locate the sentence containing "napi-rs to expose NeMo Flow
runtime scopes..." and change the package name token napi-rs to inline code
(e.g., `napi-rs`) so the README follows the guideline that package names are
shown in monospace.

In `@crates/wasm/README.md`:
- Around line 10-11: The sentence mentioning wasm-bindgen should format the
dependency/tool name as inline code; update the README text that currently reads
"wasm-bindgen" to use inline code formatting for the token `wasm-bindgen` so it
appears monospace and consistent with other code/command mentions in the docs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7fe36b2d-0982-4840-9d66-63363805b99c

📥 Commits

Reviewing files that changed from the base of the PR and between 79c6082 and 294057e.

📒 Files selected for processing (4)

.github/workflows/ci.yaml
crates/ffi/README.md
crates/node/README.md
crates/wasm/README.md

📜 Review details

🧰 Additional context used

📓 Path-based instructions (21)

**/*.{rs,py,js,ts,tsx,go,md,sh,toml,yaml,yml,json,lock,txt}

📄 CodeRabbit inference engine (AGENTS.md)

Keep SPDX headers on source, docs, scripts, and configuration files. The project uses Apache-2.0 license.

Files:

crates/ffi/README.md
crates/wasm/README.md
crates/node/README.md

**/*.{html,md}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Include SPDX license header in all HTML and Markdown files using comment syntax

Files:

crates/ffi/README.md
crates/wasm/README.md
crates/node/README.md

**/{README.md,*.md,docs/**/*.md,examples/**/*,scripts/**/*}