refactor!: remove WebAssembly binding#339
Merged
willkill07 merged 1 commit intoJul 1, 2026
Merged
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
WalkthroughThis PR removes the entire WebAssembly (crates/wasm) crate, its wrappers, tests, and packaging pipeline; strips target_arch="wasm32" conditional compilation from core runtime, observability, and plugin code; and updates CI workflows, build tooling, documentation, and agent skill files to drop WebAssembly as a supported binding surface. ChangesWebAssembly Removal
Estimated code review effort: 4 (Complex) | ~75 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:XXL
willkill07
changed the title
License DiffCompared against Lockfile license changesLockfile License ChangesRustAdded
Removed
Updated/Changed
NodeAdded
Removed
Updated/Changed
|
willkill07
marked this pull request as ready for review
July 1, 2026 04:24
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@RELEASING.md`:
- Around line 277-283: Update the release flow description in RELEASING.md so
the collector is described as downloading npm package artifacts rather than a
single npm artifact. Keep the wording aligned with the GitHub publish step and
the Artifactory jobs by referencing the existing release flow terms in the
collector and mirror sections, so it clearly covers both nemo-relay-node and
nemo-relay-openclaw.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 3f137e77-54c4-45d6-ad05-b298be8ce37c
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (159)
.agents/skills/add-binding-feature/SKILL.md.agents/skills/maintain-observability/SKILL.md.agents/skills/maintain-optimizer/SKILL.md.agents/skills/maintain-packaging/SKILL.md.agents/skills/rename-surfaces/SKILL.md.agents/skills/test-wasm-binding/SKILL.md.agents/skills/update-project-version/SKILL.md.agents/skills/validate-change/SKILL.md.coderabbit.yaml.github/ISSUE_TEMPLATE/01-bug.yml.github/ISSUE_TEMPLATE/02-enhancement.yml.github/actions/load-ci-tool-versions/action.yml.github/ci-path-filters.yml.github/ci-tool-versions.env.github/workflows/ci.yaml.github/workflows/ci_changes.yml.github/workflows/ci_wasm.yml.gitignore.gitlab-ci.yml.pre-commit-config.yamlAGENTS.mdATTRIBUTIONS-Node.mdATTRIBUTIONS-Rust.mdCONTRIBUTING.mdCargo.tomlREADME.mdRELEASING.mdcodecov.ymlcrates/adaptive/README.mdcrates/cli/README.mdcrates/cli/src/doctor.rscrates/core/Cargo.tomlcrates/core/README.mdcrates/core/src/api/runtime/subscriber_dispatcher.rscrates/core/src/observability/atof.rscrates/core/src/observability/openinference.rscrates/core/src/observability/otel.rscrates/core/src/observability/plugin_component.rscrates/core/src/plugin/dynamic.rscrates/core/src/plugins/nemo_guardrails/component.rscrates/core/src/plugins/nemo_guardrails/remote.rscrates/core/src/shared_runtime.rscrates/core/tests/integration/native_plugin_tests.rscrates/core/tests/integration/subscriber_dispatcher_tests.rscrates/core/tests/unit/observability/atof_tests.rscrates/core/tests/unit/observability/openinference_tests.rscrates/core/tests/unit/observability/otel_tests.rscrates/core/tests/unit/observability/plugin_component_tests.rscrates/core/tests/unit/plugin_tests.rscrates/ffi/README.mdcrates/node/README.mdcrates/node/package.jsoncrates/node/src/api/mod.rscrates/python/README.mdcrates/wasm/Cargo.tomlcrates/wasm/LICENSEcrates/wasm/README.mdcrates/wasm/package.jsoncrates/wasm/scripts/build_pkg.mjscrates/wasm/scripts/normalize_coverage.mjscrates/wasm/scripts/prepare_pkg.mjscrates/wasm/src/api/mod.rscrates/wasm/src/callable.rscrates/wasm/src/convert.rscrates/wasm/src/lib.rscrates/wasm/src/stream.rscrates/wasm/src/types/mod.rscrates/wasm/tests-js/adaptive_tests.mjscrates/wasm/tests-js/atif_tests.mjscrates/wasm/tests-js/callback_error_tests.mjscrates/wasm/tests-js/deregister_tests.mjscrates/wasm/tests-js/index_loader_tests.mjscrates/wasm/tests-js/llm_tests.mjscrates/wasm/tests-js/model_pricing_tests.mjscrates/wasm/tests-js/observability_tests.mjscrates/wasm/tests-js/openinference_tests.mjscrates/wasm/tests-js/otel_tests.mjscrates/wasm/tests-js/pii_redaction_tests.mjscrates/wasm/tests-js/plugin_tests.mjscrates/wasm/tests-js/scope_local_tests.mjscrates/wasm/tests-js/scope_tests.mjscrates/wasm/tests-js/test_support.mjscrates/wasm/tests-js/timestamp_tests.mjscrates/wasm/tests-js/tools_tests.mjscrates/wasm/tests-js/typed_tests.mjscrates/wasm/tests-js/types_tests.mjscrates/wasm/tests/coverage/callable_tests.rscrates/wasm/tests/coverage/types_tests.rscrates/wasm/tests/integration/adaptive_tests.rscrates/wasm/tests/integration/codec_tests.rscrates/wasm/tests/integration/context_tests.rscrates/wasm/tests/integration/deregister_tests.rscrates/wasm/tests/integration/llm_tests.rscrates/wasm/tests/integration/scope_local_tests.rscrates/wasm/tests/integration/scope_tests.rscrates/wasm/tests/integration/tools_tests.rscrates/wasm/tests/unit/api_tests.rscrates/wasm/tests/unit/convert_tests.rscrates/wasm/tests/unit/stream_tests.rscrates/wasm/wrappers/esm/adaptive.d.tscrates/wasm/wrappers/esm/adaptive.jscrates/wasm/wrappers/esm/index.jscrates/wasm/wrappers/esm/model_pricing.d.tscrates/wasm/wrappers/esm/model_pricing.jscrates/wasm/wrappers/esm/observability.d.tscrates/wasm/wrappers/esm/observability.jscrates/wasm/wrappers/esm/pii_redaction.d.tscrates/wasm/wrappers/esm/pii_redaction.jscrates/wasm/wrappers/esm/plugin.d.tscrates/wasm/wrappers/esm/plugin.jscrates/wasm/wrappers/esm/typed.d.tscrates/wasm/wrappers/esm/typed.jscrates/wasm/wrappers/nodejs/adaptive.jscrates/wasm/wrappers/nodejs/index.jscrates/wasm/wrappers/nodejs/model_pricing.jscrates/wasm/wrappers/nodejs/observability.jscrates/wasm/wrappers/nodejs/pii_redaction.jscrates/wasm/wrappers/nodejs/plugin.jscrates/wasm/wrappers/nodejs/typed.jsdocs/about-nemo-relay/concepts/events.mdxdocs/about-nemo-relay/concepts/subscribers.mdxdocs/about-nemo-relay/ecosystem.mdxdocs/about-nemo-relay/overview.mdxdocs/about-nemo-relay/release-notes/highlights.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/about-nemo-relay/release-notes/known-issues.mdxdocs/build-plugins/plugin-configuration-files.mdxdocs/contribute/development-setup.mdxdocs/contribute/runtime-contract-docs.mdxdocs/contribute/testing-and-docs.mdxdocs/getting-started/prerequisites.mdxdocs/instrument-applications/code-examples.mdxdocs/observability-plugin/atif.mdxdocs/resources/glossary.mdxdocs/resources/support-and-faqs.mdxdocs/resources/troubleshooting/index.mdxgo/nemo_relay/README.mdjustfilepackage.jsonpython/nemo_relay/README.mdscripts/docs/fern_cleanup.pyscripts/lint/check_copyright.pyscripts/lint/check_public_docstrings.mjsskills/README.mdskills/nemo-relay-build-plugin/SKILL.mdskills/nemo-relay-debug-runtime-integration/SKILL.mdskills/nemo-relay-export-openinference/SKILL.mdskills/nemo-relay-export-openinference/evals/evals.jsonskills/nemo-relay-export-otel/SKILL.mdskills/nemo-relay-export-otel/evals/evals.jsonskills/nemo-relay-instrument-calls/SKILL.mdskills/nemo-relay-migrate-from-flow/SKILL.mdskills/nemo-relay-setup-observability/SKILL.mdskills/nemo-relay-start/SKILL.mdskills/nemo-relay-tune-adaptive-config/SKILL.mdskills/nemo-relay-tune-performance/SKILL.mdskills/nemo-relay-typed-wrappers-codecs/SKILL.mdskills/nemo-relay-use-context-isolation/SKILL.mdsonar-project.properties
💤 Files with no reviewable changes (99)
- crates/wasm/wrappers/nodejs/typed.js
- .agents/skills/test-wasm-binding/SKILL.md
- crates/wasm/LICENSE
- crates/wasm/src/types/mod.rs
- crates/wasm/tests/coverage/callable_tests.rs
- skills/nemo-relay-instrument-calls/SKILL.md
- crates/wasm/tests-js/pii_redaction_tests.mjs
- crates/wasm/tests/integration/scope_local_tests.rs
- crates/wasm/tests/unit/convert_tests.rs
- crates/node/README.md
- go/nemo_relay/README.md
- crates/wasm/tests/integration/tools_tests.rs
- crates/wasm/tests-js/otel_tests.mjs
- crates/wasm/wrappers/nodejs/pii_redaction.js
- crates/wasm/tests/coverage/types_tests.rs
- crates/wasm/tests-js/timestamp_tests.mjs
- crates/wasm/tests/integration/adaptive_tests.rs
- crates/wasm/tests/integration/context_tests.rs
- crates/wasm/tests/unit/stream_tests.rs
- crates/wasm/tests/integration/codec_tests.rs
- crates/wasm/wrappers/nodejs/observability.js
- crates/ffi/README.md
- crates/wasm/wrappers/esm/observability.d.ts
- crates/wasm/tests-js/index_loader_tests.mjs
- crates/wasm/tests-js/atif_tests.mjs
- skills/nemo-relay-use-context-isolation/SKILL.md
- crates/wasm/wrappers/nodejs/plugin.js
- crates/wasm/README.md
- crates/core/tests/integration/subscriber_dispatcher_tests.rs
- crates/wasm/Cargo.toml
- crates/wasm/tests-js/types_tests.mjs
- crates/wasm/scripts/normalize_coverage.mjs
- crates/wasm/tests-js/deregister_tests.mjs
- python/nemo_relay/README.md
- crates/wasm/tests-js/tools_tests.mjs
- crates/python/README.md
- crates/wasm/wrappers/esm/typed.d.ts
- crates/node/package.json
- crates/wasm/tests-js/plugin_tests.mjs
- crates/wasm/wrappers/esm/plugin.js
- crates/wasm/tests-js/scope_tests.mjs
- crates/wasm/wrappers/esm/pii_redaction.d.ts
- crates/wasm/wrappers/esm/typed.js
- crates/wasm/wrappers/esm/index.js
- crates/wasm/tests-js/typed_tests.mjs
- crates/wasm/tests-js/llm_tests.mjs
- crates/wasm/scripts/build_pkg.mjs
- crates/wasm/tests-js/test_support.mjs
- crates/wasm/wrappers/nodejs/index.js
- crates/wasm/tests-js/observability_tests.mjs
- crates/wasm/tests/integration/scope_tests.rs
- .gitignore
- crates/wasm/wrappers/esm/model_pricing.d.ts
- crates/wasm/wrappers/esm/plugin.d.ts
- crates/wasm/tests-js/adaptive_tests.mjs
- crates/wasm/tests/integration/llm_tests.rs
- crates/wasm/tests/unit/api_tests.rs
- .github/ISSUE_TEMPLATE/02-enhancement.yml
- .github/workflows/ci_wasm.yml
- package.json
- crates/wasm/src/stream.rs
- sonar-project.properties
- crates/wasm/wrappers/esm/adaptive.js
- crates/wasm/tests-js/scope_local_tests.mjs
- crates/wasm/wrappers/esm/model_pricing.js
- crates/wasm/package.json
- crates/core/README.md
- crates/wasm/wrappers/esm/observability.js
- crates/wasm/tests-js/callback_error_tests.mjs
- .github/ISSUE_TEMPLATE/01-bug.yml
- crates/wasm/tests-js/openinference_tests.mjs
- crates/adaptive/README.md
- crates/wasm/src/lib.rs
- crates/wasm/scripts/prepare_pkg.mjs
- crates/wasm/src/convert.rs
- ATTRIBUTIONS-Node.md
- .github/ci-tool-versions.env
- .agents/skills/maintain-packaging/SKILL.md
- .github/ci-path-filters.yml
- crates/wasm/wrappers/nodejs/adaptive.js
- crates/wasm/wrappers/esm/pii_redaction.js
- crates/cli/README.md
- scripts/lint/check_copyright.py
- skills/nemo-relay-debug-runtime-integration/SKILL.md
- .agents/skills/rename-surfaces/SKILL.md
- crates/wasm/tests/integration/deregister_tests.rs
- crates/wasm/wrappers/esm/adaptive.d.ts
- .github/actions/load-ci-tool-versions/action.yml
- crates/core/tests/unit/observability/otel_tests.rs
- crates/wasm/src/callable.rs
- docs/contribute/testing-and-docs.mdx
- .github/workflows/ci_changes.yml
- crates/core/tests/unit/plugin_tests.rs
- crates/wasm/tests-js/model_pricing_tests.mjs
- crates/core/tests/integration/native_plugin_tests.rs
- .github/workflows/ci.yaml
- crates/core/src/plugins/nemo_guardrails/remote.rs
- crates/core/tests/unit/observability/openinference_tests.rs
- crates/wasm/wrappers/nodejs/model_pricing.js
Contributor
|
Note: Node.js JavaScript/TypeScript remains supported through nemo-relay-node |
bbednarski9
reviewed
Jul 1, 2026
bbednarski9
reviewed
Jul 1, 2026
bbednarski9
reviewed
Jul 1, 2026
bbednarski9
approved these changes
Jul 1, 2026
Salonijain27
approved these changes
Jul 1, 2026
Salonijain27
left a comment
Salonijain27
left a comment
Collaborator
There was a problem hiding this comment.
Approved from a dependency point of view
|
FYI: NAPI-RS binding can be compiled into WebAssembly too, see https://napi.rs/blog/announce-v3#webassembly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove the experimental WebAssembly binding and every first-party repository surface that builds, tests, packages, publishes, documents, or maintains it.
Details
crates/wasmbinding, wrappers, tests, package metadata, and dedicated agent skill.This is a breaking change for consumers of the experimental
nemo-relay-wasmpackage: the package is no longer built, published, or supported by this repository.Validation:
just test-rustjust test-nodejust test-gocargo check --workspace --all-targetscargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningsjust docsjust docs-linkcheckuv run pre-commit run --all-filesuv run pytest --ignore=python/tests/integrations -k 'not test_unlink_unix_socket_refuses_an_active_socket'(487 passed, 1 deselected)The complete
just test-pythonrun stalled in the unchanged macOS Unix-socket liveness testtest_unlink_unix_socket_refuses_an_active_socketafter 101 tests passed. The remaining Python suite passed when that test was deselected.Where should the reviewer start?
Start with
Cargo.toml,justfile, and.github/workflows/ci.yamlfor the removed build surface, then reviewcrates/core/Cargo.tomland the core runtime modules for removal of target-specific branches.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Bug Fixes
Documentation
Chores