feat(logging): add configurable operational logging by ericevans-nv · Pull Request #413 · NVIDIA/NeMo-Relay

ericevans-nv · 2026-07-13T22:26:51Z

Overview

Add configurable, process-wide operational logging backed by the log facade and spdlog-rs. Operational commands initialize logging during top-level dispatch, before command execution. nemo-relay config and nemo-relay plugins edit intentionally skip initialization so invalid logging configuration cannot prevent users from repairing it.

This PR establishes the logging configuration and runtime. Broader production operational event call sites will be added separately.

I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

Add core-owned LoggingConfig and LoggingRuntime APIs shared by CLI and library integrations.
Support built-in defaults, normal config.toml discovery, environment configuration, explicit absolute TOML paths, and direct CLI settings. CLI sources take precedence over environment configuration, which takes precedence over discovered file configuration and defaults.
Add an always-on stderr sink for initialized operational commands and optional asynchronous JSONL or human-readable file sinks.
Bound asynchronous file queues, reject duplicate resolved sink paths, and drain pending file records during shutdown.
Attach one root Relay ID to operational records for process-level correlation.
Keep logging output on stderr or configured files; operational logging does not write to stdout.
Keep logging configuration under [logging] in config.toml. A separate interactive logging editor is outside this PR.
Documentation for the configuration surface is tracked in docs(cli): document operational process logging config #419.
Add focused core and CLI coverage for parsing, validation, formatting, sink behavior, configuration precedence, initialization policy, and shutdown flushing.
Regenerate ATTRIBUTIONS-Rust.md for the new Rust dependencies.

Where should the reviewer start?

crates/core/src/logging/ for configuration types, runtime ownership, formatting, sinks, and shutdown behavior
crates/cli/src/commands/logging.rs and crates/cli/src/commands/mod.rs for configuration-source selection and early command initialization
crates/cli/src/configuration/logging.rs for normal Relay TOML integration
crates/core/tests/coverage/logging_tests.rs and crates/cli/tests/coverage/shared/config_tests.rs for runtime and configuration guarantees
crates/cli/tests/coverage/commands/main_tests.rs for CLI precedence and command policy

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Closes: RELAY-451

Summary by CodeRabbit

New Features
- Added configurable operational logging with human-readable or JSONL output.
- Added stderr and asynchronous file sinks with per-sink level/format, queue limits, and periodic flushing.
- Introduced logging configuration via CLI options, environment variables, and TOML (including scoped application).
- Logging now initializes automatically for applicable CLI commands, while configuration/editor commands can bypass it.
Bug Fixes
- Strengthened validation for configuration values and file sink destination handling (including duplicates and invalid paths).
Tests
- Added extensive logging coverage for config loading, formatter output, sink runtime behavior, shutdown behavior, and CLI precedence/policy.
Chores
- Regenerated dependency attribution and license metadata.

Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>

…ent-relay-logging Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>

coderabbitai · 2026-07-13T22:27:14Z

Walkthrough

Adds configurable operational logging with human and JSONL output, asynchronous file sinks, runtime lifecycle management, CLI and TOML/environment configuration, validation tests, and refreshed Rust dependency attribution records.

Changes

Operational logging

Layer / File(s)	Summary
Logging configuration and public types `crates/core/src/logging/`, `crates/core/src/lib.rs`, `crates/core/Cargo.toml`, `crates/cli/src/configuration/`	Adds logging types, parsing, environment/TOML loading, file-sink validation, queue limits, and resolved configuration propagation.
Logger assembly and runtime lifecycle `crates/core/src/logging/format.rs`, `crates/core/src/logging/sink.rs`, `crates/core/src/logging/mod.rs`	Adds human and JSONL formatting, stderr and asynchronous file sinks, duplicate-path detection, queue-drop reporting, proxy installation, and shutdown flushing.
CLI lifecycle integration `crates/cli/src/commands/*`	Adds logging options, source precedence, dispatch initialization, runtime retention, and bypass rules for configuration-editing commands.
Logging behavior coverage `crates/core/tests/coverage/`, `crates/cli/tests/coverage/`	Tests configuration, formatting, filtering, fan-out, path and queue validation, flushing, shutdown, proxy lifecycle, CLI policies, and launcher behavior.
Dependency attribution refresh `ATTRIBUTIONS-Rust.md`	Regenerates Rust crate metadata, license references, SPDX links, and embedded license text.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CLI
  participant LoggingArgs
  participant LoggingRuntime
  participant build_logger
  participant AsyncFileSink
  CLI->>LoggingArgs: resolve CLI, environment, or TOML settings
  LoggingArgs->>LoggingRuntime: configure LoggingConfig
  LoggingRuntime->>build_logger: build logger and sinks
  build_logger->>AsyncFileSink: create bounded asynchronous file sink
  LoggingRuntime-->>CLI: retain LoggingRuntime during dispatch
  CLI->>LoggingRuntime: drop or shutdown
  LoggingRuntime->>AsyncFileSink: flush queued records

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows Conventional Commits and accurately summarizes the logging feature.
Description check	✅ Passed	The description follows the template well and includes all required sections with substantive content.
Docstring Coverage	✅ Passed	Docstring coverage is 91.89% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-13T22:32:03Z

Fern docs preview: https://nvidia-preview-pull-request-413.docs.buildwithfern.com/nemo/relay (https://nvidia-preview-pull-request-413.docs.buildwithfern.com/nemo/relay)

github-actions · 2026-07-13T22:46:07Z

License Diff

Compared against origin/main.

Lockfile license changes

Lockfile License Changes

Rust

Added

atomic 0.6.1 (Apache-2.0)
bytemuck 1.25.1 (Apache-2.0)
bytemuck_derive 1.11.0 (Apache-2.0)
crossbeam 0.8.4 (Apache-2.0)
crossbeam-channel 0.5.16 (Apache-2.0)
crossbeam-deque 0.8.7 (Apache-2.0)
crossbeam-epoch 0.9.20 (Apache-2.0)
crossbeam-queue 0.3.13 (Apache-2.0)
env_filter 0.1.4 (Apache-2.0)
erased-serde 0.4.10 (MIT OR Apache-2.0)
nom 8.0.0 (MIT)
rustc_version 0.4.1 (Apache-2.0)
serde_buf 0.1.2 (Apache-2.0 OR MIT)
serde_fmt 1.1.0 (Apache-2.0 OR MIT)
spdlog-internal 0.2.1 (Apache-2.0)
spdlog-macros 0.3.1 (Apache-2.0)
spdlog-rs 0.5.3 (Apache-2.0)
sval 2.20.0 (Apache-2.0 OR MIT)
sval_buffer 2.20.0 (Apache-2.0 OR MIT)
sval_dynamic 2.20.0 (Apache-2.0 OR MIT)
sval_fmt 2.20.0 (Apache-2.0 OR MIT)
sval_json 2.20.0 (Apache-2.0 OR MIT)
sval_nested 2.20.0 (Apache-2.0 OR MIT)
sval_ref 2.20.0 (Apache-2.0 OR MIT)
sval_serde 2.20.0 (Apache-2.0 OR MIT)
typeid 1.0.3 (MIT OR Apache-2.0)
value-bag 1.13.0 (Apache-2.0)
value-bag-serde1 1.13.0 (Apache-2.0 OR MIT)
value-bag-sval2 1.13.0 (Apache-2.0 OR MIT)

Removed

None

Updated/Changed

None

Node

Added

None

Removed

None

Updated/Changed

None

Python

Added

None

Removed

None

Updated/Changed

None

Status output

[license-diff] selected languages: rust, node, python
[license-diff] generating current inventory
[license-diff] current: generating Rust inventory
[license-diff] current: Rust inventory complete (421 packages)
[license-diff] current: generating Node inventory
[license-diff] current: Node inventory complete (363 packages)
[license-diff] current: generating Python inventory
[license-diff] current: Python inventory complete (105 packages)
[license-diff] current inventory complete
[license-diff] checking out base ref origin/main into a temporary worktree
[license-diff] base: generating Rust inventory
[license-diff] base: Rust inventory complete (392 packages)
[license-diff] base: generating Node inventory
[license-diff] base: Node inventory complete (363 packages)
[license-diff] base: generating Python inventory
[license-diff] base: Python inventory complete (105 packages)
[license-diff] base inventory complete
[license-diff] removing temporary base worktree
[license-diff] comparing inventories
[license-diff] rendering Markdown output
[license-diff] done

Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>

…ay-logging Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>

willkill07

Logging should be part of core, not just the CLI.

I also don't understand why/how nemo_relay.h has been changed.

Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>

ericevans-nv · 2026-07-15T22:25:38Z

I addressed the open configuration and initialization items from the latest review:

Logging now initializes during top-level dispatch for operational commands, including hook forwarding, MCP, and wrapped execution. Only config and plugins edit skip initialization so invalid settings cannot block configuration repair.
Environment configuration supports NEMO_RELAY_LOG, NEMO_RELAY_LOG_STDERR_FORMAT, and an absolute TOML path through NEMO_RELAY_LOG_CONFIG_PATH.
CLI and library integrations share the core LoggingConfig and LoggingRuntime types, validation, defaults, and initialization behavior.
CLI runtime overrides are available through --log-level, --log-stderr-format, and --log-config-path.

Logging remains under [logging] in the normal Relay configuration. I kept a separate interactive logging editor outside this PR because the existing file, CLI, environment, and library configuration surfaces cover the runtime use cases without introducing another configuration workflow.

coderabbitai

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/cli/src/commands/mod.rs`:
- Around line 59-65: Update the initialize_logging decision in the CLI command
dispatch to disable logging for every dry-run mode, including run, install, and
uninstall, rather than relying only on Command::skips_logging. Ensure these
commands bypass logging setup even with an invalid logging configuration, and
add a CLI test covering that behavior.

In `@crates/cli/src/commands/root.rs`:
- Around line 128-134: The dry-run run command must bypass logging
initialization, and its assertion must be tested through CLI dispatch. Update
Command::skips_logging() to match RunCommand only when dry-run is enabled; in
crates/cli/tests/coverage/agents/launcher_tests.rs:1594-1600, move the assertion
to a CLI dispatch test because the launcher path bypasses this logging gate.

In `@crates/cli/tests/coverage/shared/config_tests.rs`:
- Around line 2919-2928: Extend the test around resolved.logging.sinks and its
LogSinkConfig::File entry to exercise the configured sink through the runtime,
not just parsed values. Initialize the logger using the resolved configuration,
emit a trace record, then read the configured log_a file and assert the trace
record is present, ensuring sink-level Trace overrides the global Debug filter.

In `@crates/core/src/logging/config.rs`:
- Around line 240-247: Make both RawLoggingConfig and RawFileLogSinkConfig
reject unknown fields by applying serde’s deny-unknown-fields behavior to each
struct. Add tests covering misspelled or unsupported fields such as
queue_capcity and sink, asserting deserialization fails instead of silently
using defaults or omitting sinks.

In `@crates/core/src/logging/mod.rs`:
- Around line 110-117: Serialize logger installation and removal across teardown
and configure flows so swap_logger(None) cannot overwrite a newer logger
installed concurrently. Update the relevant teardown logic around swap_logger
and the configure path to use a process-wide synchronization mechanism or
generation validation, preserving the newest installation. Add a concurrent
regression test covering reconfiguration racing with teardown.
- Around line 56-60: Update the initialization flow around
spdlog::init_log_crate_proxy and set_logger so an initialization failure is
propagated when the process has a foreign global logger, rather than silently
ignored. Treat SetLoggerError as benign only for genuine re-entry where the
Relay proxy is already installed, and preserve receiver/filter setup for
successful initialization.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7ead193d-202f-42f5-ba42-73727a0736fb

📥 Commits

Reviewing files that changed from the base of the PR and between b47edca and 07d31ee.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (19)

ATTRIBUTIONS-Rust.md
crates/cli/src/commands/logging.rs
crates/cli/src/commands/mod.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/root.rs
crates/cli/src/configuration/logging.rs
crates/cli/src/configuration/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/Cargo.toml
crates/core/src/lib.rs
crates/core/src/logging/config.rs
crates/core/src/logging/format.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/sink.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/core/tests/coverage/logging_tests.rs

📜 Review details

🧰 Additional context used

📓 Path-based instructions (22)

**/*.rs

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

**/*.rs: Any Rust change must run just test-rust
Any Rust change must run cargo fmt --all
Any Rust change must run cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all for all FFI work since it is Rust work
Run just test-rust to validate FFI changes
Run cargo clippy --workspace --all-targets -- -D warnings to enforce strict linting on FFI work

When Rust files changed as part of Go work, also run cargo fmt --all, just test-rust, and cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all when Rust files are changed as part of Node work
Run cargo clippy --workspace --all-targets -- -D warnings when Rust files are changed as part of Node work
Run just test-rust when Rust files are changed as part of Node work

When changing the core Rust runtime or Rust-facing API surface, format Rust code with cargo fmt (rustfmt defaults), keep cargo clippy -- -D warnings clean, and satisfy cargo deny check per deny.toml.

**/*.rs: If any Rust code changed, always run just test-rust.
If any Rust code changed, also run cargo fmt --all.
If any Rust code changed, also run cargo clippy --workspace --all-targets -- -D warnings.
For Rust changes headed for review, run cargo fmt --all and cargo clippy --workspace --all-targets -- -D warnings even if relying on pre-commit.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

{crates/core,crates/adaptive}/**/*

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

Changes to crates/core or crates/adaptive must run the full language matrix

Files:

crates/core/src/lib.rs
crates/core/Cargo.toml
crates/core/tests/coverage/logging_sink_tests.rs
crates/core/src/logging/sink.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/core/tests/coverage/logging_tests.rs

crates/core/**/*.rs

📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)

If the change touched crates/core or shared runtime semantics, also use validate-change for broader validation

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/core/src/logging/sink.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/core/tests/coverage/logging_tests.rs

**/*.{rs,py}

📄 CodeRabbit inference engine (AGENTS.md)

Follow binding naming conventions in Rust and Python: use snake_case.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

**/*.{rs,py,js,mjs,cjs,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{rs,py,js,mjs,cjs,ts,tsx}: Use Json = serde_json::Value in Rust-facing runtime APIs where the existing code expects JSON payloads.
Use Result<T> with FlowError in core runtime paths, and keep errors explicit and binding-appropriate at the wrapper layer.
Keep async behavior on the existing tokio-based model; bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

**/*.{rs,py,go,js,ts,c,h}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use language-appropriate naming conventions: Rust snake_case, C FFI exports prefixed nemo_relay_, Go PascalCase, Node.js camelCase, and Python snake_case.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

**/*.{rs,go,js,ts}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Add the SPDX license header to all Rust, Go, JavaScript, and TypeScript source files using the corresponding // comment form.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

{crates/**/src/**/*.rs,python/**/*.py}

📄 CodeRabbit inference engine (.agents/skills/maintain-dynamic-plugins/SKILL.md)

Do not add tests under src; Rust tests belong in crate tests/ trees, and Python SDK tests belong under python/tests.

Files:

crates/core/src/lib.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/cli/src/configuration/mod.rs

**/*

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

**/*: Format changed files with the language-native formatter before the final lint/test pass.
If dynamic plugin behavior changed, use maintain-dynamic-plugins and include the native SDK, worker protocol, Python SDK, docs, packaging, and Codecov surfaces in the validation plan.
If code changes alter APIs, bindings, commands, paths, packaging behavior, observability/adaptive semantics, or documented best practices, update any dependent maintainer or consumer skills in the same branch.
During iteration, prefer uv run pre-commit run --files <changed files...>.
Before review or handoff, run uv run pre-commit run --all-files.

Files:

crates/core/src/lib.rs
crates/core/Cargo.toml
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
ATTRIBUTIONS-Rust.md
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

crates/{core,adaptive}/**/*

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

If crates/core or crates/adaptive changed, run the full validation matrix across Rust, Python, Go, and Node.js.

Files:

crates/core/src/lib.rs
crates/core/Cargo.toml
crates/core/tests/coverage/logging_sink_tests.rs
crates/core/src/logging/sink.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/core/tests/coverage/logging_tests.rs

**/*.{rs,py,go,js,ts}

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

If a language surface changed, always run that language's test target even when Rust core did not change.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/src/commands/plugins/subcommands.rs
crates/cli/src/commands/mod.rs
crates/cli/src/configuration/types.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/src/commands/logging.rs
crates/cli/src/commands/root.rs
crates/core/src/logging/sink.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/cli/src/configuration/logging.rs
crates/core/tests/coverage/logging_tests.rs
crates/cli/src/configuration/mod.rs

crates/{core,adaptive}/**/*.rs

⚙️ CodeRabbit configuration file

crates/{core,adaptive}/**/*.rs: Review the Rust runtime for async correctness, scope isolation, middleware ordering, and event lifecycle regressions.
Pay close attention to task-local/thread-local scope propagation, callback lifetimes, stream finalization, and root_uuid isolation.
Public API changes should preserve existing behavior unless tests and docs show the intended migration path.

Files:

crates/core/src/lib.rs
crates/core/tests/coverage/logging_sink_tests.rs
crates/core/src/logging/sink.rs
crates/core/src/logging/config.rs
crates/core/src/logging/mod.rs
crates/core/src/logging/format.rs
crates/core/tests/coverage/logging_tests.rs

**/Cargo.toml

📄 CodeRabbit inference engine (.agents/skills/prepare-code-freeze/SKILL.md)

Confirm or infer the target release version from upstream/main:Cargo.toml. Derive the release branch as release/<major>.<minor>.

Keep Rust package names and workspace metadata in Cargo.toml internally consistent across the project.

Files:

crates/core/Cargo.toml

**/*.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Add the SPDX license header to all TOML files using the # comment form.

Files:

crates/core/Cargo.toml

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}

⚙️ CodeRabbit configuration file

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.

Files:

crates/core/tests/coverage/logging_sink_tests.rs
crates/cli/tests/coverage/agents/launcher_tests.rs
crates/cli/tests/coverage/commands/main_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/coverage/logging_tests.rs

**/*.{md,rst,html,txt}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)

**/*.{md,rst,html,txt}: Always spell NVIDIA in all caps. Do not use Nvidia, nvidia, nVidia, nVIDIA, or NV.
Use an NVIDIA before a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol after NVIDIA when referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names with NVIDIA on first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms with s, not an apostrophe, such as GPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such as CPU, GPU, PC, API, and UI usually do not need to be spelled out for developer audiences.

Files:

ATTRIBUTIONS-Rust.md

**/*.{md,rst,html}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)

Link the first mention of a product name when the destination helps the reader.

Files:

ATTRIBUTIONS-Rust.md

**/*.{md,rst,txt}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)

Spell NVIDIA in all caps. Do not use Nvidia, nvidia, or NV.

Files:

ATTRIBUTIONS-Rust.md

**/*.{md,rst}

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)

**/*.{md,rst}: Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as "here" or "read more."
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Use can for possibility and reserve may for permission.
Use after for temporal relationships instead of once.
Prefer refer to over see when the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical docs.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented docs unless the source, platform, or legal guidance explicitly requires them.

Files:

ATTRIBUTIONS-Rust.md

**/*.md

📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)

**/*.md: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Format code elements, commands, parameters, package names, and expressions in monospace
Format directories, file names, and paths in monospace using backticks
Use angle brackets inside monospace for variables inside paths, such as /home/<username>/.login
Format error messages and strings in quotation marks, keeping literal code strings in code formatting when clearer
Format UI buttons, menus, fields, and labels in bold
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use, sparingly and only when introducing the term
Use italics for publication titles
Format keyboard shortcuts in plain text, such as Press Ctrl+Alt+Delete
Use owner/repo link text for GitHub repositories, preferring [NVIDIA/NeMo](link) over prose references like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text
Avoid generic anchor text such as 'here,' 'this page,' and 'read more'
Include acronyms in link text when a linked term includes an acronym
Do not link long sentences or multiple sentences
Avoid links that pull readers away from a procedure unless the link is a p...

Files:

ATTRIBUTIONS-Rust.md

**/*.{md,mdx}

📄 CodeRabbit inference engine (AGENTS.md)

Update README.md, fern/, package READMEs, and binding-support notes when public behavior, package names, examples, or supported bindings change.

**/*.{md,mdx}: Prefer the documented public API, not internal shortcuts
Keep package names, repo references, and build commands current
Keep release-process and release-notes guidance in repo-maintainer docs such as RELEASING.md, not as user-facing docs pages or CHANGELOG.md
Keep stable user-facing wrappers at scripts/ root in docs and examples; only point at namespaced helper paths when documenting internal maintenance work
When detailed dynamic plugin guides exist, keep Rust native plugin examples, Python worker plugin examples, and grpc-v1 protocol details on separate pages

If links in documentation change, run just docs-linkcheck.

Files:

ATTRIBUTIONS-Rust.md

**/*.{md,markdown,mdx}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Add the SPDX license header to all Markdown/MDX documentation files using the HTML comment block form.

Files:

ATTRIBUTIONS-Rust.md

🪛 markdownlint-cli2 (0.23.0)

ATTRIBUTIONS-Rust.md

[warning] 2303-2303: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below