Skip to content

chore(skills): refresh stale Relay signatures#469

Open
exactlyallan wants to merge 2 commits into
mainfrom
fix/refresh-relay-skill-signatures
Open

chore(skills): refresh stale Relay signatures#469
exactlyallan wants to merge 2 commits into
mainfrom
fix/refresh-relay-skill-signatures

Conversation

@exactlyallan

@exactlyallan exactlyallan commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Overview

Refresh two stale NeMo Relay skill signatures that are currently blocking publication through the NVIDIA skills catalog sync.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Remove the stale skill.oms.sig bundle from nemo-relay-get-started.
  • Remove the stale skill.oms.sig bundle from nemo-relay-plugin-observability.
  • Reflow existing Markdown in each affected SKILL.md without changing rendered
    instructions, ensuring NVCARPS includes both skills in its signing input set.
  • Leave all references, evaluations, cards, and benchmarks unchanged.
  • Trigger /nvskills-ci so the signing bot regenerates content-aligned bundles and validation artifacts.

Do not merge until the Attach NVSkills validation signatures bot commit lands and both affected skills pass content-integrity verification.

Where should the reviewer start?

Start with the two deleted signature bundles and the rendered-content-neutral Markdown reflows. NVSkills CI should restore each bundle with digests matching the current skill content.

Validation before opening:

  • Reproduced the catalog integrity failure against current NVIDIA/NeMo-Relay/main.
  • Confirmed exactly one mismatched signed file in nemo-relay-get-started.
  • Confirmed exactly five mismatched signed files in nemo-relay-plugin-observability.
  • Confirmed the only non-generated changes are rendered-content-neutral Markdown reflows in the two affected SKILL.md files.
  • git diff --check

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Chores
    • Removed obsolete signature metadata from the Nemo Relay getting-started and observability skill packages.
  • Documentation
    • Updated Markdown formatting in the getting-started and observability skills’ guides (line wrapping only) to improve readability, without changing meaning or instructions.

Remove the two signature bundles that no longer match their skill content so NVSkills CI can regenerate content-aligned signatures without changing the underlying skills.

Signed-off-by: Allan Enemark <aenemark@nvidia.com>
@exactlyallan
exactlyallan requested a review from a team as a code owner July 17, 2026 16:44
@github-actions github-actions Bot added size:XS PR is extra small Maintenance CI or Build or general repository maintenance labels Jul 17, 2026
@exactlyallan

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Reflows two skill documentation passages without changing their wording, links, behavior, or public declarations. The associated signature bundle files are removed without replacement content.

Changes

Skill documentation and artifact cleanup

Layer / File(s) Summary
Documentation reflow
skills/nemo-relay-get-started/SKILL.md, skills/nemo-relay-plugin-observability/SKILL.md
Wraps two existing Markdown passages across additional lines while preserving their meaning and link target.
Signature bundle removal
skills/nemo-relay-get-started/skill.oms.sig, skills/nemo-relay-plugin-observability/skill.oms.sig
Removes the existing DSSE/in-toto and Sigstore signature bundle artifacts without replacement content.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title follows Conventional Commits and accurately summarizes the signature refresh change.
Description check ✅ Passed The description matches the template with Overview, Details, reviewer guidance, and related issue linkage.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/refresh-relay-skill-signatures

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the DO NOT MERGE PR should not be merged; see PR for details label Jul 17, 2026
Reflow existing Markdown without changing rendered instructions so NVSkills CI detects both affected skills and can regenerate their stale signature bundles.

Signed-off-by: Allan Enemark <aenemark@nvidia.com>
@github-actions github-actions Bot added size:S PR is small and removed size:XS PR is extra small labels Jul 17, 2026
@exactlyallan

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@coderabbitai coderabbitai Bot removed the DO NOT MERGE PR should not be merged; see PR for details label Jul 17, 2026
@exactlyallan exactlyallan added this to the 0.6 milestone Jul 17, 2026
@exactlyallan exactlyallan self-assigned this Jul 17, 2026
@willkill07

Copy link
Copy Markdown
Member

@exactlyallan could this target release/0.6 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI or Build or general repository maintenance size:S PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants