Forward-merge release/0.6 into main#472
Merged
Merged
Conversation
#### Overview Resolve RELAY-499 by snapshotting ATOF stream-sink headers sourced from `header_env` when the endpoint is activated. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Resolve `headers` and `header_env` once before the endpoint worker is spawned. - Reuse the activated header map for HTTP POST, WebSocket reconnects, and NDJSON uploads. - Add core and Python regressions that remove the environment variable after activation and verify all lifecycle events retain the Authorization header. #### Where should the reviewer start? Start with `crates/core/src/observability/atof.rs`, where `ActivatedAtofEndpoint` carries the validated configuration and snapshotted headers into each transport worker. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: RELAY-499 ## Summary by CodeRabbit * **Bug Fixes** * Improved streaming observability endpoint setup by validating configurations and resolving headers before workers start. * Ensured environment-based headers are captured at activation time and remain available for outgoing requests. * Applied consistent header handling across HTTP, WebSocket, and NDJSON transports. * **Tests** * Added coverage verifying environment-based authorization headers are preserved without exposing credentials in reports, payloads, or logs. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Maryam Najafian (https://github.com/mnajafian-nv) URL: #463
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.6 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.