Skip to content

test(e2e): stop using custom e2e binary builds#2000

Merged
elezar merged 1 commit into
mainfrom
sscatton/remove-custom-e2e-checks-features
Jun 25, 2026
Merged

test(e2e): stop using custom e2e binary builds#2000
elezar merged 1 commit into
mainfrom
sscatton/remove-custom-e2e-checks-features

Conversation

@SDAChess

Copy link
Copy Markdown
Collaborator

Remove the production-crate dev-settings feature so e2e tests build the same gateway, CLI, and supervisor binaries that we ship. Move settings coverage from dummy test-only keys to the production ocsf_json_enabled setting.

@copy-pr-bot

copy-pr-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@SDAChess SDAChess self-assigned this Jun 25, 2026
@SDAChess SDAChess added the test:e2e Requires end-to-end coverage label Jun 25, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/2000 is at {"messa while the PR head is 3e88ce8. A maintainer needs to comment /ok to test 3e88ce8b105dbf5be49c5b466edf18584483cf68 to refresh the mirror. Once the mirror catches up, re-run Branch E2E Checks from the Actions tab.

@SDAChess

Copy link
Copy Markdown
Collaborator Author

/ok-to-test 3e88ce8

Comment thread .github/workflows/rust-native-build.yml
Comment thread crates/openshell-cli/src/run.rs
Comment thread crates/openshell-cli/src/run.rs
Comment thread tasks/test.toml Outdated
@SDAChess
SDAChess force-pushed the sscatton/remove-custom-e2e-checks-features branch from 3e88ce8 to b650186 Compare June 25, 2026 12:36
@SDAChess

Copy link
Copy Markdown
Collaborator Author

/ok-to-test b650186

@SDAChess
SDAChess force-pushed the sscatton/remove-custom-e2e-checks-features branch from b650186 to 0e60cc6 Compare June 25, 2026 12:41
Comment thread e2e/rust/e2e-podman.sh Outdated
Comment thread e2e/rust/e2e-kubernetes.sh Outdated
Comment thread e2e/rust/e2e-docker.sh Outdated
@SDAChess
SDAChess force-pushed the sscatton/remove-custom-e2e-checks-features branch 2 times, most recently from 0181858 to c529764 Compare June 25, 2026 12:51
@SDAChess

Copy link
Copy Markdown
Collaborator Author

/ok-to-test c529764

Comment thread e2e/support/gateway-common.sh Outdated
Remove the production-crate dev-settings feature so e2e tests build the same gateway, CLI, and supervisor binaries that we ship. Move settings coverage from dummy test-only keys to the production ocsf_json_enabled setting.

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@SDAChess
SDAChess force-pushed the sscatton/remove-custom-e2e-checks-features branch from c529764 to c3d83d2 Compare June 25, 2026 12:58
@SDAChess

Copy link
Copy Markdown
Collaborator Author

/ok-to-test c3d83d2

@elezar elezar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elezar
elezar enabled auto-merge (squash) June 25, 2026 13:01
@elezar
elezar merged commit c7879a0 into main Jun 25, 2026
30 of 31 checks passed
@elezar
elezar deleted the sscatton/remove-custom-e2e-checks-features branch June 25, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants