fix(helm): propagate supervisor image overrides#2216
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-2216.docs.buildwithfern.com/openshell |
6 tasks
TaylorMutch
marked this pull request as ready for review
July 10, 2026 18:41
TaylorMutch
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 10, 2026 18:41
|
Label |
Collaborator
Author
|
CC @benoitf as a followup to your PR |
drew
approved these changes
Jul 10, 2026
Contributor
|
Ok thanks @TaylorMutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let the gateway use its version-pinned built-in supervisor image for the default Helm configuration while still propagating Helm image overrides into
gateway.toml.Related Issue
Follow-up to #2068 and #2070.
Changes
supervisor_imagefrom the rendered gateway configuration when the standard repository and empty tag are unchanged.Testing
mise run pre-commitpassesChecklist