Skip to content

fix(ci): fix mirror SHA detection in e2e-label-help workflow #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhuss wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(ci): fix mirror SHA detection in e2e-label-help workflow #2236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/e2e-label-help.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ jobs:
esac

mirror_ref="pull-request/$PR_NUMBER"
mirror_sha=$(gh api "repos/$GH_REPO/branches/$mirror_ref" --jq '.commit.sha' 2>/dev/null || echo "")
mirror_sha=$(gh api "repos/$GH_REPO/git/ref/heads/$mirror_ref" --jq '.object.sha' 2>/dev/null || true)

@elezar elezar Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why || true and not || echo ""?

@rhuss rhuss Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change here is to move from .commit.sha to .object.sha on the refs endpoint to avoid issues with / in branch names.

The true is just more idiomatic, as the output is already empty on failure (so no need to iterate on this), and the important part here is to return with an no error code (which is only a side effect of echo, the true pronounces this better). This is mostly to make set -e happy.

It's also aligned with the validation guard on the next line.

But happy to revert that part if needed.

if [[ ! "$mirror_sha" =~ ^[0-9a-f]{40}$ ]]; then mirror_sha=""; fi
short_pr=${PR_HEAD_SHA:0:7}

if [ -z "$mirror_sha" ]; then
Expand Down
Loading