feat(docker): add support for sandboxes from docker archives#2361
Open
feloy wants to merge 2 commits into
Open
feat(docker): add support for sandboxes from docker archives#2361feloy wants to merge 2 commits into
feloy wants to merge 2 commits into
Conversation
Add support for loading pre-built Docker archives into the local daemon when creating sandboxes, enabling air-gapped and macOS VM-based build pipelines where a Docker archive is the natural hand-off artifact. Closes NVIDIA#2175 Signed-off-by: Philippe Martin <phmartin@nvidia.com> Signed-off-by: Philippe Martin <phmartin@redhat.com>
Verify the full round-trip: docker build → docker save → openshell sandbox create --from archive.tar → marker file present in output. Signed-off-by: Philippe Martin <phmartin@nvidia.com> Signed-off-by: Philippe Martin <phmartin@redhat.com>
feloy
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 20, 2026 08:46
ericcurtin
approved these changes
Jul 20, 2026
drew
changed the title
elezar
reviewed
Jul 21, 2026
Comment on lines
+2635
to
+2638
| lower.ends_with(".tar.gz") | ||
| || Path::new(&*lower) | ||
| .extension() | ||
| .is_some_and(|ext| ext == "tar" || ext == "tgz") |
Member
There was a problem hiding this comment.
Question: Why use ends_with in one case and `.extension for the other? Can we use the same logic for all cases?
Also we already have a path? Can't we call .extension() directly on that and then map the resultant string through to_lowercase()?
elezar
reviewed
Jul 21, 2026
Comment on lines
2532
to
+2533
| /// 1. Existing file whose name contains "Dockerfile" → build from file. | ||
| /// 1b. Existing file with `.tar`/`.tar.gz`/`.tgz` extension → load archive. |
Member
There was a problem hiding this comment.
Split into: A single heading like "Existing file" followed by two points indicating the different sources.
elezar
reviewed
Jul 21, 2026
| /// Resolution order: | ||
| /// 1. Existing file whose name contains "Dockerfile" → build from file. | ||
| /// 1b. Existing file with `.tar`/`.tar.gz`/`.tgz` extension → load archive. | ||
| /// 2. Existing directory that contains a `Dockerfile` → build from directory. |
Member
There was a problem hiding this comment.
Question: Why are two "Dockerfile" cases now separated by a archive case? Should the explicit Dockerfile and Dockerfile parent folder cases not be treated the same way?
elezar
reviewed
Jul 21, 2026
| /// 1. Existing file whose name contains "Dockerfile" → build from file. | ||
| /// 1b. Existing file with `.tar`/`.tar.gz`/`.tgz` extension → load archive. | ||
| /// 2. Existing directory that contains a `Dockerfile` → build from directory. | ||
| /// 3. Missing explicit local paths → local error, not image pull. |
Member
There was a problem hiding this comment.
Out-of-scope: What are "Missing explicit local paths"?
elezar
reviewed
Jul 21, 2026
| @@ -2610,6 +2625,19 @@ fn filename_looks_like_dockerfile(path: &Path) -> bool { | |||
| lower.contains("dockerfile") || lower.ends_with(".dockerfile") | |||
Member
There was a problem hiding this comment.
Out of scope, but the || lower.ends_with(".dockerfile") is redundant since lower.contains("dockerfile")` will ALWAYS be true in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Docker archives (
.tar,.tar.gz,.tgz) as--fromsources onsandbox create. This enables air-gapped environments and VM-based build pipelines where a Docker archive is the natural hand-off artifact.Related Issue
Closes #2175
Changes
DockerArchive { path }variant toResolvedSourcein the CLI.tar/.tar.gz/.tgzfiles inresolve_from()via extension-based matching (consistent with the existing Dockerfile filename heuristic)load_docker_archive()inopenshell-bootstrapusing Bollard'simport_image()(POST /images/load), parsing the image tag from Docker's"Loaded image: <tag>"responseload_from_docker_archive()in the CLI with the same local-gateway guard as Dockerfile sources--fromhelp text and published docs to mention Docker archive supportNo proto, gateway, or server changes — the archive's embedded tag flows through the existing
SandboxTemplate.imagefield.Testing
mise run pre-commitpassesresolve_fromcorrectly classifies.tar,.tar.gz,.tgzfiles asDockerArchivefilename_looks_like_docker_archivedetects valid extensions (case-insensitive) and rejects non-archivesChecklist