fix(docker): install git for repository scans#78
Merged
Conversation
Signed-off-by: medhdj <medhdjdevs@gmail.com>
Member
|
LGTM. The Docker runtime image needs git for repository URL scans, and this installs it in the final image with --no-install-recommends plus apt list cleanup. ca-certificates is also appropriate for HTTPS clones. Testing internally... Then I will merge |
keshprad
approved these changes
Jun 15, 2026
keshprad
added a commit
that referenced
this pull request
Jun 16, 2026
Refresh the public SkillSpector snapshot from the internal OSS release branch release/oss-2026-06-15 at a7ebb82733fba54512c546fed08cd17a2cbc4a17. Changes: - Correct the documented bundled model registry path for SKILLSPECTOR_MODEL_REGISTRY. - Add explicit returns in Docker smoke helper functions. Notes: - Rebased onto latest GitHub main after #78 merged. - Supersedes the original provider-registry documentation PR #30. Verification: - PATH="$PWD/.venv/bin:$PATH" ./scripts/create-oss-release.sh release/oss-2026-06-15 - includes make test-unit: 600 passed, 11 skipped, 22 deselected - git diff --check origin/main..HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The README documents scanning remote Git repositories from the Docker image, but the runtime image is based on
python:3.12-slim-bookwormand does not include Git. Running a command such as:docker run --rm -v "$PWD:/scan" skillspector scan https://github.com/JuliusBrussee/caveman --no-llmfails with:
Solution
Install
gitin the final runtime stage of the Docker image. The same layer also explicitly installsca-certificatesfor HTTPS repository cloning, uses--no-install-recommends, and removes the apt package lists to limit image overhead.Verification
make docker-build.git version 2.39.5is available in the container.skillspector --versionreportsSkillSpector v2.1.4.https://github.com/JuliusBrussee/cavemanfrom the container.