[#10519][feat] AutoDeploy: support HF fine grained FP8 - #10650
Closed
Fridah-nv wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Fridah-nv
marked this pull request as ready for review
January 14, 2026 23:16
Fridah-nv
requested review from
bmarimuthu-nv,
galagam,
greg-kwasniewski1 and
lucaslie
January 14, 2026 23:16
lucaslie
reviewed
Jan 15, 2026
lucaslie
left a comment
Contributor
There was a problem hiding this comment.
what's the actual quantization format we are supporting here? "hf_fp8" doesn't seem to be it?
| stage: pattern_matcher | ||
| quantize_nvfp4_linear_from_config: | ||
| stage: pattern_matcher | ||
| quantize_hf_fp8_linear_from_config: |
Contributor
There was a problem hiding this comment.
is hf_fp8 an accurate naming here? Shouldn't we name it according to the algorithm (dynamic fp8) rather than the source
Comment on lines
+324
to
+325
| @torch.library.custom_op("auto_deploy::torch_fake_quant_hf_fp8_linear", mutates_args=()) | ||
| def torch_fake_quant_hf_fp8_linear( |
Comment on lines
+334
to
+338
| """HuggingFace FineGrainedFP8 linear operation. | ||
| - weight_scale[0] = weight_scale_inv (per-block weight scale) | ||
| - input_scale, input_zp, weight_zp are unused | ||
| - block_size is inferred from weight and weight_scale_inv shapes | ||
| """ |
Contributor
There was a problem hiding this comment.
docstring seems incomplete?
| - input_scale, input_zp, weight_zp are unused | ||
| - block_size is inferred from weight and weight_scale_inv shapes | ||
| """ | ||
| from transformers.integrations.finegrained_fp8 import act_quant, w8a8_block_fp8_matmul_triton |
Contributor
There was a problem hiding this comment.
is there no other kernel/implementation available for this?
Contributor
There was a problem hiding this comment.
why not do a global import?
| cnt += 1 | ||
|
|
||
| return gm, TransformInfo( | ||
| skipped=False, num_matches=cnt, is_clean=False, has_valid_shapes=(cnt == 0) |
Contributor
There was a problem hiding this comment.
Suggested change
| skipped=False, num_matches=cnt, is_clean=False, has_valid_shapes=(cnt == 0) | |
| skipped=False, num_matches=cnt, is_clean=(cnt == 0), has_valid_shapes=(cnt == 0) |
lucaslie
reviewed
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Please check if this PR needs a rebase now that #10635 has merged
Collaborator
Author
|
The feature will be handled by: #10897 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10519
Tested with Llama3 8B checkpoint produced from
Checked graph for TP=1 and TP=2, graphs look good, outputs are fine as well.
TODO:
update quantize_hf_fp8_linear_from_config with two stage
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.