Skip to content

[#10519][feat] AutoDeploy: support HF fine grained FP8 - #10650

Closed
Fridah-nv wants to merge 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:user/fridah/hf-fp8
Closed

[#10519][feat] AutoDeploy: support HF fine grained FP8#10650
Fridah-nv wants to merge 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:user/fridah/hf-fp8

Conversation

@Fridah-nv

@Fridah-nv Fridah-nv commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

Closes #10519

Tested with Llama3 8B checkpoint produced from

import torch
from transformers import AutoModelForCausalLM, AutoTokenizer, FineGrainedFP8Config

model_name = "meta-llama/Meta-Llama-3.1-8B-Instruct"
quantization_config = FineGrainedFP8Config(modules_to_not_convert=["lm_head"])
model = AutoModelForCausalLM.from_pretrained(
    model_name,
    torch_dtype="auto",
    use_cache=False,
    quantization_config=quantization_config,
).to("cuda")
save_dir = "./llama3_fp8"
model.save_pretrained(save_dir)
tokenizer = AutoTokenizer.from_pretrained(model_name)
tokenizer.save_pretrained(save_dir)

Checked graph for TP=1 and TP=2, graphs look good, outputs are fine as well.

TODO:
update quantize_hf_fp8_linear_from_config with two stage

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
@Fridah-nv Fridah-nv self-assigned this Jan 14, 2026
@Fridah-nv Fridah-nv changed the title works E2E with Llama3 8B WS=1 and WS=2 [#10519][feat] AutoDeploy: support HF fine grained FP8 Jan 14, 2026
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
@Fridah-nv
Fridah-nv marked this pull request as ready for review January 14, 2026 23:16
@Fridah-nv
Fridah-nv requested a review from a team as a code owner January 14, 2026 23:16

@lucaslie lucaslie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the actual quantization format we are supporting here? "hf_fp8" doesn't seem to be it?

stage: pattern_matcher
quantize_nvfp4_linear_from_config:
stage: pattern_matcher
quantize_hf_fp8_linear_from_config:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is hf_fp8 an accurate naming here? Shouldn't we name it according to the algorithm (dynamic fp8) rather than the source

Comment on lines +324 to +325
@torch.library.custom_op("auto_deploy::torch_fake_quant_hf_fp8_linear", mutates_args=())
def torch_fake_quant_hf_fp8_linear(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto re name

Comment on lines +334 to +338
"""HuggingFace FineGrainedFP8 linear operation.
- weight_scale[0] = weight_scale_inv (per-block weight scale)
- input_scale, input_zp, weight_zp are unused
- block_size is inferred from weight and weight_scale_inv shapes
"""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring seems incomplete?

- input_scale, input_zp, weight_zp are unused
- block_size is inferred from weight and weight_scale_inv shapes
"""
from transformers.integrations.finegrained_fp8 import act_quant, w8a8_block_fp8_matmul_triton

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no other kernel/implementation available for this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not do a global import?

cnt += 1

return gm, TransformInfo(
skipped=False, num_matches=cnt, is_clean=False, has_valid_shapes=(cnt == 0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skipped=False, num_matches=cnt, is_clean=False, has_valid_shapes=(cnt == 0)
skipped=False, num_matches=cnt, is_clean=(cnt == 0), has_valid_shapes=(cnt == 0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this PR needs a rebase now that #10635 has merged

@Fridah-nv

Copy link
Copy Markdown
Collaborator Author

The feature will be handled by: #10897

@Fridah-nv Fridah-nv closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: AutoDeploy: support Finegrained fp8 dynamic quantization

2 participants