Skip to content

[None][chore] Add failed cases into waives.txt - #11453

Closed
xinhe-nv wants to merge 3 commits into
NVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260212_LLM_FUNCTION_TEST_1929
Closed

[None][chore] Add failed cases into waives.txt#11453
xinhe-nv wants to merge 3 commits into
NVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260212_LLM_FUNCTION_TEST_1929

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure to skip a test case in the disaggregated serving test suite.

@xinhe-nv
xinhe-nv marked this pull request as ready for review February 12, 2026 04:23
@xinhe-nv
xinhe-nv force-pushed the user/qa/post_update_waive_20260212_LLM_FUNCTION_TEST_1929 branch from 3f62935 to fae1c03 Compare February 12, 2026 04:23
@xinhe-nv
xinhe-nv enabled auto-merge (squash) February 12, 2026 04:23
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list ""

@coderabbitai

coderabbitai Bot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change adds a single skip entry to the test waives list for a specific test case under TestLlama3_1_8BInstruct, referencing a bug tracker issue for tracking purposes.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Added SKIP entry for full:sm89/accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ngram with reference to issue nvbugs/5893116.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and lacks required template sections like detailed explanation and test coverage information. Expand the description to include details about why these specific test cases were added, their impact, and which tests validate the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding failed cases to the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35713 [ run ] triggered by Bot. Commit: fae1c03

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
xinhe-nv force-pushed the user/qa/post_update_waive_20260212_LLM_FUNCTION_TEST_1929 branch from fae1c03 to 7e4b5f8 Compare February 12, 2026 05:03
@xinhe-nv xinhe-nv closed this Feb 12, 2026
auto-merge was automatically disabled February 12, 2026 05:03

Pull request was closed

@xinhe-nv
xinhe-nv deleted the user/qa/post_update_waive_20260212_LLM_FUNCTION_TEST_1929 branch February 12, 2026 05:03
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #35713 [ run ] completed with state SUCCESS. Commit: fae1c03
/LLM/main/L0_MergeRequest_PR pipeline #27580 (Partly Tested) completed with status: 'SUCCESS'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants