Skip to content

Mf/minimax moe routing kernel #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michaelfeil wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Mf/minimax moe routing kernel #11539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
855df49
minimax
michaelfeil Feb 14, 2026
f2f3560
register custom ops
michaelfeil Feb 14, 2026
a5e5dca
minor fixes
michaelfeil Feb 14, 2026
2f9e036
fix num experts limit
michaelfeil Feb 14, 2026
117cf54
fix fused moe autotuner
michaelfeil Feb 14, 2026
76f6f4d
fixes to python launch method
michaelfeil Feb 14, 2026
dc0d510
add simpler kernel
michaelfeil Feb 14, 2026
2619809
cuda minimax use fp32 logits
michaelfeil Feb 15, 2026
3a3f143
simplify kernel
michaelfeil Feb 15, 2026
99b0168
simplify kernel - fix bug
michaelfeil Feb 15, 2026
b5cc890
simplify kernel - fix bug warp reduce
michaelfeil Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 73 additions & 3 deletions cpp/tensorrt_llm/kernels/trtllmGenKernels/blockScaleMoe/RoutingKernel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ struct KernelParams : public KernelParamsBase<InputT_, OutputT_, MaxNumExperts_,
{
using InputT = InputT_;
using OutputT = OutputT_;


// Add missing static constexpr members for shared utilities
static constexpr int MaxNumExperts = MaxNumExperts_;
static constexpr bool isPow2 = isPow2_;
static constexpr bool UsePdl = UsePdl_;
static constexpr bool UseGroups = UseGroups_;
static constexpr int MaxNumTopExperts = MaxNumTopExperts_;

Expand Down Expand Up @@ -255,6 +259,11 @@ struct KernelParams : public KernelParamsBase<InputT_, OutputT_, MaxNumExperts_,
{
using InputT = InputT_;
using OutputT = OutputT_;

// Add missing static constexpr members for shared utilities
static constexpr int MaxNumExperts = MaxNumExperts_;
static constexpr bool isPow2 = isPow2_;
static constexpr bool UsePdl = UsePdl_;

PackedScoreIdx<OutputT>* mPtrTopKPacked = nullptr;

Expand Down Expand Up @@ -302,7 +311,11 @@ struct KernelParams : public KernelParamsBase<InputT_, OutputT_, MaxNumExperts_,
{
using InputT = InputT_;
using OutputT = OutputT_;


// Add missing static constexpr members for shared utilities
static constexpr int MaxNumExperts = MaxNumExperts_;
static constexpr bool isPow2 = isPow2_;
static constexpr bool UsePdl = UsePdl_;
static constexpr bool DoSoftmaxBeforeTopK = DoSoftmaxBeforeTopK_;

PackedScoreIdx<OutputT>* mPtrTopKPacked = nullptr;
Expand All @@ -329,6 +342,63 @@ void run(Data const& data, void* stream);

} // namespace routingRenormalize

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////////////////////////////////////

namespace routingMiniMax
{

//////////////////////////////////////////////////////////////////////////////////////////////////

struct Data : public DataBase
{
tg::Dtype mDtypeExpW{tg::Dtype::Fp32};

// Used by KernelParams::setKernelParams
void const* mPtrRoutingBias{nullptr};

// Used by KernelParams::setKernelParams
bool mNormTopkProb{true};
};

//////////////////////////////////////////////////////////////////////////////////////////////////

template <typename InputT_, typename OutputT_, int MaxNumExperts_, bool DoSoftmaxBeforeTopK_, bool isPow2_, bool UsePdl_>
struct KernelParams : public KernelParamsBase<InputT_, OutputT_, MaxNumExperts_, isPow2_, UsePdl_>
{
using InputT = InputT_;
using OutputT = OutputT_;

// Add missing static constexpr members for shared utilities
static constexpr int MaxNumExperts = MaxNumExperts_;
static constexpr bool isPow2 = isPow2_;
static constexpr bool UsePdl = UsePdl_;
static constexpr bool DoSoftmaxBeforeTopK = DoSoftmaxBeforeTopK_;

PackedScoreIdx<OutputT>* mPtrTopKPacked = nullptr;

OutputT const* mPtrRoutingBias = nullptr;

int32_t mTopK = 0;

bool mNormTopkProb = true;

static KernelParams setKernelParams(Data const& data)
{
KernelParams params;
params.setBaseParams(data);

params.mPtrTopKPacked = (PackedScoreIdx<OutputT>*) data.mPtrTopKPacked;
params.mPtrRoutingBias = static_cast<OutputT const*>(data.mPtrRoutingBias);
params.mNormTopkProb = data.mNormTopkProb;
params.mTopK = data.mTopK;
return params;
}
};

void run(Data const& data, void* stream);

} // namespace routingMiniMax

//////////////////////////////////////////////////////////////////////////////////////////////////
} // namespace routing
} // namespace moe::dev
Loading