Skip to content

[None][feat] add sanity tests for release1.2 version - #11738

Merged
yingguo-trt merged 2 commits into
NVIDIA:release/1.2from
yingguo-trt:feature/release1.2-sanity-tests
Feb 26, 2026
Merged

[None][feat] add sanity tests for release1.2 version#11738
yingguo-trt merged 2 commits into
NVIDIA:release/1.2from
yingguo-trt:feature/release1.2-sanity-tests

Conversation

@yingguo-trt

@yingguo-trt yingguo-trt commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added a new release sanity test suite with performance and accuracy benchmarks across multiple scenarios and configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
@yingguo-trt
yingguo-trt requested a review from a team as a code owner February 26, 2026 06:38
@yingguo-trt
yingguo-trt enabled auto-merge (squash) February 26, 2026 06:38
@coderabbitai

coderabbitai Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c5f1da and 2e590d8.

📒 Files selected for processing (1)
  • tests/integration/defs/perf/disagg/testlist/release_sanity.txt

📝 Walkthrough

Walkthrough

A new test list file is added containing curated performance and accuracy benchmarks for disagg and wideep suites, organized by scenario with specific test configurations and parameters.

Changes

Cohort / File(s) Summary
Release Sanity Test List
tests/integration/defs/perf/disagg/testlist/release_sanity.txt
Added new test list file with curated performance and accuracy benchmarks for disagg and wideep suites, categorized by scenarios (GB200, GB300, Qwen3-235B-A22B-FP4, wideep variants, Kimi-k2-thinking) and specifying test parameterized contexts, targets, and configurations (NIXL, UCX, Default, CC B, MT P0/3, etc.).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template with no actual content filled in for Description or Test Coverage sections, making it largely incomplete. Add a meaningful Description section explaining why sanity tests are needed for release 1.2, and document Test Coverage with the specific tests being added.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change—adding sanity tests for release 1.2—and aligns with the primary purpose of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@yingguo-trt

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Not cover in CI pipelines"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36879 [ skip ] triggered by Bot. Commit: 2e590d8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #36879 [ skip ] completed with state SUCCESS. Commit: 2e590d8
Skipping testing for commit 2e590d8

Link to invocation

@yingguo-trt
yingguo-trt merged commit 11dba1b into NVIDIA:release/1.2 Feb 26, 2026
8 of 9 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
chzblych pushed a commit that referenced this pull request Mar 7, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants