Skip to content

[https://nvbugs/5775256] [fix] Reopen fp8_dsl_fused_moe ut. - #11779

Merged
yuxianq merged 1 commit into
NVIDIA:release/1.2from
limin2021:release-1.2-fused_moe_ut_fix_1
Mar 2, 2026
Merged

[https://nvbugs/5775256] [fix] Reopen fp8_dsl_fused_moe ut.#11779
yuxianq merged 1 commit into
NVIDIA:release/1.2from
limin2021:release-1.2-fused_moe_ut_fix_1

Conversation

@limin2021

@limin2021 limin2021 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Re-enabled two previously skipped tests to expand test coverage validation.

Description

[https://nvbugs//5775256][fix] Reopen fp8_dsl_fused_moe ut

bug description: https://nvbugspro.nvidia.com/bug/5775256

This error can't reproduce locally. When I reopen the UT, The CI passed too.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@limin2021
limin2021 requested a review from a team as a code owner February 27, 2026 07:59
@limin2021

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Two test skip entries are removed from the waives list, enabling two previously skipped test cases to run.

Changes

Cohort / File(s) Summary
Test Skip Removal
tests/integration/test_lists/waives.txt
Removed two SKIP entries for tests in test_fused_moe.py and test_ops.py, allowing these test cases to execute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title references fixing a fused_moe unit test by removing SKIP entries from the waives.txt file, which directly corresponds to the changeset that removes two SKIP test entries.
Description check ✅ Passed The PR description is mostly complete with a bug reference, issue explanation, and checklist completion, but the Test Coverage section is left empty.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37047 [ run ] triggered by Bot. Commit: 1f8937b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37047 [ run ] completed with state SUCCESS. Commit: 1f8937b
/LLM/release-1.2/L0_MergeRequest_PR pipeline #415 completed with status: 'SUCCESS'

Link to invocation

@limin2021

Copy link
Copy Markdown
Collaborator Author

/bot help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@limin2021

Copy link
Copy Markdown
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37073 [ run ] triggered by Bot. Commit: 1f8937b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37073 [ run ] completed with state SUCCESS. Commit: 1f8937b
/LLM/release-1.2/L0_MergeRequest_PR pipeline #418 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@limin2021 limin2021 changed the title fused_moe ut test. [https://nvbugs/5775256] [fix] Reopen fp8_dsl_fused_moe ut. Feb 27, 2026

@litaotju litaotju left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM approved by NVCortex agent

@chang-l

chang-l commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

/bot run --post-merge "DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37104 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: DGX_B300-4_GPUs-PyTorch-Post-Merge-1

Link to invocation

@chang-l

chang-l commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

/bot run --post-merge --stage-list "DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37107 [ run ] triggered by Bot. Commit: 1f8937b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37107 [ run ] completed with state FAILURE. Commit: 1f8937b
/LLM/release-1.2/L0_MergeRequest_PR pipeline #421 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@limin2021

Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge --stage-list "DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37137 [ run ] triggered by Bot. Commit: 1f8937b Link to invocation

@limin2021

Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge --stage-list "DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37246 [ run ] triggered by Bot. Commit: 1f8937b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37246 [ run ] completed with state SUCCESS. Commit: 1f8937b
/LLM/release-1.2/L0_MergeRequest_PR pipeline #429 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Link to invocation

@limin2021

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37256 [ run ] triggered by Bot. Commit: 1f8937b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37256 [ run ] completed with state SUCCESS. Commit: 1f8937b
/LLM/release-1.2/L0_MergeRequest_PR pipeline #430 completed with status: 'SUCCESS'

Link to invocation

@yuxianq
yuxianq merged commit db3af40 into NVIDIA:release/1.2 Mar 2, 2026
7 of 13 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 5, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
chzblych pushed a commit that referenced this pull request Mar 7, 2026
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
limin2021 added a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
…1779)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants