[https://nvbugs/5938603][fix] Fix E/PD disagg chunked prefill bug - #11805
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThese changes modify multimodal data handling in Qwen model implementations to use explicit None checks instead of truthiness checks for multimodal_embedding, and add enable_chunked_prefill and max_num_tokens parameters to multimodal encoder test cases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #37157 [ run ] triggered by Bot. Commit: |
|
PR_Github #37157 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37228 [ run ] triggered by Bot. Commit: |
|
PR_Github #37228 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37275 [ run ] triggered by Bot. Commit: |
|
PR_Github #37275 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37363 [ run ] triggered by Bot. Commit: |
|
PR_Github #37363 [ run ] completed with state
|
Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #37388 [ run ] triggered by Bot. Commit: |
|
PR_Github #37388 [ run ] completed with state |
…IDIA#11805) Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
…IDIA#11805) Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Summary by CodeRabbit
Release Notes
New Features
enable_chunked_prefillparameter to enable chunked prefill processing, allowing more efficient token handling during multimodal operations.max_num_tokensparameter to specify a token budget constraint for multimodal processing workflows.Bug Fixes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.