Skip to content

[None][infra] Waive failed cases for main on 03/01 - #11811

Merged
EmmaQiaoCh merged 1 commit into
NVIDIA:mainfrom
EmmaQiaoCh:emma/waive_main_0301
Mar 1, 2026
Merged

[None][infra] Waive failed cases for main on 03/01#11811
EmmaQiaoCh merged 1 commit into
NVIDIA:mainfrom
EmmaQiaoCh:emma/waive_main_0301

Conversation

@EmmaQiaoCh

@EmmaQiaoCh EmmaQiaoCh commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations for CLI flow testing and multi-GPU buffer operations to maintain proper test coverage alignment across platform configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive failed cases"

@EmmaQiaoCh
EmmaQiaoCh enabled auto-merge (squash) March 1, 2026 13:46
@coderabbitai

coderabbitai Bot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a20745a and 33cb2d4.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR adds 17 new SKIP entries to the test waiver list file. The additions target three specific test cases: accuracy/test_cli_flow.py::TestSantacoder::test_auto_dtype, unittest/_torch/multi_gpu/test_user_buffers.py::test_user_buffers_pass, and unittest/_torch/multi_gpu/test_user_buffers.py::test_user_buffers_mm_add_prologue, each with various configuration variants.

Changes

Cohort / File(s) Summary
Test Waiver Metadata
tests/integration/test_lists/waives.txt
Added 17 SKIP entries for three test cases across different configurations to mark them as waived/skipped in the test suite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • chzblych
  • yiqingy0
  • pcastonguay
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template boilerplate with no actual content filled in the Description, Test Coverage, or checklist sections beyond the final checkbox. Fill in the Description section explaining why these test cases are being waived and the Test Coverage section identifying the affected tests.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main change: adding SKIP entries to waive failed test cases for the main branch on the specified date.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37230 [ skip ] triggered by Bot. Commit: 33cb2d4 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37230 [ skip ] completed with state SUCCESS. Commit: 33cb2d4
Skipping testing for commit 33cb2d4

Link to invocation

@EmmaQiaoCh
EmmaQiaoCh merged commit 17eaed5 into NVIDIA:main Mar 1, 2026
8 of 9 checks passed
greg-kwasniewski1 pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Mar 2, 2026
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
@EmmaQiaoCh
EmmaQiaoCh deleted the emma/waive_main_0301 branch April 16, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants