Skip to content

[None][infra] Unwaive and waive Aggregated Perf Tests - #11901

Closed
chenfeiz0326 wants to merge 2 commits into
NVIDIA:mainfrom
chenfeiz0326:chenfeiz/unwaive-aggr-perf-tests
Closed

[None][infra] Unwaive and waive Aggregated Perf Tests#11901
chenfeiz0326 wants to merge 2 commits into
NVIDIA:mainfrom
chenfeiz0326:chenfeiz/unwaive-aggr-perf-tests

Conversation

@chenfeiz0326

@chenfeiz0326 chenfeiz0326 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Enabled previously skipped integration tests to run as part of the test suite.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326 chenfeiz0326 changed the title [None][infra] Unwaive three Aggregated Perf Tests [None][infra] Unwaive four Aggregated Perf Tests Mar 4, 2026
@chenfeiz0326 chenfeiz0326 changed the title [None][infra] Unwaive four Aggregated Perf Tests [None][infra] Unwaive Aggregated Perf Tests Mar 4, 2026
@coderabbitai

coderabbitai Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Removed four SKIP entries from the test waives list, making previously skipped tests eligible for execution. No new test entries were added; only deletions from the skip configuration.

Changes

Cohort / File(s) Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Removed 4 SKIP entries, allowing those tests to run in integration test suites.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete with empty core sections (Description, Test Coverage) and unchecked checklist items, providing insufficient context for the changes. Fill in the Description section explaining why tests are being unskipped, and complete the Test Coverage section listing relevant tests affected by this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title '[None][infra] Unwaive and waive Aggregated Perf Tests' is directly related to the changeset, which removes SKIP entries to unwaive previously skipped tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-1,GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-2,GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-3,GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-4,GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-5,GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-6,GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-7,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-4,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-5"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37667 [ run ] triggered by Bot. Commit: 169defb Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37667 [ run ] completed with state SUCCESS. Commit: 169defb
/LLM/main/L0_MergeRequest_PR pipeline #29152 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chenfeiz0326
chenfeiz0326 requested a review from EmmaQiaoCh March 4, 2026 14:18
@chenfeiz0326 chenfeiz0326 changed the title [None][infra] Unwaive Aggregated Perf Tests [None][infra] Unwaive and waive Aggregated Perf Tests Mar 4, 2026
Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

Close because I will adjust waives.txt in #11802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants