Skip to content

[None][chore] Fix format issue in tensorrt_llm/serve/openai_server.py - #11920

Merged
pcastonguay merged 1 commit into
NVIDIA:mainfrom
chienchunhung:20260304_fix_format
Mar 4, 2026
Merged

[None][chore] Fix format issue in tensorrt_llm/serve/openai_server.py#11920
pcastonguay merged 1 commit into
NVIDIA:mainfrom
chienchunhung:20260304_fix_format

Conversation

@chienchunhung

@chienchunhung chienchunhung commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Style
    • Code formatting adjustments for improved readability.

Description

Fix a formatting issue complained by pre-commit hook.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
@pcastonguay

Copy link
Copy Markdown
Collaborator

/bot skip --comment "fixing pre-commit"

@pcastonguay
pcastonguay marked this pull request as ready for review March 4, 2026 19:56
@pcastonguay
pcastonguay requested a review from a team as a code owner March 4, 2026 19:56
@pcastonguay
pcastonguay requested a review from syuoni March 4, 2026 19:56
@pcastonguay
pcastonguay enabled auto-merge (squash) March 4, 2026 19:57
@coderabbitai

coderabbitai Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f24c36ae-fa81-432a-aca5-e0d2d15d8b29

📥 Commits

Reviewing files that changed from the base of the PR and between 5b81307 and 32b8082.

📒 Files selected for processing (1)
  • tensorrt_llm/serve/openai_server.py

📝 Walkthrough

Walkthrough

Code formatting refactoring that reflowed two identical output_path assignments by introducing line breaks after the path operator, maintaining semantic equivalence with no changes to control flow or error handling.

Changes

Cohort / File(s) Summary
Formatting Refactor
tensorrt_llm/serve/openai_server.py
Reflowed two output_path assignments across lines by adding line breaks after path operator; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing a formatting issue in a specific file as indicated by the raw summary.
Description check ✅ Passed The description provides a brief explanation of the issue (formatting complaint from pre-commit hook) but lacks specific test coverage information despite the template section being present.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37754 [ skip ] triggered by Bot. Commit: 32b8082 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37754 [ skip ] completed with state SUCCESS. Commit: 32b8082
Skipping testing for commit 32b8082

Link to invocation

@pcastonguay
pcastonguay merged commit 460889f into NVIDIA:main Mar 4, 2026
9 of 10 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
…NVIDIA#11920)

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
…NVIDIA#11920)

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
…NVIDIA#11920)

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants