[None][test] Fix deepseek-r1 OOM issue for H100 perf test - #11948
Conversation
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughTest condition blocks in the LLM performance YAML configuration are reorganized. Block Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/test_lists/qa/llm_perf_core.yml`:
- Around line 350-357: The header comment tokens (e.g., "H20, H200, B200, B300"
and "RTX-6000 Server") do not match the selectors in the condition.ranges
(system_gpu_count, compute_capability, gpu_memory) and may unintentionally
include other SKUs; either tighten the predicates in the condition (e.g., narrow
compute_capability and add explicit gpu_model or vendor tags, or raise
gpu_memory threshold) to exactly target the listed GPUs, or broaden the header
text to describe the selector intent (e.g., "any device with compute_capability
>=9.0 <12.0 and gpu_memory>90000") so scheduling intent is unambiguous; apply
the same change to the matching block that mentions "RTX-6000 Server" which
currently uses compute_capability lte 12.0.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 01af4a24-7917-4d7f-ae27-98dfa7900e1c
📒 Files selected for processing (1)
tests/integration/test_lists/qa/llm_perf_core.yml
|
/bot skip --comment "only test list modify" |
|
PR_Github #37854 [ skip ] triggered by Bot. Commit: |
|
PR_Github #37854 [ skip ] completed with state |
|
/bot skip --comment "only test list modify" |
|
PR_Github #37949 [ skip ] triggered by Bot. Commit: |
|
PR_Github #37949 [ skip ] completed with state |
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Summary by CodeRabbit
Note: This release contains no user-facing changes. The updates are limited to testing infrastructure reorganization.
Weekly test found below deepseek fp8 models OOM on H100 (81*8GB), which is expected.
Therefore, modify test list.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.