Skip to content

[TRTLLM-10956][infra] Skip updating gitlab status for GenPostMergeBuilds - #11954

Merged
mzweilz merged 1 commit into
NVIDIA:mainfrom
mzweilz:user/abbyw/dev-abbyw-fix-post-merge-build-job
Mar 8, 2026
Merged

[TRTLLM-10956][infra] Skip updating gitlab status for GenPostMergeBuilds#11954
mzweilz merged 1 commit into
NVIDIA:mainfrom
mzweilz:user/abbyw/dev-abbyw-fix-post-merge-build-job

Conversation

@mzweilz

@mzweilz mzweilz commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

We should not update Gitlab commit status in GenPostMergeBuilds jobs.

Summary by CodeRabbit

Release Notes

  • Chores
    • Optimized build pipeline to conditionally handle GitLab commit status updates and test result collection during specific build modes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@mzweilz
mzweilz requested a review from a team March 5, 2026 16:04
@mzweilz
mzweilz requested a review from a team as a code owner March 5, 2026 16:04
@mzweilz
mzweilz requested review from mlefeb01 and zeroepoch March 5, 2026 16:04
@coderabbitai

coderabbitai Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The change modifies the Jenkins pipeline to conditionally suppress GitLab commit status updates and test result collection when the GEN_POST_MERGE_BUILDS_ONLY flag is active, adding guards in multiple pipeline sections.

Changes

Cohort / File(s) Summary
Pipeline Status & Test Result Guards
jenkins/L0_MergeRequest.groovy
Adds conditional guards (with !GEN_POST_MERGE_BUILDS_ONLY) to skip GitLab commit status updates in setupPipelineEnvironment and all post-section status handlers; extends the always block to skip test result collection when the flag is active.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks critical information required by the template. It provides only the high-level intent but omits required sections like Description (explaining the issue and solution), Test Coverage, and completion of the PR Checklist. Complete the Description section with a clear explanation of the issue and why the fix is needed. Provide a Test Coverage section listing relevant tests. Ensure the PR Checklist items are properly addressed and clearly documented.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: skipping GitLab status updates for GenPostMergeBuilds jobs, which aligns perfectly with the code modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ZhanruiSunCh ZhanruiSunCh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzweilz

mzweilz commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

1 similar comment
@mzweilz

mzweilz commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37991 [ run ] triggered by Bot. Commit: 3e3bed2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #37991 [ run ] completed with state FAILURE. Commit: 3e3bed2
/LLM/main/L0_MergeRequest_PR pipeline #29424 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

We should not update Gitlab commit status in GenPostMergeBuilds jobs.

Signed-off-by: Abby Wei <mengzew@nvidia.com>
@mzweilz
mzweilz force-pushed the user/abbyw/dev-abbyw-fix-post-merge-build-job branch from 3e3bed2 to d777387 Compare March 6, 2026 09:35
@mzweilz

mzweilz commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38007 [ run ] triggered by Bot. Commit: d777387 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38007 [ run ] completed with state SUCCESS. Commit: d777387
/LLM/main/L0_MergeRequest_PR pipeline #29438 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@mzweilz

mzweilz commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38019 [ run ] triggered by Bot. Commit: d777387 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38019 [ run ] completed with state SUCCESS. Commit: d777387
/LLM/main/L0_MergeRequest_PR pipeline #29448 completed with status: 'SUCCESS'

Link to invocation

@mzweilz
mzweilz merged commit 5eb8eab into NVIDIA:main Mar 8, 2026
6 of 7 checks passed
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants