Skip to content

[None][fix] Fix Collect Perf Sanity Result's import requests Error - #12002

Merged
chzblych merged 1 commit into
NVIDIA:mainfrom
chenfeiz0326:chenfeiz/revert-collect-perf-sanity-result
Mar 7, 2026
Merged

[None][fix] Fix Collect Perf Sanity Result's import requests Error#12002
chzblych merged 1 commit into
NVIDIA:mainfrom
chenfeiz0326:chenfeiz/revert-collect-perf-sanity-result

Conversation

@chenfeiz0326

@chenfeiz0326 chenfeiz0326 commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated build and test infrastructure dependencies.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326
chenfeiz0326 requested review from a team and chzblych March 7, 2026 09:40
@chenfeiz0326
chenfeiz0326 requested a review from a team as a code owner March 7, 2026 09:40
@coderabbitai

coderabbitai Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 58d4178a-c4a4-4bcd-8c36-63219258c0e1

📥 Commits

Reviewing files that changed from the base of the PR and between 656091b and c78f537.

📒 Files selected for processing (1)
  • jenkins/L0_MergeRequest.groovy

📝 Walkthrough

Walkthrough

A minor dependency update in the Jenkins pipeline configuration, adding the requests package to the pip3 installation step alongside the existing pyyaml dependency in the pre-merge test collection flow.

Changes

Cohort / File(s) Summary
Jenkins Pipeline Configuration
jenkins/L0_MergeRequest.groovy
Extended pip3 package installation to include both pyyaml and requests dependencies instead of only pyyaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description only contains the template structure with no actual content filled in for Description or Test Coverage sections, leaving critical details unexplained. Fill in the Description section explaining the issue and solution, and the Test Coverage section documenting relevant tests that validate the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: fixing an import requests error in the Collect Perf Sanity Result functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38093 [ run ] triggered by Bot. Commit: c78f537 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38093 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 8 PM PST on 3/7.

Link to invocation

@chzblych

chzblych commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38095 [ run ] triggered by Bot. Commit: c78f537 Link to invocation

@chenfeiz0326
chenfeiz0326 enabled auto-merge (squash) March 7, 2026 14:39
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #38095 [ run ] completed with state SUCCESS. Commit: c78f537
/LLM/main/L0_MergeRequest_PR pipeline #29516 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@chzblych
chzblych disabled auto-merge March 7, 2026 14:49
@chzblych
chzblych merged commit 6b04973 into NVIDIA:main Mar 7, 2026
8 of 10 checks passed
@chzblych

chzblych commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

Partial testing is sufficient.

tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants