Skip to content

[None][fix] Grouping deltas within one streaming interval to reduce overhead and report correct cached_tokens - #12292

Merged
dongfengy merged 2 commits into
NVIDIA:feat/bench_xfrom
dongfengy:user/dongfengy/batching_fix
Mar 19, 2026
Merged

[None][fix] Grouping deltas within one streaming interval to reduce overhead and report correct cached_tokens#12292
dongfengy merged 2 commits into
NVIDIA:feat/bench_xfrom
dongfengy:user/dongfengy/batching_fix

Conversation

@dongfengy

@dongfengy dongfengy commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy
dongfengy requested a review from a team as a code owner March 17, 2026 17:53
@dongfengy
dongfengy requested review from Superjomn and removed request for a team March 17, 2026 17:53
@dongfengy dongfengy changed the title [None][fix] Grouping deltas in one streaming interval to reduce overhead [None][fix] Grouping deltas within one streaming interval to reduce overhead Mar 17, 2026
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #39311 [ run ] triggered by Bot. Commit: 13e881a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #39311 [ run ] completed with state SUCCESS. Commit: 13e881a
/LLM/main/L0_MergeRequest_PR pipeline #30560 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@dongfengy
dongfengy requested a review from JunyiXu-nv March 18, 2026 21:18
Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy dongfengy changed the title [None][fix] Grouping deltas within one streaming interval to reduce overhead [None][fix] Grouping deltas within one streaming interval to reduce overhead and report correct cached_tokens Mar 18, 2026
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

1 similar comment
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #39512 [ run ] triggered by Bot. Commit: e7e6609 Link to invocation

@JunyiXu-nv JunyiXu-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a long overdue. Thanks for fixing it!

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #39512 [ run ] completed with state SUCCESS. Commit: e7e6609
/LLM/main/L0_MergeRequest_PR pipeline #30733 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@dongfengy
dongfengy merged commit 1895a20 into NVIDIA:feat/bench_x Mar 19, 2026
6 of 7 checks passed
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 23, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 23, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 23, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 25, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 25, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 25, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 28, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 29, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 29, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 30, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 30, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 31, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 31, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Mar 31, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 1, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 1, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 1, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 2, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 2, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 3, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 3, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 3, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
dongfengy added a commit to dongfengy/TensorRT-LLM that referenced this pull request Apr 3, 2026
…verhead and report correct cached_tokens (NVIDIA#12292)

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants