Skip to content

[None][infra] waive failed case for main - #12621

Merged
VALLIS-NERIA merged 1 commit into
NVIDIA:mainfrom
EmmaQiaoCh:emma/waive_main_0331
Mar 31, 2026
Merged

[None][infra] waive failed case for main#12621
VALLIS-NERIA merged 1 commit into
NVIDIA:mainfrom
EmmaQiaoCh:emma/waive_main_0331

Conversation

@EmmaQiaoCh

@EmmaQiaoCh EmmaQiaoCh commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated test waiver configuration.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-8_GPUs-PyTorch-1"

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ddd3b6d7-5d0b-429d-8d61-ef590ddccc4f

📥 Commits

Reviewing files that changed from the base of the PR and between 481e946 and 7eeccfa.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single waiver entry was added to the test waiver list for a specific test case variant of accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype_with_helix with fifo_v2-cudagraph:with_padding-pp1tp2cp2 parametrization, marking it as SKIP with reference to an existing issue.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Added SKIP waiver entry for accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype_with_helix with fifo_v2-cudagraph:with_padding-pp1tp2cp2 parametrization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • chenfeiz0326
  • chzblych
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely boilerplate template with no actual content. All required sections (Description, Test Coverage) are empty and unfilled. Fill in the Description section explaining why the test case is being waived, and complete the Test Coverage section with relevant tests. Ensure the PR checklist is properly reviewed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the change: adding a test waiver entry for a specific test case variant. It follows the required format with [None] ticket and [infra] type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #40913 [ run ] triggered by Bot. Commit: 7eeccfa Link to invocation

@VALLIS-NERIA
VALLIS-NERIA enabled auto-merge (squash) March 31, 2026 14:54
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #40913 [ run ] completed with state SUCCESS. Commit: 7eeccfa
/LLM/main/L0_MergeRequest_PR pipeline #31914 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@longlee0622

Copy link
Copy Markdown
Collaborator

/bot skip --comment "test waive has been verified"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #41036 [ skip ] triggered by Bot. Commit: 7eeccfa Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #41036 [ skip ] completed with state SUCCESS. Commit: 7eeccfa
Skipping testing for commit 7eeccfa

Link to invocation

@VALLIS-NERIA
VALLIS-NERIA merged commit 85ab1c0 into NVIDIA:main Mar 31, 2026
9 of 10 checks passed
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: qqiao <qqiao@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants