Skip to content

[None][infra] Bump black and tornado #12876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanjingx87 merged 2 commits into from
Apr 9, 2026
Merged

[None][infra] Bump black and tornado #12876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c9a6c
Bump black and tornado
yuanjingx87 Apr 9, 2026
41f4bfb
[TRTLLM-11207][requirements] Update numpy version to 2 (#11280)
Funatiq Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ wheel>=0.46.2
protobuf>=6.33.5
# WAR against https://github.com/advisories/GHSA-6mq8-rvhq-8wgg
aiohttp>=3.13.3
# WAR against https://github.com/advisories/GHSA-qjxf-f2mg-c6mc
tornado>=6.5.5
Comment on lines +11 to +12

@coderabbitai coderabbitai Bot Apr 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Does tornado version 6.5.5 exist and what is GitHub security advisory GHSA-qjxf-f2mg-c6mc?

💡 Result:

Yes. Tornado 6.5.5 exists—it is a released version on PyPI dated Mar 10, 2026, and it also has official Tornado “What’s new in 6.5.5” release notes. [1] [2]

GHSA-qjxf-f2mg-c6mc is a GitHub Security Advisory for CVE-2026-31958: a denial-of-service (DoS) issue in Tornado versions ≤ 6.5.4 where multipart/form-data requests could contain an excessive number of parts, causing expensive synchronous parsing; it is patched in 6.5.5 (adds a default limit of 100 parts and provides configuration/disable options via tornado.httputil.ParseMultipartConfig). [3] [2]

Sources: [1] [2] [3]

🏁 Script executed:

#!/bin/bash
# Description: Check if tornado is actually used as a dependency in the project

# Search for tornado in all requirements files
echo "=== Checking requirements files for tornado ==="
fd -e txt -e in 'require' --exec grep -l 'tornado'

# Search for tornado imports in Python code
echo -e "\n=== Checking Python code for tornado imports ==="
rg -n --type=py 'import tornado|from tornado' -C2

Repository: NVIDIA/TensorRT-LLM

Length of output: 160

Remove tornado constraint; tornado is not a project dependency.

While GHSA-qjxf-f2mg-c6mc is a valid advisory (CVE-2026-31958, patched in Tornado 6.5.5), tornado does not appear in requirements files or as an import anywhere in the codebase. Adding a constraint for a non-existent dependency is incorrect and should be removed.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@constraints.txt` around lines 11 - 12, Remove the extraneous tornado
constraint from constraints.txt: delete the line "tornado>=6.5.5" (it’s not used
anywhere in the codebase and should not be enforced). Also search for any other
occurrences of "tornado" in requirements, constraints, or CI dependency pins and
remove them or revert changes that added the constraint so the project
dependency list only contains actual imports.

# WAR against https://github.com/advisories/GHSA-3936-cmfr-pm3m
black>=26.3.1
1 change: 0 additions & 1 deletion examples/models/core/gemma/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
nvidia-cudnn-cu12~=8.9; platform_machine == "x86_64"
tensorrt_llm>=0.0.0.dev0
flax~=0.8.0
numpy<2
# jax[cuda12_pip]~=0.4.19
safetensors~=0.4.1
sentencepiece>=0.1.99
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ opentelemetry-api>=1.26.0
opentelemetry-exporter-otlp>=1.26.0
opentelemetry-semantic-conventions-ai>=0.4.1
fuzzywuzzy==0.18.0
aiperf==0.4.0
aiperf==0.6.0
nanobind>=2.9.0
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ cuda-python>=13
diffusers>=0.27.0
lark
mpi4py
numpy<2
numpy>=2.0.0,<2.4 # numba 0.63.1 requires numpy<2.4
onnx>=1.18.0,<1.20.0
onnx_graphsurgeon>=0.5.2
openai
Expand Down Expand Up @@ -70,7 +70,7 @@ blobfile
openai-harmony==0.0.4
nvidia-cutlass-dsl==4.3.4; python_version >= "3.10"
plotly
numexpr<2.14.0 # WAR for attempted use of nonexistent numpy.typing
numexpr
partial_json_parser
apache-tvm-ffi==0.1.6 # used for reduce nvidia-cutlass-dsl host overhead
torch-c-dlpack-ext==0.1.3 # used for reduce nvidia-cutlass-dsl host overhead, optional package for improved torch tensor calling perf
Expand Down
Loading