[https://nvbugs/5844149][fix] Fix issues with DSV3.2 perf tests - #13054
[https://nvbugs/5844149][fix] Fix issues with DSV3.2 perf tests#13054brb-nv wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR modifies a performance benchmark submission script and updates three corresponding test configuration files. The Python script removes Slurm GPU resource flags and adds conditional logic to override multi-round settings for generation-only mode, writing an updated config file. Three YAML test configs are adjusted with modified token limits, sequence lengths, and KV cache memory allocation parameters. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #43808 [ run ] triggered by Bot. Commit: |
|
PR_Github #43808 [ run ] completed with state
|
…rver Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
5d515cc to
e0838e9
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #43899 [ run ] triggered by Bot. Commit: |
|
PR_Github #43899 [ run ] completed with state
|
Description
This MR addresses https://nvbugspro.nvidia.com/bug/5844149.
Test Coverage
Ran problem configs on target hardware.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit