[#7091][fix] remove INT8 from trtllm-bench --quantization choices - #13292
[#7091][fix] remove INT8 from trtllm-bench --quantization choices#13292Brumbelow wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded license header comments and a line-ending edit in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/bench/utils/__init__.py (1)
1-1:⚠️ Potential issue | 🟠 MajorAdd/update NVIDIA copyright header in this modified source file.
This file appears to be missing the required header (or latest modification year update), which is mandatory for modified TensorRT-LLM source files.
As per coding guidelines, "All TensorRT-LLM source files must contain an NVIDIA copyright header with the year of latest meaningful modification."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tensorrt_llm/bench/utils/__init__.py` at line 1, The file tensorrt_llm/bench/utils/__init__.py is missing the required NVIDIA copyright header; add the project's canonical header block at the very top of the file (above the existing import functools), updating the year to the latest meaningful modification year and preserving the exact template/format used across the repo, so the header appears before any code or imports in __init__.py.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tensorrt_llm/bench/utils/__init__.py`:
- Line 1: The file tensorrt_llm/bench/utils/__init__.py is missing the required
NVIDIA copyright header; add the project's canonical header block at the very
top of the file (above the existing import functools), updating the year to the
latest meaningful modification year and preserving the exact template/format
used across the repo, so the header appears before any code or imports in
__init__.py.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 65d1134d-d2bb-429d-b1d8-4b2e3b757ad6
📒 Files selected for processing (1)
tensorrt_llm/bench/utils/__init__.py
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Signed-off-by: Brumbelow <andrew.brumbelow@gmail.com>
[#7091][fix] Summary
trtllm-bench build --helpadvertisesINT8under-q/--quantization, but passing it crashes inQuantConfig.from_quant_algobecauseQUANT_ALGO_LISTattensorrt_llm/quantization/mode.py:52deliberately excludesQuantAlgo.INT8for weight quantization.Description
INT8from theVALID_QUANT_ALGOSLiteralintensorrt_llm/bench/utils/__init__.py.Literalis the single source feeding both Click's quantization choices and the Pydantic field type, so removing it here makes both layers reject the value cleanly instead of letting it fall through to the AssertionError.Test Coverage
tests/unittest/bench/CLI harness, and the existing runtime assertion inQuantConfig.from_quant_algocontinues to backstop the contract.trtllm-bench --model meta-llama/Llama-3.1-8B build --helpno longer listsINT8under--quantization(now 7 choices)--quantization INT8is rejected by Click before any model/engine code runs.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit