[https://nvbugs/6097980][fix] unwaive Wan T2V example by zhenhuaw-me · Pull Request #13316 · NVIDIA/TensorRT-LLM

zhenhuaw-me · 2026-04-22T03:40:12Z

The quick fix should have been done with #13193.

The config update and "skip warmup in testing" will be tracked by the JIRAs.

Summary by CodeRabbit

Tests
- A previously skipped test case has been re-enabled, expanding test coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

The quick fix should have been done with NVIDIA#13193. The config update and "skip warmup in testing" will be tracked by the JIRAs. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>

zhenhuaw-me · 2026-04-22T03:41:06Z

/bot run

coderabbitai · 2026-04-22T03:41:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fe506aa1-b747-44ba-b607-c2b0904a275a

📥 Commits

Reviewing files that changed from the base of the PR and between 0d2bea7 and a16f57a.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test waiver entry for full:DGX_B200/examples/test_visual_gen.py::test_wan_t2v_example was removed from the waiver list, indicating that this test is no longer expected to be skipped.

Changes

Cohort / File(s)	Summary
Test Waivers `tests/integration/test_lists/waives.txt`	Removed one SKIP waiver entry for `test_wan_t2v_example`, referencing issue `https://nvbugs/6097980`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete. It mentions this is a quick fix and references related work, but does not fill the template's Description, Test Coverage, and other required sections properly.	Complete the Description section explaining the issue and solution, add Test Coverage details, and ensure the PR Checklist is properly reviewed before merging.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly matches the changeset: it references the NVBugs ID and describes removing (unwaiving) the skip for the Wan T2V example test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2026-04-22T03:46:21Z

PR_Github #44873 [ run ] triggered by Bot. Commit: a16f57a Link to invocation

zhenhuaw-me · 2026-04-23T03:21:19Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-04-23T03:27:03Z

PR_Github #45092 [ run ] triggered by Bot. Commit: a16f57a Link to invocation

tensorrt-cicd · 2026-04-23T09:08:51Z

PR_Github #45092 [ run ] completed with state SUCCESS. Commit: a16f57a
/LLM/main/L0_MergeRequest_PR pipeline #35389 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

zhenhuaw-me · 2026-04-23T09:33:29Z

/bot run

tensorrt-cicd · 2026-04-23T09:39:45Z

PR_Github #45169 [ run ] triggered by Bot. Commit: a16f57a Link to invocation

tensorrt-cicd · 2026-04-23T17:20:26Z

PR_Github #45169 [ run ] completed with state SUCCESS. Commit: a16f57a
/LLM/main/L0_MergeRequest_PR pipeline #35446 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

zhenhuaw-me · 2026-04-24T01:45:42Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-04-24T01:52:42Z

PR_Github #45289 [ run ] triggered by Bot. Commit: 6900c83 Link to invocation

tensorrt-cicd · 2026-04-24T10:49:49Z

PR_Github #45289 [ run ] completed with state SUCCESS. Commit: 6900c83
/LLM/main/L0_MergeRequest_PR pipeline #35544 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

zhenhuaw-me · 2026-04-24T13:04:25Z

/bot run

tensorrt-cicd · 2026-04-24T13:10:36Z

PR_Github #45397 [ run ] triggered by Bot. Commit: 6900c83 Link to invocation

tensorrt-cicd · 2026-04-24T16:18:18Z

PR_Github #45397 [ run ] completed with state SUCCESS. Commit: 6900c83
/LLM/main/L0_MergeRequest_PR pipeline #35637 completed with status: 'SUCCESS'

CI Report

Link to invocation

Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>

zhenhuaw-me · 2026-04-25T03:05:02Z

/bot reuse-pipeline --message "This is an unwaive PR, the last pipeline passed. Reuse after resolving conflict."

tensorrt-cicd · 2026-04-25T03:12:57Z

PR_Github #45472 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --message This is an unwaive PR, the last pipeline passed. Reuse after resolving conflict.

Link to invocation

zhenhuaw-me · 2026-04-25T03:54:31Z

/bot reuse-pipeline --comment "This is an unwaive PR, the last pipeline passed. Reuse after resolving conflict."

tensorrt-cicd · 2026-04-25T04:00:42Z

PR_Github #45480 [ reuse-pipeline ] triggered by Bot. Commit: d4ba575 Link to invocation

tensorrt-cicd · 2026-04-25T04:12:49Z

PR_Github #45480 [ reuse-pipeline ] completed with state SUCCESS. Commit: d4ba575
Reusing PR_Github #45397 for commit d4ba575

Link to invocation

github-actions Bot assigned zhenhuaw-me Apr 22, 2026

[https://nvbugs/6097980][fix] unwaive Wan T2V example

a16f57a

The quick fix should have been done with NVIDIA#13193. The config update and "skip warmup in testing" will be tracked by the JIRAs. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>

zhenhuaw-me force-pushed the unwaive-wan-test branch from 830793f to a16f57a Compare April 22, 2026 03:40

zhenhuaw-me requested a review from ZhanruiSunCh April 22, 2026 07:57

ZhanruiSunCh approved these changes Apr 22, 2026

View reviewed changes

Merge branch 'main' into unwaive-wan-test

6900c83

Merge branch 'main' into unwaive-wan-test

9e2580e

Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>

zhenhuaw-me commented Apr 25, 2026

View reviewed changes

Comment thread tests/integration/test_lists/waives.txt Outdated

Update tests/integration/test_lists/waives.txt

d4ba575

Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>

zhenhuaw-me merged commit ce62383 into NVIDIA:main Apr 25, 2026
5 checks passed

zhenhuaw-me deleted the unwaive-wan-test branch April 25, 2026 12:01

Conversation

zhenhuaw-me commented Apr 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

zhenhuaw-me commented Apr 22, 2026

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented Apr 22, 2026

Uh oh!

zhenhuaw-me commented Apr 23, 2026

Uh oh!

tensorrt-cicd commented Apr 23, 2026

Uh oh!

tensorrt-cicd commented Apr 23, 2026

Uh oh!

zhenhuaw-me commented Apr 23, 2026

Uh oh!

tensorrt-cicd commented Apr 23, 2026

Uh oh!

tensorrt-cicd commented Apr 23, 2026

Uh oh!

zhenhuaw-me commented Apr 24, 2026

Uh oh!

tensorrt-cicd commented Apr 24, 2026

Uh oh!

tensorrt-cicd commented Apr 24, 2026

Uh oh!

zhenhuaw-me commented Apr 24, 2026

Uh oh!

tensorrt-cicd commented Apr 24, 2026

Uh oh!

tensorrt-cicd commented Apr 24, 2026

Uh oh!

Uh oh!

zhenhuaw-me commented Apr 25, 2026

Uh oh!

tensorrt-cicd commented Apr 25, 2026

Uh oh!

zhenhuaw-me commented Apr 25, 2026

Uh oh!

tensorrt-cicd commented Apr 25, 2026

Uh oh!

tensorrt-cicd commented Apr 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zhenhuaw-me commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading