[#12359][feat] AutoDeploy: Support SSM replay kernel for MTP with FlashInfer - #13725
Conversation
|
was there anything in particular you wanted me to review? Or helpful to look at nsys traces if we aren't seeing much perf improvement? |
@hnover-nv mostly for general awareness and to prevent dup. work. I'll ping you again when I move it out of draft. Still working on it. |
36e90e3 to
a80994e
Compare
c40f65c to
d73f109
Compare
📝 WalkthroughWalkthroughThis PR introduces SSM replay caching support for speculative MTP decoding. It defines replay buffer resource handlers, extends both FlashInfer and Triton backends with replay-aware execution paths, wires replay resources through the cache manager via configuration-driven transforms, and adds comprehensive test coverage with updated configurations. ChangesSSM Replay Infrastructure and Implementation
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Gal Hubara-Agam <96368689+galagam@users.noreply.github.com>
|
/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #51501 [ run ] triggered by Bot. Commit: |
|
PR_Github #51501 [ run ] completed with state |
Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
|
/bot run |
|
PR_Github #51572 [ run ] triggered by Bot. Commit: |
|
PR_Github #51572 [ run ] completed with state
|
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #51615 [ run ] triggered by Bot. Commit: |
|
PR_Github #51615 [ run ] completed with state
|
|
/bot run |
|
PR_Github #51760 [ run ] triggered by Bot. Commit: |
|
PR_Github #51760 [ run ] completed with state |
Summary by CodeRabbit
Release Notes
New Features
Improvements
Tests
Description
Integrate replay_selective_state_update (tl.dot fast-forward) into the
AD flashinfer_ssm backend as an optional path controlled by:
The replay kernel replaces the FlashInfer horizontal SSM scan in the MTP extend path with the same two-kernel algorithm the pytorch backend uses:
Test Coverage
Unit smoke (tests/unittest/auto_deploy/singlegpu/smoke/test_ad_speculative_decoding.py):
Accuracy (B200, ws4_180gb, trtllm backend):
nvfp4 + fp8: PASSED (GSM8K ~92%, acceptance_rate ~45%)
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.