[None][feat] Upgrade NIXL to v1.0.1 by zackyoray · Pull Request #13841 · NVIDIA/TensorRT-LLM

zackyoray · 2026-05-07T07:22:53Z

Summary by CodeRabbit

Chores
- Updated NIXL dependency to version v1.0.1 in development environment configuration.

zackyoray · 2026-05-07T07:23:13Z

/bot run --stage-list "Build-Docker-Images"

coderabbitai · 2026-05-07T07:25:19Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 25474ce1-5af9-40b3-b84d-448b50710126

📥 Commits

Reviewing files that changed from the base of the PR and between 0c7bddf and ed56f3c.

📒 Files selected for processing (1)

docker/common/install_nixl.sh

📝 Walkthrough

Walkthrough

The PR updates the NIXL dependency version in the Docker build script from 0.9.0 to v1.0.1. This single-line change modifies which Git tag is cloned and built during the Docker image construction process.

Changes

NIXL Dependency Update

Layer / File(s)	Summary
Version Update `docker/common/install_nixl.sh`	`NIXL_VERSION` variable updated from `0.9.0` to `v1.0.1` to use a newer tag when cloning and building NIXL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided, missing required sections like Description, Test Coverage, and PR Checklist.	Add a description following the template: explain what was changed and why, list relevant tests, and complete the PR checklist.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly indicates the main change: upgrading NIXL to v1.0.1, which matches the file changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2026-05-07T07:28:43Z

PR_Github #47156 [ run ] triggered by Bot. Commit: ed56f3c Link to invocation

zackyoray · 2026-05-07T08:07:01Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2026-05-07T08:14:28Z

PR_Github #47168 [ run ] triggered by Bot. Commit: f778218 Link to invocation

zackyoray · 2026-05-07T10:13:32Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2026-05-07T10:20:26Z

PR_Github #47190 [ run ] triggered by Bot. Commit: 803e0b0 Link to invocation

chuangz0 · 2026-05-08T03:13:48Z

please also change the nixl version in requirements-dev.txt

tensorrt-cicd · 2026-05-08T03:48:44Z

PR_Github #47190 [ run ] completed with state SUCCESS. Commit: 803e0b0
/LLM/main/L0_MergeRequest_PR pipeline #37148 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bo-nv · 2026-05-08T08:39:32Z

Please rebase and regenerate images, jenkins/current_image_tags.properties has been modified.

zackyoray · 2026-05-09T06:38:01Z

please also change the nixl version in requirements-dev.txt

thanks, i cherry-picked your change

zackyoray · 2026-05-09T06:38:19Z

/bot run --stage-list "Build-Docker-Images"

zackyoray · 2026-05-09T06:40:47Z

Please rebase and regenerate images, jenkins/current_image_tags.properties has been modified.

sure

tensorrt-cicd · 2026-05-09T06:43:41Z

PR_Github #47486 [ run ] triggered by Bot. Commit: 37eed36 Link to invocation

zackyoray · 2026-05-09T07:55:26Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2026-05-09T08:00:30Z

PR_Github #47492 [ run ] triggered by Bot. Commit: 96ba011 Link to invocation

tensorrt-cicd · 2026-05-09T15:56:20Z

PR_Github #47492 [ run ] completed with state SUCCESS. Commit: 96ba011
/LLM/main/L0_MergeRequest_PR pipeline #37412 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

zackyoray · 2026-05-09T16:02:55Z

/bot run --add-multi-gpu-test --disable-fail-fast

github-actions · 2026-05-09T16:03:02Z

⚠️ Bot command ignored: The /bot command must appear at the very beginning of the comment (no leading blank lines or spaces). Please post a new comment with /bot as the first character.

zackyoray · 2026-05-09T16:03:22Z

/bot run --add-multi-gpu-test --disable-fail-fast

Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>

Cherry-picked from PR NVIDIA#14056. Two related fixes to docker/common/install_ucx.sh: - Strip the trailing slash before `rm -rf "${UCX_INSTALL_PATH%/}"` so that a pre-existing symlink at /usr/local/ucx (NGC PyTorch ships it as a symlink to /opt/hpcx/ucx) is removed instead of being followed. - After `make install`, replace any pre-existing UCX under /opt/hpcx/ucx and /opt/hpcx-*/ucx with a symlink to the freshly installed /usr/local/ucx, and register /usr/local/ucx/lib with the dynamic linker via /etc/ld.so.conf.d/ucx.conf + ldconfig, so all binaries in the container resolve the same UCX SONAMEs. Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

zackyoray · 2026-05-19T08:34:28Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2026-05-19T08:41:39Z

PR_Github #49151 [ run ] triggered by Bot. Commit: d06cd85 Link to invocation

tensorrt-cicd · 2026-05-19T08:46:39Z

PR_Github #49151 [ run ] completed with state FAILURE. Commit: d06cd85

Link to invocation

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com> Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

zackyoray · 2026-05-19T09:50:38Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2026-05-19T09:56:14Z

PR_Github #49170 [ run ] triggered by Bot. Commit: d697cde Link to invocation

Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

zackyoray · 2026-05-19T12:43:37Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2026-05-19T12:50:28Z

PR_Github #49190 [ run ] triggered by Bot. Commit: 6c52be0 Link to invocation

tensorrt-cicd · 2026-05-20T03:56:31Z

PR_Github #49190 [ run ] completed with state FAILURE. Commit: 6c52be0
/LLM/main/L0_MergeRequest_PR pipeline #38866 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Squashed from upstream PR NVIDIA#13841 (NVIDIA/TensorRT-LLM): - Upgrade NIXL to v1.0.1 - Upgrade UCX to 1.21 - install_ucx.sh: replace pre-existing UCX with symlink - Add lib/ucx into libenv for CI PackageSanityCheck - Update images - Fix transfer bug Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>

pcastonguay · 2026-05-28T22:36:04Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2026-05-28T22:42:02Z

PR_Github #50902 [ run ] triggered by Bot. Commit: 6c52be0 Link to invocation

tensorrt-cicd · 2026-05-28T22:57:01Z

PR_Github #50902 [ run ] completed with state FAILURE. Commit: 6c52be0
/LLM/main/L0_MergeRequest_PR pipeline #40366 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Squashed from upstream PR NVIDIA#13841 (NVIDIA/TensorRT-LLM): - Upgrade NIXL to v1.0.1 - Upgrade UCX to 1.21 - install_ucx.sh: replace pre-existing UCX with symlink - Add lib/ucx into libenv for CI PackageSanityCheck - Update images - Fix transfer bug Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>

pcastonguay · 2026-06-22T11:45:23Z

Closing.

zackyoray requested a review from a team May 7, 2026 07:22

zackyoray requested review from a team as code owners May 7, 2026 07:22

zackyoray requested review from EmmaQiaoCh and mlefeb01 May 7, 2026 07:22

github-actions Bot assigned zackyoray May 7, 2026

zackyoray force-pushed the upgrade-nixl-v1.0.1 branch from 526b8c3 to f778218 Compare May 7, 2026 08:06

zackyoray requested a review from a team May 7, 2026 10:12

pcastonguay requested a review from bo-nv May 7, 2026 15:42

zackyoray force-pushed the upgrade-nixl-v1.0.1 branch from 803e0b0 to 37eed36 Compare May 9, 2026 06:37

zackyoray and others added 3 commits May 19, 2026 01:10

None][feat] Upgrade UCX to 1.21

7fc0477

Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

fix transfer bug

a113372

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>

add lib/ucx into libenv for CI PackageSanityCheck

d697cde

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com> Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

zackyoray force-pushed the upgrade-nixl-v1.0.1 branch from d06cd85 to d697cde Compare May 19, 2026 09:50

update images

6c52be0

Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>

chuangz0 mentioned this pull request May 22, 2026

[None][feat] Upgrade NIXL to v1.0.1 and UCX to 1.21 #14436

Merged

1 task

yuanjingx87 approved these changes May 26, 2026

View reviewed changes

pcastonguay closed this Jun 22, 2026

Uh oh!

Conversation

zackyoray commented May 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

zackyoray commented May 7, 2026

Uh oh!

coderabbitai Bot commented May 7, 2026

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented May 7, 2026

Uh oh!

zackyoray commented May 7, 2026

Uh oh!

tensorrt-cicd commented May 7, 2026

Uh oh!

zackyoray commented May 7, 2026

Uh oh!

tensorrt-cicd commented May 7, 2026

Uh oh!

chuangz0 commented May 8, 2026

Uh oh!

tensorrt-cicd commented May 8, 2026

Uh oh!

bo-nv commented May 8, 2026

Uh oh!

zackyoray commented May 9, 2026

Uh oh!

zackyoray commented May 9, 2026

Uh oh!

zackyoray commented May 9, 2026

Uh oh!

tensorrt-cicd commented May 9, 2026

Uh oh!

zackyoray commented May 9, 2026

Uh oh!

tensorrt-cicd commented May 9, 2026

Uh oh!

tensorrt-cicd commented May 9, 2026

Uh oh!

zackyoray commented May 9, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Uh oh!

zackyoray commented May 9, 2026

Uh oh!

zackyoray commented May 19, 2026

Uh oh!

tensorrt-cicd commented May 19, 2026

Uh oh!

tensorrt-cicd commented May 19, 2026

Uh oh!

zackyoray commented May 19, 2026

Uh oh!

tensorrt-cicd commented May 19, 2026

Uh oh!

zackyoray commented May 19, 2026

Uh oh!

tensorrt-cicd commented May 19, 2026

Uh oh!

tensorrt-cicd commented May 20, 2026

Uh oh!

pcastonguay commented May 28, 2026

Uh oh!

tensorrt-cicd commented May 28, 2026

Uh oh!

tensorrt-cicd commented May 28, 2026

Uh oh!

pcastonguay commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

zackyoray commented May 7, 2026 •

edited by coderabbitai Bot

Loading