[#13858][fix] AutoDeploy fix the piecewise vlm issue - #14006
Conversation
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #47790 [ run ] triggered by Bot. Commit: |
📝 WalkthroughWalkthroughThis PR enables piecewise CUDA graph compilation and optimizes static input buffer allocation in ChangesStatic Input Buffer Filtering
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/auto_deploy/config/default.yaml (1)
302-308:⚠️ Potential issue | 🔴 CriticalEnabling prototype piecewise CUDA graphs by default introduces stability and performance risks.
Piecewise CUDA graph support is marked as experimental/prototype in the codebase (commit
#11422). The feature has documented issues including severe memory fragmentation in logits (mitigated via warmup requests) and recent bug fixes (nvbugs/5880745 for MoE compatibility, VLM issues). More critically, existing piecewise tests in CI are marked TIMEOUT, indicating correctness or performance problems that will now affect all deployments by default.Before enabling this as the default, consider:
- Piecewise support should remain opt-in until production-ready status
- Investigate why existing piecewise tests timeout under B200 hardware
- Validate that memory fragmentation mitigations work correctly across batch sizes
- Add performance regression gates to prevent silent degradation
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tensorrt_llm/_torch/auto_deploy/config/default.yaml` around lines 302 - 308, The default config enables the experimental piecewise CUDA graphs (compile_model.piecewise_enabled: true), which is unstable; change the default to opt-in by setting compile_model.piecewise_enabled to false and leave piecewise_num_tokens as null, update any related documentation or comments near the compile_model block to indicate the feature is experimental and how to enable it, and ensure any CI or deployment gating checks reference this opt-in flag so piecewise remains disabled unless explicitly turned on.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tensorrt_llm/_torch/auto_deploy/config/default.yaml`:
- Around line 302-308: The default config enables the experimental piecewise
CUDA graphs (compile_model.piecewise_enabled: true), which is unstable; change
the default to opt-in by setting compile_model.piecewise_enabled to false and
leave piecewise_num_tokens as null, update any related documentation or comments
near the compile_model block to indicate the feature is experimental and how to
enable it, and ensure any CI or deployment gating checks reference this opt-in
flag so piecewise remains disabled unless explicitly turned on.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2769bebe-0b71-4a4b-845e-7c676fcb7625
📒 Files selected for processing (5)
tensorrt_llm/_torch/auto_deploy/compile/backends/torch_cudagraph.pytensorrt_llm/_torch/auto_deploy/compile/piecewise_utils.pytensorrt_llm/_torch/auto_deploy/config/default.yamltests/unittest/auto_deploy/singlegpu/compile/test_captured_graph.pytests/unittest/auto_deploy/singlegpu/compile/test_piecewise_utils.py
|
PR_Github #47790 [ run ] completed with state
|
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #47803 [ run ] triggered by Bot. Commit: |
|
PR_Github #47803 [ run ] completed with state
|
|
maybe we can try adding a smoke test https://sourcegraph.com/r/github.com/NVIDIA/TensorRT-LLM/-/blob/tests/unittest/auto_deploy/singlegpu/smoke/test_ad_build_small_single.py ? |
…m_0511 Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com> # Conflicts: # tensorrt_llm/_torch/auto_deploy/compile/piecewise_utils.py # tests/unittest/auto_deploy/singlegpu/compile/test_piecewise_utils.py
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #48948 [ run ] triggered by Bot. Commit: |
|
PR_Github #48948 [ run ] completed with state
|
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
|
PR_Github #48963 [ run ] triggered by Bot. Commit: |
|
PR_Github #48963 [ run ] completed with state
|
…m_0511 Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
…o chenghao/piecewise_vlm_0511 Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
|
PR_Github #49979 [ run ] triggered by Bot. Commit: |
|
PR_Github #49979 [ run ] completed with state
|
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
This reverts commit a75a643. Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
|
PR_Github #51385 [ run ] triggered by Bot. Commit: |
|
PR_Github #51385 [ run ] completed with state
|
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
|
PR_Github #51431 [ run ] triggered by Bot. Commit: |
|
PR_Github #51431 [ run ] completed with state |
…m_0511 Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com> # Conflicts: # tensorrt_llm/_torch/auto_deploy/compile/piecewise_utils.py
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
|
PR_Github #51643 [ run ] triggered by Bot. Commit: |
|
PR_Github #51643 [ run ] completed with state
|
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --post-merge |
|
PR_Github #53368 [ run ] triggered by Bot. Commit: |
|
PR_Github #53368 [ run ] completed with state
|
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --post-merge |
|
PR_Github #53376 [ run ] triggered by Bot. Commit: |
|
PR_Github #53376 [ run ] completed with state
|
|
/bot run --post-merge |
|
PR_Github #53466 [ run ] triggered by Bot. Commit: |
|
PR_Github #53466 [ run ] completed with state
|
|
/bot run --post-merge |
|
PR_Github #53612 [ run ] triggered by Bot. Commit: |
|
PR_Github #53612 [ run ] completed with state |
#13858
Enable the piecewise CG by default to see if there are any further errors.
The main fix is to move the Gamma related op to the dynamic split. Also update the kwargs capture to only capture the static related ones..
Summary by CodeRabbit
New Features
Improvements
Configuration Changes