[https://nvbugs/6095421][fix] In ModelConfig.resolve_moe_backend, after the GptOss branch, return "DEEPGEMM" w - #14182
Conversation
📝 WalkthroughWalkthroughThe PR adds Blackwell GPU-specific MOE backend selection to TensorRT-LLM's model configuration. It imports a GPU detection utility and adds a conditional branch in ChangesBlackwell MOE Backend Selection
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/model_config.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd/update the required NVIDIA copyright header on this modified Python source file.
This file appears to be missing the required TensorRT-LLM copyright/license header for modified source files.
As per coding guidelines "
**/*.{cpp,cc,cxx,h,hpp,hxx,cu,py}: All TensorRT-LLM source files must contain an NVIDIA copyright header with year of latest modification, using the Apache 2.0 license text."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tensorrt_llm/_torch/model_config.py` at line 1, This file tensorrt_llm/_torch/model_config.py is missing the required NVIDIA Apache-2.0 copyright header; add the standard TensorRT-LLM Apache 2.0 license header (with the year of latest modification) at the very top of the file before any imports (i.e., above the existing import contextlib line) so the file contains the official multi-line copyright and license block used across TensorRT-LLM Python sources.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tensorrt_llm/_torch/model_config.py`:
- Line 1: This file tensorrt_llm/_torch/model_config.py is missing the required
NVIDIA Apache-2.0 copyright header; add the standard TensorRT-LLM Apache 2.0
license header (with the year of latest modification) at the very top of the
file before any imports (i.e., above the existing import contextlib line) so the
file contains the official multi-line copyright and license block used across
TensorRT-LLM Python sources.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ec34a9d1-93e2-4de0-8bfa-5f8af6107ddc
📒 Files selected for processing (1)
tensorrt_llm/_torch/model_config.py
7cd4e5f to
721c243
Compare
|
/bot run |
|
PR_Github #48841 [ run ] triggered by Bot. Commit: |
|
PR_Github #48841 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #48859 [ run ] triggered by Bot. Commit: |
|
PR_Github #48859 [ run ] completed with state |
DeepSeek-V3-Lite-fp8 disagg test hangs on GB300 because resolve_moe_backend() returns CUTLASS for non-GptOss MoE models, and the CUTLASS FP8_BLOCK_SCALES path uses a DeepGEMM JIT kernel that only supports Hopper (SM90). On Blackwell (SM100/103) the worker throws 'fp8 blockscale gemm only support Hopper' during warmup; the disagg parent then deadlocks waiting for MPI_READY. Route AUTO moe_backend to DEEPGEMM on SM100/103, which natively supports these architectures with FP8_BLOCK_SCALES. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
721c243 to
b4c1d41
Compare
Summary
Test plan
Links
Summary by CodeRabbit