[None][fix] Return 3-tuple in check_gen_transfer_status early-return - #14214
Closed
lingjiew wants to merge 1 commit into
Closed
[None][fix] Return 3-tuple in check_gen_transfer_status early-return#14214lingjiew wants to merge 1 commit into
lingjiew wants to merge 1 commit into
Conversation
PR NVIDIA#14042 (c5226ec) added a perf shortcut that returns ([], []) when _ever_had_recv_session is False, but the contract from NVIDIA#12734 (feb4785) is a 3-tuple (completed, failed, cancelled_reqs). The caller in py_executor.py unpacks 3 values, so the shortcut crashes any GEN rank whose transceiver has not yet opened a recv session, e.g. early in a disagg benchmark before the first KV transfer reaches that rank. Symptom: "ValueError: not enough values to unpack (expected 3, got 2)" in PyExecutor event loop, leading to hang_detector firing on the remaining ranks 300s later. Signed-off-by: lingjiew <lingjiew@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14042 (c5226ec) added a perf shortcut that returns ([], []) when _ever_had_recv_session is False, but the contract from #12734 (feb4785) is a 3-tuple (completed, failed, cancelled_reqs). The caller in py_executor.py unpacks 3 values, so the shortcut crashes any GEN rank whose transceiver has not yet opened a recv session, e.g. early in a disagg benchmark before the first KV transfer reaches that rank.
Symptom: "ValueError: not enough values to unpack (expected 3, got 2)" in PyExecutor event loop, leading to hang_detector firing on the remaining ranks 300s later.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.