Skip to content

[None][chore] Remove closed bugs - #14217

Merged
xinhe-nv merged 4 commits into
NVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260517
May 20, 2026
Merged

[None][chore] Remove closed bugs#14217
xinhe-nv merged 4 commits into
NVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260517

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented May 17, 2026

Copy link
Copy Markdown
Collaborator

Remove closed bugs from waives.txt

Summary by CodeRabbit

Release Notes

  • Tests
    • Updated test skip waiver configurations for various model tests and performance benchmarks to reflect current testing requirements.

Review Change Stack

@xinhe-nv
xinhe-nv requested review from LarryXFly and crazydemo May 17, 2026 12:20
@xinhe-nv
xinhe-nv marked this pull request as ready for review May 18, 2026 06:18
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates tests/integration/test_lists/waives.txt to refresh test skip waivers across multiple model variants and test categories, including DeepSeek V3 Lite parameter optimization changes, GPTOSS and instruction-tuned architecture adjustments, Qwen3 configuration updates, multimodal example variants, hardware-specific benchmark waivers, and perf test suite identifiers.

Changes

Test Skip Waiver Updates

Layer / File(s) Summary
DeepSeek V3 Lite waivers
tests/integration/test_lists/waives.txt
Replaced bfloat16 parameter variants (KV-cache, cuda-graph, overlap-scheduler, torch-compile) and moe-backend nvfp4 TRTLLM entries; removed FP8 quant benchmark perf waiver.
GPTOSS and instruction-tuned model waivers
tests/integration/test_lists/waives.txt
Replaced GPTOSS variants (eagle3 guided-decoding, w4/w4_chunked_prefill); removed Llama3_1_8B Instruct fp8_4gpus FLASHINFER and xgrammar guided-decoding skip entries.
Qwen3 model configuration waivers
tests/integration/test_lists/waives.txt
Updated Qwen3 skip entries (Qwen3_30B, Qwen3_5_35B, Qwen3_5_4B) with new enable_block_reuse permutation variants.
Multimodal and example waivers
tests/integration/test_lists/waives.txt
Replaced multimodal skip entries by removing prior Nemotron/Phi/Qwen2-audio/ray variants and adding new multimodal and parameterized example configurations.
Hardware-scoped performance and accuracy waivers
tests/integration/test_lists/waives.txt
Replaced hardware-specific waiver entries for H100_PCIe, H20, RTX variants, RTXPro6000D, and B200/Blackwell accelerators.
Perf test suite waivers
tests/integration/test_lists/waives.txt
Replaced large contiguous block of perf/test_perf.py and perf/test_perf_sanity.py waiver identifiers with updated benchmark parameter strings and SLACK-linked notes.
Miscellaneous skip waiver cleanup
tests/integration/test_lists/waives.txt
Removed isolated waivers: e2e quickstart ngram test, MOE fp4 gptoss-style variant, and mrope delta-cache autodeploy configuration test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14118: Main PR broadly rewrites tests/integration/test_lists/waives.txt with overlapping GPTOSS waiver entry modifications.
  • NVIDIA/TensorRT-LLM#10586: Both PRs modify the same waiver file by removing/updating DeepSeek V3 Lite and guided-decoding/xgrammar skip entries.
  • NVIDIA/TensorRT-LLM#14169: Both PRs modify tests/integration/test_lists/waives.txt by removing DeepSeek V3 Lite FP8-related skip entries.

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal but directly relates to the change. However, it lacks the structure specified in the template (no sections for Description, Test Coverage, or PR Checklist). Provide more detail by adding a Description section explaining which bugs were closed and why they're being removed, and confirm test coverage for this maintenance change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is fully related to the changeset, which removes waiver entries from waives.txt as mentioned in the PR description.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 46: The waive entry
"accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_fp8_block_scales[mtp=vanilla-fp8kv=False-attention_dp=False-cuda_graph=False-overlap_scheduler=False-torch_compile=False]"
is out of alphabetical order in tests/integration/test_lists/waives.txt; move
that entire line so it appears immediately after the
"test_bfloat16_python_scheduler" entry (i.e., ensure
"test_bfloat16_python_scheduler" precedes "test_fp8_block_scales"
alphabetically), then re-run the pre-commit file-contents-sorter or pre-commit
hook to verify the file is sorted.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 97df7ca8-7a7c-463f-b7bd-af781a60a1b1

📥 Commits

Reviewing files that changed from the base of the PR and between 7095183 and 4b5d4a9.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt Outdated
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48845 [ run ] triggered by Bot. Commit: 157d511 Link to invocation

@xinhe-nv
xinhe-nv requested a review from StanleySun639 May 18, 2026 06:53
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48845 [ run ] completed with state SUCCESS. Commit: 157d511
/LLM/main/L0_MergeRequest_PR pipeline #38600 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48905 [ run ] triggered by Bot. Commit: 157d511 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48905 [ run ] completed with state FAILURE. Commit: 157d511
/LLM/main/L0_MergeRequest_PR pipeline #38655 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48914 [ run ] triggered by Bot. Commit: 157d511 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48914 [ run ] completed with state FAILURE. Commit: 157d511
/LLM/main/L0_MergeRequest_PR pipeline #38664 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv
xinhe-nv enabled auto-merge (squash) May 18, 2026 14:05
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49059 [ run ] triggered by Bot. Commit: 01ef036 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49059 [ run ] completed with state SUCCESS. Commit: 01ef036
/LLM/main/L0_MergeRequest_PR pipeline #38791 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49095 [ run ] triggered by Bot. Commit: 01ef036 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49098 [ run ] triggered by Bot. Commit: 7f0b864 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49095 [ run ] completed with state ABORTED. Commit: 01ef036

Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49102 [ run ] triggered by Bot. Commit: 7f0b864 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49098 [ run ] completed with state ABORTED. Commit: 7f0b864

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49102 [ run ] completed with state SUCCESS. Commit: 7f0b864
/LLM/main/L0_MergeRequest_PR pipeline #38812 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot --help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49173 [ run ] triggered by Bot. Commit: 9600616 Link to invocation

xinhe-nv added 3 commits May 20, 2026 17:46
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
xinhe-nv force-pushed the user/qa/unwaive_20260517 branch from 1fc5345 to 593c9f1 Compare May 20, 2026 09:46
@xinhe-nv
xinhe-nv requested review from a team as code owners May 20, 2026 09:46
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49407 [ run ] triggered by Bot. Commit: fd1f833 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49173 [ run ] completed with state ABORTED. Commit: 9600616

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49407 [ run ] completed with state SUCCESS. Commit: fd1f833
/LLM/main/L0_MergeRequest_PR pipeline #39056 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@xinhe-nv
xinhe-nv merged commit 234c9e4 into NVIDIA:main May 20, 2026
7 checks passed
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
xinhe-nv deleted the user/qa/unwaive_20260517 branch June 30, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants