[None][chore] Remove closed bugs - #14217
Conversation
|
/bot run |
📝 WalkthroughWalkthroughThis PR updates ChangesTest Skip Waiver Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 46: The waive entry
"accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_fp8_block_scales[mtp=vanilla-fp8kv=False-attention_dp=False-cuda_graph=False-overlap_scheduler=False-torch_compile=False]"
is out of alphabetical order in tests/integration/test_lists/waives.txt; move
that entire line so it appears immediately after the
"test_bfloat16_python_scheduler" entry (i.e., ensure
"test_bfloat16_python_scheduler" precedes "test_fp8_block_scales"
alphabetically), then re-run the pre-commit file-contents-sorter or pre-commit
hook to verify the file is sorted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 97df7ca8-7a7c-463f-b7bd-af781a60a1b1
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #48845 [ run ] triggered by Bot. Commit: |
|
PR_Github #48845 [ run ] completed with state
|
|
/bot run |
|
PR_Github #48905 [ run ] triggered by Bot. Commit: |
|
PR_Github #48905 [ run ] completed with state
|
|
/bot run |
|
PR_Github #48914 [ run ] triggered by Bot. Commit: |
|
PR_Github #48914 [ run ] completed with state
|
|
/bot run |
|
PR_Github #49059 [ run ] triggered by Bot. Commit: |
|
PR_Github #49059 [ run ] completed with state
|
|
/bot run |
|
PR_Github #49095 [ run ] triggered by Bot. Commit: |
|
PR_Github #49098 [ run ] triggered by Bot. Commit: |
|
PR_Github #49095 [ run ] completed with state |
|
/bot run |
|
PR_Github #49102 [ run ] triggered by Bot. Commit: |
|
PR_Github #49098 [ run ] completed with state |
|
PR_Github #49102 [ run ] completed with state
|
|
/bot --help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --disable-fail-fast |
|
PR_Github #49173 [ run ] triggered by Bot. Commit: |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
1fc5345 to
593c9f1
Compare
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #49407 [ run ] triggered by Bot. Commit: |
|
PR_Github #49173 [ run ] completed with state |
|
PR_Github #49407 [ run ] completed with state |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Remove closed bugs from waives.txt
Summary by CodeRabbit
Release Notes