Skip to content

[https://nvbugs/6179426][fix] Centralize UCX env setup for disagg unit tests in conftest - #14249

Merged
Shixiaowei02 merged 1 commit into
NVIDIA:feat/deepseek_v4from
Shixiaowei02:fixup/cpp-shutdown-timeout
May 19, 2026
Merged

[https://nvbugs/6179426][fix] Centralize UCX env setup for disagg unit tests in conftest#14249
Shixiaowei02 merged 1 commit into
NVIDIA:feat/deepseek_v4from
Shixiaowei02:fixup/cpp-shutdown-timeout

Conversation

@Shixiaowei02

@Shixiaowei02 Shixiaowei02 commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@Shixiaowei02
Shixiaowei02 requested a review from a team as a code owner May 18, 2026 08:57
@Shixiaowei02
Shixiaowei02 requested review from leslie-fang25 and liji-nv and removed request for a team May 18, 2026 08:57
@Shixiaowei02
Shixiaowei02 requested a review from chuangz0 May 18, 2026 08:57
@Shixiaowei02 Shixiaowei02 changed the title [None][fix] Bound NIXL cpp_agent.shutdown() to avoid blocking caller [https://nvbugs/6180247][fix] Bound NIXL cpp_agent.shutdown() to avoid blocking caller May 18, 2026
@Shixiaowei02

Shixiaowei02 commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48880 [ run ] triggered by Bot. Commit: 9684d03 Link to invocation

@Shixiaowei02
Shixiaowei02 force-pushed the fixup/cpp-shutdown-timeout branch 2 times, most recently from 8a503d8 to a0b3a09 Compare May 18, 2026 09:39
@Shixiaowei02

Shixiaowei02 commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@Shixiaowei02 Shixiaowei02 changed the title [https://nvbugs/6180247][fix] Bound NIXL cpp_agent.shutdown() to avoid blocking caller [https://nvbugs/6180247][fix] Exclude UCX tcp transport in disagg unit tests May 18, 2026
@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48889 [ run ] triggered by Bot. Commit: a0b3a09 Link to invocation

@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48880 [ run ] completed with state ABORTED. Commit: 9684d03

Link to invocation

@Shixiaowei02
Shixiaowei02 force-pushed the fixup/cpp-shutdown-timeout branch 2 times, most recently from 2a54502 to 872b7c2 Compare May 18, 2026 09:57
@Shixiaowei02

Shixiaowei02 commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@Shixiaowei02 Shixiaowei02 changed the title [https://nvbugs/6180247][fix] Exclude UCX tcp transport in disagg unit tests [https://nvbugs/6179426][fix] Exclude UCX tcp transport in disagg unit tests May 18, 2026
@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48893 [ run ] triggered by Bot. Commit: 872b7c2 Link to invocation

@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48889 [ run ] completed with state ABORTED. Commit: a0b3a09

Link to invocation

@Shixiaowei02
Shixiaowei02 force-pushed the fixup/cpp-shutdown-timeout branch 2 times, most recently from 5577bf5 to 74f34c6 Compare May 18, 2026 11:56
@Shixiaowei02

Shixiaowei02 commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48902 [ run ] triggered by Bot. Commit: 74f34c6 Link to invocation

@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48893 [ run ] completed with state ABORTED. Commit: 872b7c2

Link to invocation

@tensorrt-cicd

tensorrt-cicd commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #48902 [ run ] completed with state SUCCESS. Commit: 74f34c6
/LLM/main/L0_MergeRequest_PR pipeline #38651 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@Shixiaowei02
Shixiaowei02 force-pushed the fixup/cpp-shutdown-timeout branch from 74f34c6 to 30b999e Compare May 19, 2026 02:49
@Shixiaowei02
Centralize UCX env setup for disagg unit tests in conftest
5b0f0af 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02
Shixiaowei02 force-pushed the fixup/cpp-shutdown-timeout branch from 30b999e to 5b0f0af Compare May 19, 2026 02:53
@Shixiaowei02

Shixiaowei02 commented May 19, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@Shixiaowei02 Shixiaowei02 changed the title [https://nvbugs/6179426][fix] Exclude UCX tcp transport in disagg unit tests [https://nvbugs/6179426][fix] Centralize UCX env setup for disagg unit tests in conftest May 19, 2026
@tensorrt-cicd

tensorrt-cicd commented May 19, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #49055 [ run ] triggered by Bot. Commit: 5b0f0af Link to invocation

@Shixiaowei02
Shixiaowei02 requested a review from bo-nv May 19, 2026 04:44
@tensorrt-cicd

tensorrt-cicd commented May 19, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #49055 [ run ] completed with state SUCCESS. Commit: 5b0f0af
/LLM/main/L0_MergeRequest_PR pipeline #38786 completed with status: 'SUCCESS'

CI Report

Link to invocation

@Shixiaowei02
Shixiaowei02 merged commit f4d5e59 into NVIDIA:feat/deepseek_v4 May 19, 2026
8 checks passed
@Shixiaowei02
Shixiaowei02 deleted the fixup/cpp-shutdown-timeout branch May 19, 2026 07:03
lfr-0531 pushed a commit to lfr-0531/TensorRT-LLM that referenced this pull request Jun 10, 2026
@Shixiaowei02 @lfr-0531
[https://nvbugs/6179426][fix] Centralize UCX env setup for disagg uni…
97f4dd5 
…t tests in conftest (NVIDIA#14249)

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
lfr-0531 pushed a commit to lfr-0531/TensorRT-LLM that referenced this pull request Jun 11, 2026
@Shixiaowei02 @lfr-0531
[https://nvbugs/6179426][fix] Centralize UCX env setup for disagg uni…
73c152a 
…t tests in conftest (NVIDIA#14249)

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
lfr-0531 pushed a commit to lfr-0531/TensorRT-LLM that referenced this pull request Jun 12, 2026
@Shixiaowei02 @lfr-0531
[https://nvbugs/6179426][fix] Centralize UCX env setup for disagg uni…
0fb96b6 
…t tests in conftest (NVIDIA#14249)

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liji-nv liji-nv Awaiting requested review from liji-nv liji-nv was automatically assigned from NVIDIA/trt-llm-torch-devs
@leslie-fang25 leslie-fang25 Awaiting requested review from leslie-fang25 leslie-fang25 was automatically assigned from NVIDIA/trt-llm-torch-devs
@chuangz0 chuangz0 Awaiting requested review from chuangz0
@bo-nv bo-nv Awaiting requested review from bo-nv

Assignees

@Shixiaowei02 Shixiaowei02

Labels

deepseek-v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shixiaowei02 @tensorrt-cicd