Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 38804 - #14317

Closed
ZhanruiSunCh wants to merge 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260519-172853
Closed

[None][infra] Waive 1 failed cases for main in pre-merge 38804#14317
ZhanruiSunCh wants to merge 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260519-172853

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @MrGeva)
Target branch: main
Bug(s): 6192453

Waive entries added

unittest/kv_cache_manager_v2_tests/test_kv_cache_salting.py::TestKVCacheSaltCounters::test_aggregate_counters_match_expected SKIP (https://nvbugs/6192453)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

Release Notes

  • Tests
    • Updated test skip configuration to address a known issue.

Note: This release contains internal testing infrastructure updates with no user-facing changes.

Review Change Stack

Bug(s): 6192453
Requested by: @MrGeva

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@MrGeva

MrGeva commented May 19, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive PR"

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1d4a944a-248a-4b4a-b812-d54f89dde556

📥 Commits

Reviewing files that changed from the base of the PR and between b2a5070 and d6032b4.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR adds a single test waiver entry to the integration test waivers list, skipping the test_aggregate_counters_match_expected test in the KV cache salting test suite and linking it to NV bug 6192453.

Changes

Test Waiver Entry

Layer / File(s) Summary
KV cache salting counter test waiver
tests/integration/test_lists/waives.txt
A SKIP waiver is registered for the KV cache salting counter aggregation test, referencing NV bug 6192453.

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14094: Both PRs modify the same test case waiver for test_aggregate_counters_match_expected in the KV cache salting suite, with different NV bug references.
  • NVIDIA/TensorRT-LLM#14093: Both PRs update tests/integration/test_lists/waives.txt by adding new SKIP waiver entries for failing test cases.
  • NVIDIA/TensorRT-LLM#14283: Both PRs modify tests/integration/test_lists/waives.txt by adding SKIP waiver entries for failed tests with linked NV bug references.

Suggested reviewers

  • yihwang-nv

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It lacks the standard sections required by the template: 'Description' (explaining the issue and solution), 'Test Coverage', and the PR Checklist. While it provides auto-generated waive information, it does not follow the documented description template structure. Add the missing template sections: provide a brief description of why the test is being waived, clarify test coverage implications, and complete the PR Checklist to confirm adherence to coding guidelines and other repository standards.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the repository template format [ticket/bug][type] and accurately describes the purpose: waiving a failed test case due to an infrastructure change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49241 [ skip ] triggered by Bot. Commit: d6032b4 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49241 [ skip ] completed with state SUCCESS. Commit: d6032b4
Release Check Pipeline #3932 failed

Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator

test_aggregate_counters_match_expected was removed in #14140

@tburt-nv tburt-nv closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants