Skip to content

[None][chore] Clean test_durations file by removing outdated items. - #14340

Merged
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/clean_test_durations
May 20, 2026
Merged

[None][chore] Clean test_durations file by removing outdated items.#14340
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/clean_test_durations

Conversation

@nv-guomingz

@nv-guomingz nv-guomingz commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal test duration configurations for benchmark suites.

Note: This PR contains no user-facing changes and is focused on internal testing infrastructure.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@nv-guomingz

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 86780ce0-8aaf-4552-b56b-ddb3885737a3

📥 Commits

Reviewing files that changed from the base of the PR and between aac0d65 and d0804e9.

📒 Files selected for processing (1)
  • tests/integration/defs/.test_durations

📝 Walkthrough

Walkthrough

Updated the centralized .test_durations configuration file to remove obsolete benchmark duration entries and add curated durations for current test suites. Changes span accuracy tests, example model tests, E2E/performance tests, and deprecated metadata removal, consolidating test duration management across TensorRT-LLM integration suites.

Changes

Test Duration Curation

Layer / File(s) Summary
Accuracy and core LLM test cleanup
tests/integration/defs/.test_durations
Pruned quantization/scheduling variants from accuracy/test_llm_api.py and removed unused examples/test_llm_api_pytorch.py entries for Llama4 and Eagle configurations.
Example model test duration updates
tests/integration/defs/.test_durations
Updated benchmark durations across multiple example model test files: replaced ChatGLM/CommandR configurations, consolidated Eagle variants, substantially updated GPT/Gemma/Llama blocks, adjusted Medusa/Mistral entries, and curated Phi/Qwen configurations.
E2E, performance, and infrastructure test updates
tests/integration/defs/.test_durations
Updated perf/test_perf.py, test_e2e.py, and llmapi example/E2E test duration entries; removed deprecated PTP quickstart advanced and multimodal chunked-prefill variants.
Metadata cleanup
tests/integration/defs/.test_durations
Removed the top-level test_mode JSON duration entry from the configuration map.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • xinhe-nv
  • galagam
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely template boilerplate with no actual content provided in the Description, Test Coverage, or substantive checklist sections. Fill in the Description section explaining why outdated entries were removed, and add Test Coverage section detailing which tests verify the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing outdated items from the test_durations file, which aligns with the 176 lines removed shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49363 [ run ] triggered by Bot. Commit: d0804e9 Link to invocation

@nv-guomingz
nv-guomingz enabled auto-merge (squash) May 20, 2026 06:50
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49363 [ run ] completed with state SUCCESS. Commit: d0804e9
/LLM/main/L0_MergeRequest_PR pipeline #39017 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz
nv-guomingz requested a review from ZhanruiSunCh May 20, 2026 09:34
@nv-guomingz
nv-guomingz merged commit b5d64e2 into NVIDIA:main May 20, 2026
14 of 15 checks passed
@nv-guomingz
nv-guomingz deleted the user/guomingz/clean_test_durations branch May 21, 2026 03:14
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
…VIDIA#14340)

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…VIDIA#14340)

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants